From 402d6fe1132166aa137c9f4179c5ad53b42e6ce9 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Sat, 25 Nov 2023 08:32:27 -0600 Subject: [PATCH] Remove unreachable check in connection send_messages (#704) --- aioesphomeapi/connection.pxd | 1 + aioesphomeapi/connection.py | 17 ++++++----------- 2 files changed, 7 insertions(+), 11 deletions(-) diff --git a/aioesphomeapi/connection.pxd b/aioesphomeapi/connection.pxd index 38002c9..bcd13ee 100644 --- a/aioesphomeapi/connection.pxd +++ b/aioesphomeapi/connection.pxd @@ -41,6 +41,7 @@ cdef object HandshakeAPIError cdef object PingFailedAPIError cdef object ReadFailedAPIError cdef object TimeoutAPIError +cdef object SocketAPIError cdef object astuple diff --git a/aioesphomeapi/connection.py b/aioesphomeapi/connection.py index ad0d7b4..c2de199 100644 --- a/aioesphomeapi/connection.py +++ b/aioesphomeapi/connection.py @@ -611,21 +611,16 @@ class APIConnection: f"Connection isn't established yet ({self.connection_state})" ) - packets: list[tuple[int, bytes]] = [] - debug_enabled = self._debug_enabled + packets: list[tuple[int, bytes]] = [ + (PROTO_TO_MESSAGE_TYPE[type(msg)], msg.SerializeToString()) for msg in msgs + ] - for msg in msgs: - msg_type = type(msg) - if (message_type := PROTO_TO_MESSAGE_TYPE.get(msg_type)) is None: - raise ValueError(f"Message type id not found for type {msg_type}") - - if debug_enabled: + if debug_enabled := self._debug_enabled: + for msg in msgs: _LOGGER.debug( - "%s: Sending %s: %s", self.log_name, msg_type.__name__, msg + "%s: Sending %s: %s", self.log_name, type(msg).__name__, msg ) - packets.append((message_type, msg.SerializeToString())) - if TYPE_CHECKING: assert self._frame_helper is not None