Upstream/aioesphomeapi
1
0
Fork 0
mirror of https://github.com/esphome/aioesphomeapi.git synced 2024-11-29 13:15:10 +01:00
Code Issues Projects Releases Wiki Activity

Refactor internal message handlers to use a single dispatch path (#598)

Browse Source
This commit is contained in:
J. Nick Koston 2023-10-22 07:05:53 -10:00 committed by GitHub
parent 44330afae0
commit 8c37f088d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 34 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
aioesphomeapi/connection.py
View File

@ -60,9 +60,6 @@ _LOGGER = logging.getLogger(__name__)
BUFFER_SIZE = 1024 * 1024 * 2 # Set buffer limit to 2MB BUFFER_SIZE = 1024 * 1024 * 2 # Set buffer limit to 2MB
INTERNAL_MESSAGE_TYPES = {GetTimeRequest, PingRequest, DisconnectRequest}
DISCONNECT_REQUEST_MESSAGE = DisconnectRequest() DISCONNECT_REQUEST_MESSAGE = DisconnectRequest()
DISCONNECT_RESPONSE_MESSAGE = DisconnectResponse() DISCONNECT_RESPONSE_MESSAGE = DisconnectResponse()
PING_REQUEST_MESSAGE = PingRequest() PING_REQUEST_MESSAGE = PingRequest()
@ -524,6 +521,7 @@ class APIConnection:
"""Finish the connection process.""" """Finish the connection process."""
in_do_connect.set(True) in_do_connect.set(True)
await self._connect_init_frame_helper() await self._connect_init_frame_helper()
self._register_internal_message_handlers()
await self._connect_hello() await self._connect_hello()
if login: if login:
await self._login() await self._login()
@ -832,13 +830,36 @@ class APIConnection:
for handler in handlers_copy: for handler in handlers_copy:
handler(msg) handler(msg)
if msg_type is DisconnectRequest: def _register_internal_message_handlers(self) -> None:
"""Register internal message handlers."""
self._add_message_callback_without_remove(
self._handle_disconnect_request_internal, (DisconnectRequest,)
)
self._add_message_callback_without_remove(
self._handle_ping_request_internal, (PingRequest,)
)
self._add_message_callback_without_remove(
self._handle_get_time_request_internal, (GetTimeRequest,)
)
def _handle_disconnect_request_internal( # pylint: disable=unused-argument
self, _msg: DisconnectRequest
) -> None:
"""Handle a DisconnectRequest."""
self.send_message(DISCONNECT_RESPONSE_MESSAGE) self.send_message(DISCONNECT_RESPONSE_MESSAGE)
self._expected_disconnect = True self._expected_disconnect = True
self._cleanup() self._cleanup()
elif msg_type is PingRequest:
def _handle_ping_request_internal( # pylint: disable=unused-argument
self, _msg: PingRequest
) -> None:
"""Handle a PingRequest."""
self.send_message(PING_RESPONSE_MESSAGE) self.send_message(PING_RESPONSE_MESSAGE)
elif msg_type is GetTimeRequest:
def _handle_get_time_request_internal( # pylint: disable=unused-argument
self, _msg: GetTimeRequest
) -> None:
"""Handle a GetTimeRequest."""
resp = GetTimeResponse() resp = GetTimeResponse()
resp.epoch_seconds = int(time.time()) resp.epoch_seconds = int(time.time())
self.send_message(resp) self.send_message(resp)