Upstream
/
aioesphomeapi
mirror of https://github.com/esphome/aioesphomeapi.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Guard a few frequently called instance checks with if TYPE_CHECKING (#469)

This commit is contained in:
J. Nick Koston 2023-07-15 07:55:07 -10:00 committed by GitHub
parent dd6eb76667
commit 9112a68bf9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
aioesphomeapi/client.py
View File

@ -482,11 +482,9 @@ class APIClient:
assert self._connection is not None
def is_response(msg: message.Message) -> bool:
return (
isinstance(msg, msg_types)
and msg.address == address # type: ignore[union-attr]
and msg.handle == handle # type: ignore[union-attr]
)
if TYPE_CHECKING:
assert isinstance(msg, msg_types)
return bool(msg.address == address and msg.handle == handle) # type: ignore[union-attr]
resp = await self._connection.send_message_await_response_complex(
request, is_response, is_response, msg_types, timeout=timeout
@ -694,7 +692,8 @@ class APIClient:
assert self._connection is not None
def predicate_func(msg: message.Message) -> bool:
assert isinstance(msg, msg_types)
if TYPE_CHECKING:
assert isinstance(msg, msg_types)
if msg.address != address:
return False
if isinstance(msg, BluetoothDeviceConnectionResponse):