From dba6c72735118ad6dd288ceacd12472c77b34591 Mon Sep 17 00:00:00 2001
From: "J. Nick Koston" <nick@koston.org>
Date: Fri, 24 Nov 2023 09:01:40 -0600
Subject: [PATCH] Add test for empty noise hello (#684)

---
 tests/test__frame_helper.py | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/tests/test__frame_helper.py b/tests/test__frame_helper.py
index 3f699e7..4c024cc 100644
--- a/tests/test__frame_helper.py
+++ b/tests/test__frame_helper.py
@@ -621,6 +621,36 @@ async def test_init_noise_with_wrong_byte_marker(noise_conn: APIConnection) -> N
             await task
 
 
+@pytest.mark.asyncio
+async def test_noise_frame_helper_empty_hello():
+    """Test empty hello with noise."""
+    connection, _ = _make_mock_connection()
+    helper = MockAPINoiseFrameHelper(
+        connection=connection,
+        noise_psk="QRTIErOb/fcE9Ukd/5qA3RGYMn0Y+p06U58SCtOXvPc=",
+        expected_name="servicetest",
+        client_info="my client",
+        log_name="test",
+    )
+    helper._transport = MagicMock()
+    helper._writer = MagicMock()
+
+    handshake_task = asyncio.create_task(helper.perform_handshake(30))
+    empty_hello_pkt = b""
+    preamble = 1
+    hello_pkg_length = len(empty_hello_pkt)
+    hello_pkg_length_high = (hello_pkg_length >> 8) & 0xFF
+    hello_pkg_length_low = hello_pkg_length & 0xFF
+    hello_header = bytes((preamble, hello_pkg_length_high, hello_pkg_length_low))
+    hello_pkt_with_header = hello_header + empty_hello_pkt
+
+    with pytest.raises(HandshakeAPIError, match="ServerHello is empty"):
+        helper.data_received(hello_pkt_with_header)
+
+    with pytest.raises(HandshakeAPIError, match="ServerHello is empty"):
+        await handshake_task
+
+
 @pytest.mark.asyncio
 async def test_init_noise_attempted_when_esp_uses_plaintext(
     noise_conn: APIConnection,