From 0a9e9c29166d24126761a08722f8c9f7f8ba25fc Mon Sep 17 00:00:00 2001
From: Tastybento <tastybento@wasteofplastic.com>
Date: Wed, 4 Apr 2018 19:25:13 -0700
Subject: [PATCH] Removed stack print and added a test.

---
 .../bskyblock/managers/IslandsManager.java    |  4 +-
 .../managers/IslandsManagerTest.java          | 51 ++++++++++++++++++-
 2 files changed, 53 insertions(+), 2 deletions(-)

diff --git a/src/main/java/us/tastybento/bskyblock/managers/IslandsManager.java b/src/main/java/us/tastybento/bskyblock/managers/IslandsManager.java
index f033707ec..72977233b 100644
--- a/src/main/java/us/tastybento/bskyblock/managers/IslandsManager.java
+++ b/src/main/java/us/tastybento/bskyblock/managers/IslandsManager.java
@@ -146,6 +146,9 @@ public class IslandsManager {
      * @return - safe location, or null if none can be found
      */
     public Location bigScan(Location l, int i) {
+        if (l == null) {
+            return null;
+        }
         final int height;
         final int depth;
         if (i > 0) {
@@ -642,7 +645,6 @@ public class IslandsManager {
             }
         } catch (Exception e) {
             plugin.getLogger().severe(()->"Could not load islands to cache! " + e.getMessage());
-            e.printStackTrace();
         }
     }
 
diff --git a/src/test/java/us/tastybento/bskyblock/managers/IslandsManagerTest.java b/src/test/java/us/tastybento/bskyblock/managers/IslandsManagerTest.java
index 50c60e8b5..2c69a4436 100644
--- a/src/test/java/us/tastybento/bskyblock/managers/IslandsManagerTest.java
+++ b/src/test/java/us/tastybento/bskyblock/managers/IslandsManagerTest.java
@@ -1,6 +1,7 @@
 package us.tastybento.bskyblock.managers;
 
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
@@ -28,9 +29,10 @@ import org.powermock.reflect.Whitebox;
 
 import us.tastybento.bskyblock.BSkyBlock;
 import us.tastybento.bskyblock.Settings;
+import us.tastybento.bskyblock.generators.IslandWorld;
 
 @RunWith(PowerMockRunner.class)
-@PrepareForTest( { BSkyBlock.class })
+@PrepareForTest( { BSkyBlock.class, IslandsManager.class })
 public class IslandsManagerTest {
 
     @Mock
@@ -59,6 +61,7 @@ public class IslandsManagerTest {
         Whitebox.setInternalState(BSkyBlock.class, "instance", plugin);
         when(Bukkit.getLogger()).thenReturn(Logger.getAnonymousLogger());
 
+        
     }
 
     @Test
@@ -99,6 +102,9 @@ public class IslandsManagerTest {
         // Happy path
         assertTrue(manager.isSafeLocation(location));
 
+        // null
+        assertFalse(manager.isSafeLocation(null));
+        
         // Try all different types of ground
         for (Material m : Material.values()) {
             when(ground.getType()).thenReturn(m);
@@ -174,4 +180,47 @@ public class IslandsManagerTest {
         when(settings.getAcidDamage()).thenReturn(0);
     }
 
+    @Test
+    public void testBigScan() throws Exception {
+        Settings settings = mock(Settings.class);
+
+        when(plugin.getSettings()).thenReturn(settings);
+
+        IslandWorld iwm = mock(IslandWorld.class);
+        when(plugin.getIslandWorldManager()).thenReturn(iwm);
+        when(iwm.getIslandWorld()).thenReturn(world);
+        
+
+        IslandsManager manager = new IslandsManager(plugin);
+                
+        Location location = mock(Location.class);
+        when(location.getWorld()).thenReturn(world);
+        when(location.getBlockX()).thenReturn(0);
+        when(location.getBlockY()).thenReturn(0);
+        when(location.getBlockZ()).thenReturn(0);
+
+        Block space1 = mock(Block.class);
+        Block ground = mock(Block.class);
+        Block space2 = mock(Block.class);
+
+        when(location.getBlock()).thenReturn(space1);
+
+        when(ground.getType()).thenReturn(Material.GRASS);
+        when(space1.getType()).thenReturn(Material.AIR);
+        when(space2.getType()).thenReturn(Material.AIR);
+        when(space1.getRelative(BlockFace.DOWN)).thenReturn(ground);
+        when(space1.getRelative(BlockFace.UP)).thenReturn(space2);
+
+        BlockState blockState = mock(BlockState.class);
+        when(ground.getState()).thenReturn(blockState);
+        
+        // Negative value = full island scan
+        // Null location should get a null response
+        assertNull(manager.bigScan(null, -1));
+        // No island here yet
+        assertNull(manager.bigScan(location, -1));
+        // Try null location, > 0 scan value
+        assertNull(manager.bigScan(null, 10));
+        
+    }
 }