Upstream/bentobox
1
0
Fork 0
mirror of https://github.com/BentoBoxWorld/BentoBox.git synced 2024-11-24 03:35:11 +01:00
Code Issues Projects Releases Wiki Activity

Removes runnable from approach.

Browse Source 
This could cause problems with threads because runnable should not be
run like this (effectively async). It should only be run inside a Bukkit
scheduled task to run on the main thread.
This commit is contained in:
tastybento 2019-02-10 20:11:50 -08:00
parent 0cf0742c07
commit 1dc56dfc4f
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/main/java/world/bentobox/bentobox/api/commands/island/IslandSethomeCommand.java
View File

@ -63,12 +63,6 @@ public class IslandSethomeCommand extends ConfirmableCommand {
}
private void setHome(User user, int number) {
// Define a runnable as we will be using it often in the code below.
Runnable setHomeRunnable = () -> {
getPlugin().getPlayers().setHomeLocation(user, user.getLocation(), number);
user.sendMessage("commands.island.sethome.home-set");
};
// Check if the player is in the Nether
if (getIWM().isNether(user.getLocation().getWorld())) {
// Check if he is (not) allowed to set his home here
@ -79,9 +73,9 @@ public class IslandSethomeCommand extends ConfirmableCommand {
// Check if a confirmation is required
if (getIWM().getWorldSettings(user.getLocation().getWorld()).isRequireConfirmationToSetHomeInNether()) {
askConfirmation(user, "commands.island.sethome.nether.confirmation", setHomeRunnable);
askConfirmation(user, "commands.island.sethome.nether.confirmation", () -> doSetHome(user, number));
} else {
setHomeRunnable.run();
doSetHome(user, number);
}
} else if (getIWM().isEnd(user.getLocation().getWorld())) { // Check if the player is in the End
// Check if he is (not) allowed to set his home here
@ -92,13 +86,19 @@ public class IslandSethomeCommand extends ConfirmableCommand {
// Check if a confirmation is required
if (getIWM().getWorldSettings(user.getLocation().getWorld()).isRequireConfirmationToSetHomeInTheEnd()) {
askConfirmation(user, user.getTranslation("commands.island.sethome.the-end.confirmation"), setHomeRunnable);
askConfirmation(user, user.getTranslation("commands.island.sethome.the-end.confirmation"), () -> doSetHome(user, number));
} else {
setHomeRunnable.run();
doSetHome(user, number);
}
} else { // The player is in the Overworld, no need to run a check
setHomeRunnable.run();
doSetHome(user, number);
}
}
private void doSetHome(User user, int number) {
// Define a runnable as we will be using it often in the code below.
getPlugin().getPlayers().setHomeLocation(user, user.getLocation(), number);
user.sendMessage("commands.island.sethome.home-set");
}
}