From 284839c6a4b63673efd789dccaa506b751629696 Mon Sep 17 00:00:00 2001
From: tastybento <tastybento@wasteofplastic.com>
Date: Tue, 3 Jul 2018 09:51:21 -0700
Subject: [PATCH] Added 2 more tests to banner parsing

---
 .../bskyblock/util/ItemParserTest.java        | 20 +++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/src/test/java/us/tastybento/bskyblock/util/ItemParserTest.java b/src/test/java/us/tastybento/bskyblock/util/ItemParserTest.java
index 4de239cdb..22d4de255 100644
--- a/src/test/java/us/tastybento/bskyblock/util/ItemParserTest.java
+++ b/src/test/java/us/tastybento/bskyblock/util/ItemParserTest.java
@@ -9,6 +9,7 @@ import java.util.Arrays;
 import java.util.List;
 
 import org.bukkit.Bukkit;
+import org.bukkit.DyeColor;
 import org.bukkit.Material;
 import org.bukkit.entity.EntityType;
 import org.bukkit.inventory.ItemFactory;
@@ -16,6 +17,7 @@ import org.bukkit.inventory.ItemStack;
 import org.bukkit.inventory.meta.BannerMeta;
 import org.bukkit.inventory.meta.PotionMeta;
 import org.bukkit.inventory.meta.SpawnEggMeta;
+import org.bukkit.material.MaterialData;
 import org.bukkit.potion.PotionData;
 import org.bukkit.potion.PotionType;
 import org.junit.Before;
@@ -183,7 +185,7 @@ public class ItemParserTest {
                         assertEquals(3, result.getAmount());
                     }
                 }
-            }            
+            }
         }
     }
 
@@ -193,22 +195,24 @@ public class ItemParserTest {
         assertEquals(Material.TIPPED_ARROW, result.getType());
     }
 
-    
+
     @Test
     public void testParseBannerSimple() {
         ItemStack result = ItemParser.parse("BANNER:2");
         assertEquals(Material.BANNER, result.getType());
         assertEquals(2, result.getAmount());
     }
-    
+
+    @SuppressWarnings("deprecation")
     @Test
     public void testParseBannerThreeArgs() {
         // Germany
         ItemStack result = ItemParser.parse("BANNER:1:RED");
         assertEquals(Material.BANNER, result.getType());
         assertEquals(1, result.getAmount());
+        assertEquals(new MaterialData(Material.BANNER, DyeColor.RED.getDyeData()), result.getData());
     }
-    
+
     @Test
     public void testParseBanner() {
         // Germany - two patterns
@@ -216,6 +220,14 @@ public class ItemParserTest {
         Mockito.verify(bannerMeta, Mockito.times(2)).addPattern(Mockito.any());
     }
 
+    @Test
+    public void testParseBannerTooManyColons() {
+        ItemStack result = ItemParser.parse("BANNER:1::::::::::::::");
+        Mockito.verify(bannerMeta, Mockito.never()).addPattern(Mockito.any());
+        assertEquals(Material.BANNER, result.getType());
+        assertEquals(1, result.getAmount());
+    }
+
     @Test
     public void testParseTwoItem() {
         ItemStack result = ItemParser.parse("STONE:5");