Disabled the whole GitHub connectors thing and hid related settings

This commit is contained in:
Florian CUNY 2019-02-22 10:03:04 +01:00
parent a916e04136
commit 29eb4b0486
2 changed files with 6 additions and 7 deletions

View File

@ -173,28 +173,28 @@ public class Settings implements DataObject {
@ConfigComment("Disabling this will result in the deactivation of the update checker and of some other") @ConfigComment("Disabling this will result in the deactivation of the update checker and of some other")
@ConfigComment("features that rely on the data downloaded from the GitHub API.") @ConfigComment("features that rely on the data downloaded from the GitHub API.")
@ConfigComment("It does not send any data.") @ConfigComment("It does not send any data.")
@ConfigEntry(path = "web.github.download-data", since = "1.3.0") @ConfigEntry(path = "web.github.download-data", since = "1.3.0", hidden = true)
private boolean githubDownloadData = true; private boolean githubDownloadData = false; // Set as false for now so it disables the whole GitHub thing.
@ConfigComment("Time in minutes between each connection to the GitHub API.") @ConfigComment("Time in minutes between each connection to the GitHub API.")
@ConfigComment("This allows for up-to-the-minute information gathering.") @ConfigComment("This allows for up-to-the-minute information gathering.")
@ConfigComment("However, as the GitHub API data does not get updated instantly, it is recommended to keep") @ConfigComment("However, as the GitHub API data does not get updated instantly, it is recommended to keep")
@ConfigComment("this value greater than 15 minutes.") @ConfigComment("this value greater than 15 minutes.")
@ConfigComment("Setting this to 0 will make BentoBox download data only at startup.") @ConfigComment("Setting this to 0 will make BentoBox download data only at startup.")
@ConfigEntry(path = "web.github.connection-interval", since = "1.3.0") @ConfigEntry(path = "web.github.connection-interval", since = "1.3.0", hidden = true)
private int githubConnectionInterval = 60; private int githubConnectionInterval = 60;
@ConfigComment("Toggle whether the downloaded data should be flushed to files.") @ConfigComment("Toggle whether the downloaded data should be flushed to files.")
@ConfigComment("It helps to prevent previously downloaded data being lost due to a more recent connection that failed") @ConfigComment("It helps to prevent previously downloaded data being lost due to a more recent connection that failed")
@ConfigComment("to connect to the GitHub API.") @ConfigComment("to connect to the GitHub API.")
@ConfigComment("Such files are stored in JSON format and do not usually take up more than a few kilobytes of disk space each.") @ConfigComment("Such files are stored in JSON format and do not usually take up more than a few kilobytes of disk space each.")
@ConfigEntry(path = "web.github.flush-data-to-files", since = "1.3.0") @ConfigEntry(path = "web.github.flush-data-to-files", since = "1.3.0", hidden = true)
private boolean githubFlushDataToFiles = true; private boolean githubFlushDataToFiles = true;
@ConfigEntry(path = "web.updater.check-updates.bentobox", since = "1.3.0") @ConfigEntry(path = "web.updater.check-updates.bentobox", since = "1.3.0", hidden = true)
private boolean checkBentoBoxUpdates = true; private boolean checkBentoBoxUpdates = true;
@ConfigEntry(path = "web.updater.check-updates.addons", since = "1.3.0") @ConfigEntry(path = "web.updater.check-updates.addons", since = "1.3.0", hidden = true)
private boolean checkAddonsUpdates = true; private boolean checkAddonsUpdates = true;
//---------------------------------------------------------------------------------------/ //---------------------------------------------------------------------------------------/

View File

@ -780,7 +780,6 @@ public class PVPListenerTest {
e = new PotionSplashEvent(tp, map); e = new PotionSplashEvent(tp, map);
new PVPListener().onSplashPotionSplash(e); new PVPListener().onSplashPotionSplash(e);
assertFalse(e.isCancelled()); assertFalse(e.isCancelled());
} }
/** /**