From 3331ffac4eb72ecc0c2916541f9384a767022390 Mon Sep 17 00:00:00 2001 From: tastybento Date: Sat, 4 Feb 2023 18:49:13 -0800 Subject: [PATCH] Refactor to reduce complexity. --- src/main/java/world/bentobox/bentobox/api/user/User.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/main/java/world/bentobox/bentobox/api/user/User.java b/src/main/java/world/bentobox/bentobox/api/user/User.java index d29420f54..37355443d 100644 --- a/src/main/java/world/bentobox/bentobox/api/user/User.java +++ b/src/main/java/world/bentobox/bentobox/api/user/User.java @@ -340,8 +340,6 @@ public class User implements MetaDataAble { // If requester is console, then return the default value if (!isPlayer()) return defaultValue; - int value = 0; - // If there is a dot at the end of the permissionPrefix, remove it if (permissionPrefix.endsWith(".")) { permissionPrefix = permissionPrefix.substring(0, permissionPrefix.length()-1); @@ -357,6 +355,12 @@ public class User implements MetaDataAble { if (permissions.isEmpty()) return defaultValue; + return iteratePerms(permissions, permPrefix, defaultValue); + + } + + private int iteratePerms(List permissions, String permPrefix, int defaultValue) { + int value = 0; for (String permission : permissions) { if (permission.contains(permPrefix + "*")) { // 'Star' permission