Upstream/bentobox
1
0
Fork 0
mirror of https://github.com/BentoBoxWorld/BentoBox.git synced 2024-11-24 19:55:17 +01:00
Code Issues Projects Releases Wiki Activity

Fixed JSONDatabaseHandler to avoid memory leak

Browse Source 
Thanks Sonarcloud ^^
This commit is contained in:
Florian CUNY 2018-10-29 21:39:48 +01:00
parent 2dd8fcb13c
commit 493a525775
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/world/bentobox/bentobox/database/json/JSONDatabaseHandler.java
View File

@ -99,15 +99,13 @@ public class JSONDatabaseHandler<T> extends AbstractJSONDatabaseHandler<T> {
String toStore = getGson().toJson(instance); String toStore = getGson().toJson(instance);
try { try (FileWriter fileWriter = new FileWriter(file)) {
File tmpFile = new File(tableFolder, fileName + ".bak"); File tmpFile = new File(tableFolder, fileName + ".bak");
if (file.exists()) { if (file.exists()) {
// Make a backup of file // Make a backup of file
Files.copy(file.toPath(), tmpFile.toPath(), StandardCopyOption.REPLACE_EXISTING); Files.copy(file.toPath(), tmpFile.toPath(), StandardCopyOption.REPLACE_EXISTING);
} }
FileWriter fileWriter = new FileWriter(file);
fileWriter.write(toStore); fileWriter.write(toStore);
fileWriter.close();
Files.deleteIfExists(tmpFile.toPath()); Files.deleteIfExists(tmpFile.toPath());
} catch (IOException e) { } catch (IOException e) {
plugin.logError("Could not save json file: " + path + " " + fileName + " " + e.getMessage()); plugin.logError("Could not save json file: " + path + " " + fileName + " " + e.getMessage());