Added WaterIsNotSafe setting to WorldSettings

This flag is used to indicate whether being waste-deep in water is a
safe home location or not. On SkyBlock is it fine, on AcidIsland it is
not. So that's why this definition is required.

Removed unused @deprecation header. I assume switching to Spigot API
made these superfluous.

src/main/java/us/tastybento/bskyblock/Settings.java

@@ -1584,5 +1584,10 @@ public class Settings implements DataObject, WorldSettings {
         this.difficulty = difficulty;
     }
 
+    @Override
+    public boolean isWaterNotSafe() {
+        return false;
+    }
+
 
 }

src/main/java/us/tastybento/bskyblock/api/configuration/WorldSettings.java

@@ -225,4 +225,9 @@ public interface WorldSettings {
      * @return true if the default world generator should not operate in this world
      */
     boolean isUseOwnGenerator();
+
+    /**
+     * @return true if water is not safe in this world, e.g, should not be a home location
+     */
+    boolean isWaterNotSafe();
 }

src/main/java/us/tastybento/bskyblock/managers/IslandWorldManager.java

@@ -716,4 +716,13 @@ public class IslandWorldManager {
     public List<String> getVisitorBannedCommands(World world) {
         return worldSettings.get(Util.getWorld(world)).getVisitorBannedCommands();
     }
+
+    /**
+     * Check if water is not safe, e.g., it is acid, in the world
+     * @param world - world
+     * @return true if water is not safe, e.g.for home locations
+     */
+    public boolean isWaterNotSafe(World world) {
+        return worldSettings.get(Util.getWorld(world)).isWaterNotSafe();
+    }
 }

src/main/java/us/tastybento/bskyblock/managers/IslandsManager.java

@@ -69,6 +69,10 @@ public class IslandsManager {
         if (space1.isLiquid() && space2.isLiquid()) {
             return false;
         }
+        // Check if water is safe in this world
+        if (space1.isLiquid() && plugin.getIWM().isWaterNotSafe(l.getWorld())) {
+            return false;
+        }
 
         // Portals are not "safe"
         if (space1.getType() == Material.PORTAL || ground.getType() == Material.PORTAL || space2.getType() == Material.PORTAL
@@ -515,7 +519,6 @@ public class IslandsManager {
      * @param number - a number - home location to do to
      * @param newIsland - true if this is a new island teleport
      */
-    @SuppressWarnings("deprecation")
     public void homeTeleport(World world, Player player, int number, boolean newIsland) {
         User user = User.getInstance(player);
         Location home = getSafeHomeLocation(world, user, number);

src/test/java/us/tastybento/bskyblock/api/user/UserTest.java

@@ -80,9 +80,9 @@ public class UserTest {
 
     @Test
     public void testGetInstanceCommandSender() {
-       User user = User.getInstance(sender); 
+        User user = User.getInstance(sender);
-       assertNotNull(user);
+        assertNotNull(user);
-       assertEquals(sender,user.getSender());
+        assertEquals(sender,user.getSender());
     }
 
     @Test
@@ -436,7 +436,6 @@ public class UserTest {
         assertEquals(locale, console.getLocale());
     }
 
-    @SuppressWarnings("deprecation")
     @Test
     public void testUpdateInventory() {
         Player pl = mock(Player.class);