From c6c7e0b4eebbe724fe1f1cb3f281b26dd32b25b3 Mon Sep 17 00:00:00 2001 From: Florian CUNY Date: Mon, 26 Feb 2018 10:07:25 +0100 Subject: [PATCH] Removed FlagsManager#getFlagByIcon() as it is useless --- .../us/tastybento/bskyblock/managers/FlagsManager.java | 10 ---------- src/test/java/bskyblock/TestBSkyBlock.java | 1 - .../bskyblock/managers/FlagsManagerTest.java | 10 ---------- 3 files changed, 21 deletions(-) diff --git a/src/main/java/us/tastybento/bskyblock/managers/FlagsManager.java b/src/main/java/us/tastybento/bskyblock/managers/FlagsManager.java index 67fcc7eff..11138b8c5 100644 --- a/src/main/java/us/tastybento/bskyblock/managers/FlagsManager.java +++ b/src/main/java/us/tastybento/bskyblock/managers/FlagsManager.java @@ -70,14 +70,4 @@ public class FlagsManager { public Flag getFlagByID(String id) { return flags.stream().filter(flag -> flag.getID().equals(id)).findFirst().orElse(null); } - - /** - * Get flag by icon - * @param icon material - * @return flag or null if it does not exist - */ - public Flag getFlagByIcon(Material icon) { - return flags.stream().filter(flag -> flag.getIcon().equals(icon)).findFirst().orElse(null); - } - } diff --git a/src/test/java/bskyblock/TestBSkyBlock.java b/src/test/java/bskyblock/TestBSkyBlock.java index c9abf2531..5739d38ed 100644 --- a/src/test/java/bskyblock/TestBSkyBlock.java +++ b/src/test/java/bskyblock/TestBSkyBlock.java @@ -520,7 +520,6 @@ public class TestBSkyBlock { // Add it to the Flag Manager flagsManager.registerFlag(customFlag); assertEquals(customFlag, flagsManager.getFlagByID("CUSTOM_FLAG")); - assertEquals(customFlag, flagsManager.getFlagByIcon(customFlag.getIcon())); } /** diff --git a/src/test/java/us/tastybento/bskyblock/managers/FlagsManagerTest.java b/src/test/java/us/tastybento/bskyblock/managers/FlagsManagerTest.java index 0bd7ab986..303d58f1a 100644 --- a/src/test/java/us/tastybento/bskyblock/managers/FlagsManagerTest.java +++ b/src/test/java/us/tastybento/bskyblock/managers/FlagsManagerTest.java @@ -104,14 +104,4 @@ public class FlagsManagerTest { Flags.values().stream().sorted(Comparator.reverseOrder()).forEach(flag -> assertEquals(flag, fm.getFlagByID(flag.getID()))); } - - @Test - public void testGetFlagByIcon() { - BSkyBlock plugin = mock(BSkyBlock.class); - FlagsManager fm = new FlagsManager(plugin); - // Test in forward and reverse order so that any duplicates are caught - Flags.values().stream().sorted().forEach(flag -> assertEquals(flag, fm.getFlagByIcon(flag.getIcon()))); - Flags.values().stream().sorted(Comparator.reverseOrder()).forEach(flag -> assertEquals(flag, fm.getFlagByIcon(flag.getIcon()))); - } - }