From cf0b2ccdd561bc06731a5a3b01839f1f07dbe37a Mon Sep 17 00:00:00 2001 From: tastybento Date: Fri, 17 May 2019 21:02:49 -0700 Subject: [PATCH] Close file opened for reading blueprint before delete. https://github.com/BentoBoxWorld/BentoBox/issues/687 --- .../managers/BlueprintClipboardManager.java | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/main/java/world/bentobox/bentobox/managers/BlueprintClipboardManager.java b/src/main/java/world/bentobox/bentobox/managers/BlueprintClipboardManager.java index 0d121f6db..650bce0a5 100644 --- a/src/main/java/world/bentobox/bentobox/managers/BlueprintClipboardManager.java +++ b/src/main/java/world/bentobox/bentobox/managers/BlueprintClipboardManager.java @@ -98,7 +98,10 @@ public class BlueprintClipboardManager { plugin.logError(LOAD_ERROR + file.getName()); throw new IOException(LOAD_ERROR + file.getName() + " temp file"); } - Blueprint bp = gson.fromJson(new FileReader(file), Blueprint.class); + Blueprint bp; + try (FileReader fr = new FileReader(file)) { + bp = gson.fromJson(fr, Blueprint.class); + } Files.delete(file.toPath()); return bp; } @@ -204,11 +207,11 @@ public class BlueprintClipboardManager { while((length = inputStream.read(buffer)) >= 0) { zipOutputStream.write(buffer, 0, length); } - try { - Files.delete(targetFile.toPath()); - } catch (Exception e) { - plugin.logError(e.getMessage()); - } + } + try { + Files.delete(targetFile.toPath()); + } catch (Exception e) { + plugin.logError(e.getMessage()); } } }