Upstream/bentobox
1
0
Fork 0
mirror of https://github.com/BentoBoxWorld/BentoBox.git synced 2024-11-22 18:55:17 +01:00
Code Issues Projects Releases Wiki Activity

Catch error around deserialization and provide better logging.

Browse Source 
This will help addon developers know where they went wrong. Related to:
https://github.com/BentoBoxWorld/TwerkingForTrees/issues/6
This commit is contained in:
tastybento 2019-12-22 09:40:42 -08:00
parent fc23da4343
commit dfd8dffcf2
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/main/java/world/bentobox/bentobox/database/yaml/YamlDatabaseHandler.java
View File

@ -154,7 +154,7 @@ public class YamlDatabaseHandler<T> extends AbstractDatabaseHandler<T> {
}
// Get the getter and setters for this field using the JavaBeans system
//noinspection RedundantCast
PropertyDescriptor propertyDescriptor = new PropertyDescriptor((String)field.getName(), dataObject);
PropertyDescriptor propertyDescriptor = new PropertyDescriptor(field.getName(), dataObject);
// Get the write method
Method method = propertyDescriptor.getWriteMethod();
/*
@ -209,7 +209,13 @@ public class YamlDatabaseHandler<T> extends AbstractDatabaseHandler<T> {
Object setTo = deserialize(value,propertyDescriptor.getPropertyType());
if (!(Enum.class.isAssignableFrom(propertyDescriptor.getPropertyType()) && setTo == null)) {
// Do not invoke null on Enums
method.invoke(instance, setTo);
try {
method.invoke(instance, setTo);
} catch (Exception e) {
plugin.logError("Could not deserialize. Attempt by " + instance.getClass().getCanonicalName() + " " + method.getName() + " to set to " + setTo);
plugin.logError("Error message is: " + e.getMessage());
plugin.logStacktrace(e);
}
} else {
plugin.logError("Default setting value will be used: " + propertyDescriptor.getReadMethod().invoke(instance));
plugin.logError(method.getName());
@ -346,7 +352,7 @@ public class YamlDatabaseHandler<T> extends AbstractDatabaseHandler<T> {
}
// Get the property descriptor for this field
//noinspection RedundantCast
PropertyDescriptor propertyDescriptor = new PropertyDescriptor((String)field.getName(), dataObject);
PropertyDescriptor propertyDescriptor = new PropertyDescriptor(field.getName(), dataObject);
// Get the read method
Method method = propertyDescriptor.getReadMethod();
// Invoke the read method to get the value. We have no idea what type of value it is.