Commit Graph

2225 Commits

Author SHA1 Message Date
tastybento
a2631b88a6 Removed static and server calling from test class. 2019-03-11 19:00:05 -07:00
Florian CUNY
2935f41173 Made Island#getCenter() return a clone of the Location
As suggested in https://github.com/BentoBoxWorld/BentoBox/issues/591#issuecomment-471314358
2019-03-11 13:41:01 +01:00
tastybento
75bbc13cf5 Improved islands async deletion from database (#605)
Addresses https://github.com/BentoBoxWorld/BentoBox/issues/591
2019-03-11 08:41:41 +01:00
Florian CUNY
55b813b746
Updated a few maven plugins 2019-03-10 09:15:57 +01:00
tastybento
9e6b0d873c Revert "Fixed version in POM not being "-SNAPSHOT""
This reverts commit 13eddbb3b6.
2019-03-09 22:14:01 -08:00
tastybento
cfa6861e58 Added IslandCreateCommand test and use of canExecute API. 2019-03-09 22:09:54 -08:00
tastybento
a6e72ec018 Small change to CustomIslandMultiHomeHelp test. 2019-03-09 22:09:11 -08:00
tastybento
e0a8831ae0 Added test class for CustomIslandMultiHomeHelp class 2019-03-09 21:22:00 -08:00
tastybento
2cdbc25f6a Rewrote Flag test class for better coverage 2019-03-09 20:55:54 -08:00
tastybento
127bc1e338 Removed extraneous BeforeClass from Flag test class 2019-03-09 19:33:18 -08:00
tastybento
ac079a6686 Improved PanelItemBuilder test class 2019-03-09 19:31:18 -08:00
tastybento
91dec86b5a Added tests to SafeSpotTeleport test class 2019-03-09 19:31:06 -08:00
tastybento
78d45364aa Improved FireListener test class 2019-03-09 19:30:49 -08:00
tastybento
58a975b5a5 Cleaned up MobSpawnListener test class. 2019-03-09 18:55:29 -08:00
tastybento
a1e6f37963 Fixes HurtingListener test class 2019-03-09 18:50:34 -08:00
tastybento
9f997f4548 Fixes MobSpawnListener test class 2019-03-09 18:50:19 -08:00
tastybento
ee5a2c920b Added Panel Test class.
Fixed bugs with head requesting.
2019-03-09 18:43:27 -08:00
tastybento
8f24e59a21 Fixes IslandsManager test cases and pufferfish removal
The clear area method should not remove pufferfish as per
https://github.com/BentoBoxWorld/BentoBox/pull/595
2019-03-09 16:54:54 -08:00
tastybento
16388e4721 Added Notifier test class 2019-03-09 16:42:46 -08:00
Florian CUNY
13eddbb3b6
Fixed version in POM not being "-SNAPSHOT" 2019-03-09 22:20:37 +01:00
Florian CUNY
1953d966dc Fixed code smells in YamlDatabaseHandler 2019-03-09 21:55:13 +01:00
BONNe
7a0939e171 Improved handling of Phantoms, Pufferfishes and a few other mobs (#595) 2019-03-09 21:21:46 +01:00
tastybento
5d2e6e6906 Removes build version suffix to SNAPSHOT releases.
See https://github.com/BentoBoxWorld/BentoBox/issues/603
2019-03-08 23:38:04 -08:00
tastybento
9ba34d1e92 Skip synthetic fields from Jacoco or compiler
When using introspection, synthetic fields should be skipped. These
fields can be added by Jacoco or even the compiler so will cause
problems during unit testing.

Refactored YamlDatabaseHandler to be easier to understand.
2019-03-08 22:29:28 -08:00
BONNe
d11a27dc6d Fixed MILKING flag not protecting milking Mooshrooms (#602)
Add extra PlayerInteractEntityEvent handling that prevents from using bowl on mooshrooms without MILKING protection flag.
2019-03-08 20:40:42 +01:00
BONNe
07b4e2d30c Fixed ArrayOutOfBoundsException in admin delete command (#600)
When admins tried to delete island, they got an ArrayOutOfBounds exception.
This will fix it.
2019-03-08 20:38:59 +01:00
BONNe
e3fbeb1560 Added profiles to POM (#596)
Add 3 new profiles:
- local profile is activated by default and it will add -SNAPSHOT at the end of version.
- develop profile is activated when exist BUILD_NUMBER environment variable and it will add -SNAPSHOT #BUILD+_NUMBER at the end of version
- master profile is activated when exists GIT_BRANCH environment variable with value origin/master and it will not add anything to version.

Also, move most of dependencies versions to properties section.

With these changes, it will be easier to process next release. Only change `build.version` in properties section. 

If you run maven package or install from IDE or console, it will add -SNAPSHOT at the end (unless you have local Jenkins server). [`bentobox-1.4.0-SNAPSHOT.jar`]
In Jenkins server builds from develop branch will look like `bentobox-1.4.0-SNAPSHOT #21.jar`.
In Jenkins server builds from master branch will look like `bentobox-1.4.0.jar`.
2019-03-08 20:36:53 +01:00
tastybento
d4d1b77c24 Added test class for island team invite accept command.
Reduced complexity of command.
2019-03-07 22:57:49 -08:00
tastybento
a397945248 Reduce complexity code smell. 2019-03-07 22:05:24 -08:00
tastybento
7544660643 Reduce complexity code smell. 2019-03-07 21:59:37 -08:00
tastybento
d3be21b3ae Fixed minor code smells for db handlers. 2019-03-07 18:44:15 -08:00
tastybento
7471dd6f2e Enable Ops to adjust any island settings including spawn island
https://github.com/BentoBoxWorld/BentoBox/issues/599
2019-03-07 10:02:40 -08:00
tastybento
9318973459 Does not remove arrows or tridents if PVP is disabled.
https://github.com/BentoBoxWorld/BentoBox/issues/597
2019-03-06 22:05:26 -08:00
tastybento
9742c1f0e3 Fixes NPE when going through a non-BentoBox world portal.
https://github.com/BentoBoxWorld/BentoBox/issues/583

Caused by a failure to check that world was in the known BentoBox worlds
before calling the IWM method.
2019-03-06 21:38:15 -08:00
tastybento
f0b57a3a64 Fixes test for offline redstone listener 2019-03-06 21:28:20 -08:00
Florian CUNY
2bb4301af7 Removed unneeded dangling javadoc in newly created test classes 2019-03-04 08:38:29 +01:00
Florian CUNY
ac1128506e Added Flags#OFFLINE_GROWTH
#580
2019-03-04 08:29:43 +01:00
Florian CUNY
2ae36e737f Improved OFFLINE_REDSTONE handling (and added javadoc) 2019-03-04 08:22:18 +01:00
tastybento
c004c8e4a4 Added InventoryListener test class. 2019-03-03 22:26:52 -08:00
tastybento
326d6d033c Added BucketListener test class. 2019-03-03 21:53:43 -08:00
tastybento
e9dc678a08 Added EggListener test class. 2019-03-03 21:28:43 -08:00
tastybento
9659610b11 Added BreakBlocksListener test class.
Also added a way to trap null location checks with checkIsland in
FlagListener.
2019-03-03 21:18:38 -08:00
tastybento
ff6b754333 Adds ender crystal protection.
https://github.com/BentoBoxWorld/BentoBox/issues/589
2019-03-03 20:00:11 -08:00
tastybento
15f97927de Fixes range resetting if player does not have a range permission.
If a player's island range is set using the range set admin command, the
range was being reset when the player logged in if they had no range
permission.

https://github.com/BentoBoxWorld/BentoBox/issues/484
2019-03-03 19:23:15 -08:00
Florian CUNY
f1b24a45d3 Fixed IslandEnterEvent and IslandExitEvent not being called if Flags#ENTER_EXIT_MESSAGES was set to false 2019-03-03 17:39:58 +01:00
Florian CUNY
cdaec6c517 Removed unused import in PlaceholderAPIHook 2019-03-03 17:39:22 +01:00
Florian CUNY
c5dc7fcfad Added methods to unregister placeholders in PlaceholdersManager
#592
2019-03-03 16:29:46 +01:00
Florian CUNY
4f7de44b67 Fixed tests 2019-03-03 15:33:54 +01:00
YellowZaki
11c0331abd Players with "admin.noban" permission can't be banned (#590)
From this https://github.com/BentoBoxWorld/BSkyBlock/blob/master/src/main/resources/addon.yml#L132
2019-03-03 09:14:53 +01:00
Ranald
7c01199763 Cleaned code in IslandRespawnListener (#587)
1. Made respawn map private and final.
2. Changed value type from World to UUID. (weaker reference)
3. Removed ignoreCancelled from both listener annotations. (neither events can even be cancelled)
4. Changed program flow from "if-so-continue" to "if-not-return". (easier to follow and read)
5. Added basic comments on what each check does.
6. Removed redundant flag check. (wouldn't be in the map if it wasn't true)
7. Removed redundant Map contains, get, and then remove calls. (A simple call to remove and a null check are more efficient)
2019-03-02 22:47:52 +01:00