The SimpleWorldRegenerator generated world new chunks that were not generated before.
It is not necessary, as regeneration should happen only on used chunks.
* Implements NMS for pasting and supports older versions of server
* Remove trial code that shouldn't have been committed.
* Remove trial code that shouldn't have been committed.
* Remove 1.19.3 support.
* Use 1.19.4 in POM
This solves the issue in customizable GUI's where variables are defined directly into the panel button name and description instead of providing the link to the locale.
Not all users want to specify all text into a locale, and they would not get parsed variables just because of that.
This change fixes it and it does not give any bad situations even if the reference is just missing text in the locale, as there will be nothing for parsing.
* Remove 1.18.2 from supported version list.
1.18.2 support was removed with changes in commit 056cff4b6f
Also, mark 1.19, 1.19.1 and 1.19.2 as incompatible. It happens because of GSon library changes that prevents bentobox compiled with Spigot 1.19.3 to run on older versions.
* Fixes GSON crashes introduced by migrating to 1.19.3 api.
Mostly replacing instanceof check and cast with e.g. 'instanceof Player
player'
Replaced some "switch" statements by "if" statements to increase
readability.
Used the primitive boolean check to avoid potential NPEs.
Reordered field modifiers to comply with the Java Language
Specification. Mainly @NonNull position.
* Code clean up from Sonar Cloud analysis
* Fix tests
* Remove code smell
* Rename "island" which hides the field declared at line 25.
* Removed code smells.
* Rename variable record to rec
Renamed "record" variable to not match a restricted identifier.
Restricted Identifiers should not be used as identifiers. "record" is
using in Java 16.
* Added private constructor to prevent instantiation of static class
Changed variable name to rec instead of restricted "record".
* Remove Blueprint code smells.
* Use a record for database settings constructor
Code smell: Methods should not have too many parameters. I'm not sure
what methods are using this class though.
* Update MyWorlds version
The POM for MyWorlds is invalid and causes a warning, but this still
persists with this version.
* Extracted nested try block into a separate method.
Makes it clear when reading the code what might be caught
* Extracted nested try block into a separate method.
* Fixed JavaDoc /** instead of just /*
* Extracted nested try block into a separate method.
* Refactored to not assign loop counter from within the loop body.
* Better delete option. With results.
That said, this is legacy code to handle an issue that occurred a long
time ago and this whole set of code can probably be removed.
* Catch Exceptions not Throwable
* Log error with BentoBox logError
* Use computeIfAbsent
Using these instead leads to cleaner and more readable code.
* User can no longer be null
* Added the missing @Deprecated annotation and @since ref
* Added @since reference
* Merge if statements
* Use BentoBox error logging.
* Added JavaDoc @since
* Remove deprecated class and move used class
* Remove deprecated WoodType and use Type.
* Remove unused import
* Extracted nested try block into a separate method.
* Comment empty default statement
* Clean up logic; avoid switch
* Use Java instead of Guava
* private constructor to hide the implicit public one.
* Private constructor to hide the implicit public one.
Merged if statement.
* Add comment
* if merge
* Make variable constant
* Remove unused imports
* Remove deprecated and unused method
* Remove unused import
* Typo
* Remove instanceof and cast
* Remove superfluous null check
* Put constant at bottom of file because @BONNe likes it there.
* Simplify particle validation code
* Fixes#2046. Handles null players for placeholders.
* Remove unused import
* Fixes#2049 for adjacent island spaces
This also deletes blocks in the event rather than setting them to AIR as
was done previously.
Addresses #2058
We already have a option to protect against hostile mobs when logging in
or teleporting, but not respawn. This adds protection to that. Admin can
turn off the option if they want it more hard core.
In theory, this should not be required, but it seems that a player's
world might be null in some edge cases. Alternatively, the Util.getWorld
function can return a null if the player was in a nether or end but that
does not have a corresponding overworld.
Addresses #2057
Superflat was not working properly. It was always clearing just 1 (first) chunk because it referenced the chunk from the first event that created the clearing task.
The issue should be fixed.
In 1.19 worlds it was fixed that super-flat worlds are generated at min-height, instead at 0.
This change keeps the previous super-flat chunk generation until 1.18 is dropped.
The end portals and gateways teleports players to a different dimension upon player touches it. So teleportation should consider these positions as unsafe, otherwise player will be teleported to the different dimension instantly.
Fixes#2040
This change switches from plain JDBC driver implementation to a HikariCP Pool implementation.
Pool Implementation is complete for PostgreSQL and SQLite, while MariaDB and MySQL implementation still uses JDBC drivers, however with HikariCP pools.
Also, I added extra properties for SQL databases, where users could specify their own datasource properties.
Teleportation via portals for entities was in a mixed state. It was not fully implemented and not fully prevented. Especially when portal linking was enabled.
Now I implemented world settings flag: ENTITY_PORTAL_TELEPORT.
Enabling this flag will allow entities to use portals to switch dimensions.
Fixes#2023 and #966
When players will exit the end-gate, they will be teleported to proper island, instead of world spawn point.
The only way how players can be teleported to the spawn is if they do not have islands.
I reworked the classes and some teleportation operations. Now teleportation should find the closest available spot, instead of always being the highest block at original Y location. Part of #1994.
Also, I fixed an issue that portals stopped working if some conflicting options were enabled. Now portals will not work only if nether is disabled in config.
* Fixes issue when blueprint clipboard was stuck after saving.
The issue was that Map#putIfAbsent still creates a new task, even if object is already in map. The usage requires to use Map#computeIfAbsent.
* Rework blueprint and blueprint bundle names.
There was an issue with using non-english characters in blueprint names. It was not possible, as all chars for names were converted to lower cased english letters. It included display names.
I reworked it a bit and now it should be possible to set non-english names for bundles and blueprints.
Fixes#1954
* Adds ProtectionBoundingBox for environment
Since minecraft introduced different island heights for different dimensions, protection bounding box were returned wrong area for nether and end dimensions.
This change adds a new method that allows to get proper protection bounding box for requested dimension.
Due to the fact, that nether and end islands can be disabled, then this method may return null.
Fixes#2014
* Adds BoundingBox for environment
Since minecraft introduced different island heights for different dimensions, bounding box were returned wrong area for nether and end dimensions.
This change adds a new method that allows to get proper bounding box for requested dimension.
Due to the fact, that nether and end islands can be disabled, then this method may return null.
Part of #2014
* Fixes Island#onIsland check for non-island worlds
Island#onIsland method was missing checks if island mode is enabled for requested dimension. It returned false positive situations in cases when island generation were disabled in nether or the end worlds.
* Fixes Island#inIslandSpace check for non-island worlds
Island#inIslandSpace method was missing checks if island mode is enabled for requested dimension. It returned false positive situations in cases when island generation were disabled in nether or the end worlds.
* Adds some helper methods in Island object.
- Island#getNetherWorld - returns the nether world or null
- Island#getEndWorld - returns the end world or null
- Island#getWorld(Environment) - returns world of requested environment or null
- Island#isNetherIslandEnabled - returns if nether is generated and nether islands are enabled.
- Island#isEndIslandEnabled - returns if end is generated and end islands are enabled.
The commit was wrong. Protection range should not be decreased, as that would mean that max X and Z blocks are not included in island protection bounding box.
This change is the same as 3c65194dfb but was missed when it was fixed.
Relate to #473
* Check if unique name contains chars not supported in regex expression
Cannot start, contain, or end with special char, cannot contain any numbers.
Can only contain - for word separation
* Negation fix
* Implements option to define non-existing flags in WorldSettings.
This change adds 2 new methods in WorldSettings:
* WorldSettings#getDefaultIslandFlagNames
* WorldSettings#getDefaultIslandSettingNames
These methods replace getDefaultIslandFlags and getDefaultIslandSettings methods.
Default implementation just reads values from replaced methods.
Fixes#1830
* Implement conversion from flag id to actual flag object.
Replaces flag assignment to new island based on flag id's.
Fixes#1830
* Switch from Flag object to String object in Island class.
This switch allows to keep flags that are not present in current BentoBox installation. Otherwise, unknown flags may cause an issues.
Fixes#1830
* Implement FlagBooleanSerializer.
This serializer converts input map of String, Boolean to map of String, Integer.
This map is used to read island setting flags, and integer value is not classic boolean values. (0 for true and -1 for false).
Fixes#1830
* Move to new EngineHub maven repository
* Remove unused WorldEdit dependency
* Use Java 17 in GitHub Actions
* Also change maven-compiler-plugin and maven-javadoc-plugin versions to 17
* Implements new VISITOR_TRIGGER_RAID flag.
This world settings flag allows toggling if visitors can or cannot start a raid on an island they are visiting.
Relates to #1976
* Fixes abuse of Raid Mechanism and Mob Natural Spawn Rules.
Fixes to #1976
* Simplify raid abuse detection.
Spigot in 1.18 introduce new way how block particles should be displayed. However, BentoBox never fully implemented it.
To avoid such issues in-future, I added checks for each particle type that requires extra data object.
Fixes#1989
* Update to Spigot and Paper API 1.19 and Java 17
* Set minimal version to 1.18.
* Add breeding protection for Axolotl and Goats (1.18)
Add breeding protection for Frog and Allay (1.19)
* Clean up switch statement in BlockInteractionListener
* Add chest boat support to BreakBlocksListener.
Part of #1987
* Add powdered snow pickup with bucket protection.
* Add glow ink sac protection on signs.
Switch to SheepDyeWoolEvent as it now contains player variable.
* Clean up Hurting Listener
* Mark 1.16.5, 1.17 and 1.17.1 as incompatible.
Mark 1.18, 1.18.1 and 1.18.2 as supported.
Add 1.19 as compatible.
Part of 1987
* Add ChestBoat inventory protection.
Part of #1987
* Clean up LockAndBanListener
* Add MANGROVE_PRESSURE_PLATE protection.
Part of #1987
* Add Glow Item Frame protection to player interact event.
* Clean up MobSpawnListener
* Clean up ChestDamageListener
* Change from custom method to Tag.PRESSURE_PLATES to detect pressure plates.
Part of #1987
* Implement proper chest boat protection.
Part of #1987
* Move to 1.19 R1 world regenerator.
Part of #1987
* Add allay to the animal entity list.
Part of #1987
* Add axolotl and other fish scooping protection.
Part of #1987
* Fixes Bucket and Glass Bottle filling.
Buckets and bottles were not working since cauldron splitting by type. This change fixes that.
It also protects from filling bottles with water from water sources or waterlogged blocks.
* Remove 1.17.1 compatibility check for biome adapter.
Add cheezee 1.19.1 compatibility version.
* Fixes chest boat interactions.
Part of #1987
* Implement Allay protection.
New flag ALLAY is required to interact with allays.
Part of #1987
* Prevent visitors for being targeted by entities if ENTITY_ATTACK is enabled.
* Implement Sculk Sensor and Shrieker activation protection setting.
Part of #1987
* Add music discs to the LangUtilsHook
Part of #1987
* Fixes failing unit-tests.
* more abstract on Paster
* comment and stuff
* How about Impl
* ok, PasteHandler
* PasteUtil
* don't check other BlockState if there is one matched
* world as an argument
* forgot the impl
* createBlockData from BlueprintBlock
* fix remaining conflicts
Co-authored-by: tastybento <tastybento@users.noreply.github.com>
* more abstract on delete chunks
* update NMS to 1.18.2
* at most abstract, requires only the island and the world
* it's weird that we can't use whenComplete
* rename to WorldRegenerator
* Version 1.20.1
* Added name of the addon causing the issue.
https://github.com/BentoBoxWorld/BentoBox/issues/1944
* Use world min-height for island bounding box.
* Fixes a bug when fallback could not use reusable
There was an issue in PanelItemTemplate that prevented fallback buttons to be "reusable" things.
The issue was that reusable items were not passed to the panel item reader.
* Adjusted test to try to avoid errors
* Fix for random test failures.
* Added 1.18.2 support
* Address unnecessary PVP reports on each teleport (#1948)
If a player is teleporting on the same island in the same dimension, it keeps spamming that PVP is enabled in dimension.
It should be enough with sending messages when the player teleports to the island.
Fixes#1885
* Fixes bug with Safe Spot Teleport (#1951)
There was a bug that prevented finding a safe spot if all valid blocks were in height with the `startY` location.
Reported via discord.
* Fix Exception error reported by IDE
I am not sure why Eclipse is saying this is an error.
* Fix for kicking offline players
https://github.com/BentoBoxWorld/BentoBox/issues/1950
* Add an option in SafeSpotTeleport to cancel if fail (#1952)
There was no option to cancel teleportation if SafeSpotTeleport could not find a valid spot. This option could be used to avoid creating "backup" blocks in situations when teleportation is avoidable, f.e. visiting an island.
* Replace peplaceAll with replace
It does the same thing if the first argument is not a regex.
* Use constants for common strings
* Use constants for common strings
* Go back to replaceAll
This is required.
* Clearer paster (#1953)
* WIP - make easier to understand.
* Small refactor of paster to make it easier to understand
* Fix tabs to spaces. Sorry - new editor!
* Fix tabs to spaces
* Fix tab to spaces
* Improve team kick command (#1957)
The kick command has an unnecessary owner check. As command should be configurable by island owners, then limiting it to an owner is wrong.
Add a code that allows kicking only lower-ranked players.
Add message that shows who kicked from the island.
Add message that shows that rank does not allow to kick.
* Solve crashes with Addon#allLoaded call (#1959)
If some addon has code in Addon#allLoaded that crashes the call, then it did not disable addon as well as did not call allLoaded for every other addon that was left in the list.
This should be solved by adding an extra try-catch.
* using java 16 syntax (#1958)
* Fixes kick command (#1960)
PR #1957 broke kick command and noone could kick players from teams.
This should fix it.
* Fixes a bug with blueprint height (#1961)
Blueprint clipboard was preventing setting Y below 0 or above 255.
The code was not adjusted to 1.18 changes.
Reported via discord.
* Fixes Lava Duplication Glitch (#1964)
Due to the fact, that Obsidian Scooping uses one tick delay to remove obsidian, a player with a bucket in hand and offhand duplicated lava.
To avoid that, added an extra check that ignores the interact event if a player holds a bucket in both hands, and interacted hand is offhand.
Fixes#1963
* Fixes failures in obsidian cooping listener. (#1965)
Failures happened after implementing #1964
Co-authored-by: BONNe <bonne@bonne.id.lv>
Co-authored-by: Invvk <70810073+Invvk@users.noreply.github.com>
Due to the fact, that Obsidian Scooping uses one tick delay to remove obsidian, a player with a bucket in hand and offhand duplicated lava.
To avoid that, added an extra check that ignores the interact event if a player holds a bucket in both hands, and interacted hand is offhand.
Fixes#1963
If some addon has code in Addon#allLoaded that crashes the call, then it did not disable addon as well as did not call allLoaded for every other addon that was left in the list.
This should be solved by adding an extra try-catch.
The kick command has an unnecessary owner check. As command should be configurable by island owners, then limiting it to an owner is wrong.
Add a code that allows kicking only lower-ranked players.
Add message that shows who kicked from the island.
Add message that shows that rank does not allow to kick.
* WIP - make easier to understand.
* Small refactor of paster to make it easier to understand
* Fix tabs to spaces. Sorry - new editor!
* Fix tabs to spaces
* Fix tab to spaces
There was no option to cancel teleportation if SafeSpotTeleport could not find a valid spot. This option could be used to avoid creating "backup" blocks in situations when teleportation is avoidable, f.e. visiting an island.
If a player is teleporting on the same island in the same dimension, it keeps spamming that PVP is enabled in dimension.
It should be enough with sending messages when the player teleports to the island.
Fixes#1885
There was an issue in PanelItemTemplate that prevented fallback buttons to be "reusable" things.
The issue was that reusable items were not passed to the panel item reader.
This change implements a new way how to define actions via a custom panel template.
Previously there were 2 options how to define an action:
- by click-type
- as an array list
This adds the third type: by action type. It means that now developers could code that action is the main key for defining what happens when button is clicked:
```
actions:
visit:
click-type: LEFT
tooltip: Tooltip text for left click action
```
#1932 implemented a feature that allows reading multiple panels from a single file, however, there was a missing builder in TemplatedPanelBuilder class that would allow to use it.
This fixes it and adds the missing builder method.
Add new Protection Flag: CHANGE_SETTINGS. This flag allows set which rank can change island settings. By default, it is set to OWNER rank and minimal value is MEMBER rank.
Fixes#1493
* Implement parameter adding to the templated panel title.
There was an issue when templated panels were always static, and api did not have a way how to change it. This will allow passing parameters to the tile, and allow adding dynamic texts.
* Implement parameter adding to the templated panel title.
There was an issue when templated panels were always static, and api did not have a way how to change it. This will allow passing parameters to the tile, and allow adding dynamic texts.
The existing template file reader could read a single configuration section from a file, and the section was required to start with the same name as the file.
This changes it and allows to read any configuration section from the panel.
This change is backward compatible and does not influence existing panels.
In discord, it was reported that running the admin delete command produces a null-pointer if `[player]` placeholder is used.
With fast checking I found out the issue: incorrect user was passed to the command.
Also, I moved runCommands below all resets, so commands could be used to give items, or xp or other stuff that is removed.
* Add CompositeCommand#defaultCommandRank variable.
This variable stores default rank for a command. This adds more flexibility to the Island#commandRanks object. This change allows specifying default rank for each command.
* Add more commands for users to configure on their islands.
Owners now can specify who can use:
- sethome command
- renamehome command
- deletehome command
- setname command
- resetname command
* Adds bonus range elements to Island object.
Admin commands still need to be adjusted or added to support management
of the bonus ranges.
* Changed to mutable class
Fixed bugs.
Some addons may want to introduce two different actions with the same click type.
This change will allow to do it, as now actions may be defined as lists instead of configuration sections.
To use it, action must be defined a bit differently:
```
actions:
- click-type: <value of enum ClickType> # required
type: <value of String> # not required
content: <value of String> # not required
tooltip: <value of String> # not required
- click-type: <value of enum ClickType> # required
type: <value of String> # not required
content: <value of String> # not required
tooltip: <value of String> # not required
```
Co-authored-by: tastybento <tastybento@users.noreply.github.com>
If create-and-link-portals is true, then teleporting to the nether will
not go to a central portal point and instead create a portal in the
nether at the same coordinates as the portal in the overworld.
Teleporting back will not be affected.
https://github.com/BentoBoxWorld/BSkyBlock/issues/464
I am not 100% sure if this would fix https://github.com/BentoBoxWorld/BSkyBlock/issues/451
However, searching google I found that others had a similar issue with the absolute path and they changed it to canonical.
As I was not able to reproduce the main reported issue, I do not know if this fixes it.
* add Block Explosion support for TNT_DAMAGE flag
* prevent block explosion from damaging entities
* seperated flags for block explode
* invert and cancel
* pattern instanceof
* delete island one by one
* register before IslandDeletionManager
* optimize imports
* setting
* just some indents
* config
* run synchronously
* a bit reformat before recoding
* proper delete chunks
* comment
* combine the task call
* expose the NMS Handler
* don't have to try-catch this
* we know that this is final
* expose copy chunk data so that it can be overridden
* Don't have to use Vector
* set block from minimum height
* remove NMS and use fallback if not set
* only get the height once
* fix test
Since Minecraft 1.18 renamed and removed a lot of biomes, some addons that stored them in the database may require migration.
This Adapter will fix that as now BentoBox itself will do migration for all Biome.class objects.
* Update to Minecraft 1.18 (#1887)
* Make BlockEndDragon support custom max world height (#1888)
Use max world height instead of magic 255 value.
* Send PVP toggle messages only to on-island players.
https://github.com/BentoBoxWorld/BentoBox/issues/1885
* Add 1.18.1
Co-authored-by: BONNe <bonne@bonne.id.lv>
* Version 1.18.1
* Added snapshot repo to Maven info.
* Fixes console teleporting.
https://github.com/BentoBoxWorld/BentoBox/issues/1877
* Address potential NPE's
* Preveent NPEs and other items.
* Remove dead paper forks (#1884)
Tuinity has since merged with Paper, and is now not a valid fork
Airplane is shutting down / not updating to 1.18.x
* Added toString to resolve issue with arrays
* Fix minor JavaDoc mistake
Co-authored-by: Fredthedoggy <45927799+Fredthedoggy@users.noreply.github.com>
## Change Log
* Island range perms could be 2x island distance
This could allow protection ranges to be much greater than the island
range and therefore overflow into adjacent islands.
https://github.com/BentoBoxWorld/BentoBox/issues/1851
* Ensure maxEverProtectionRange is less than range.
https://github.com/BentoBoxWorld/BentoBox/issues/1851
* Added test class for Island.
* Added access to private fields for JUnit tests
* Added Sonar Properties to POM
* Changes to analyze using sonar.
* Remove zip reference
* Avoid zipSlip vulnerability.
* Removed the unused WorldEdit hook. (#1853)
If someone wants to add it back later they can, but this code does
nothing right now.
* Requires nonNull parameters for User.instanceOf (#1852)
* Requires nonNull parameters for User.instanceOf
The only reason why User.instanceOf was returning a potential null was
if the parameter was null. Further absolutely no null checking was being
done, so the assumption was that User.instanceOf should never return a
null. This corrects the annotations and requires non-Null parameters.
* Remove null player test
* Fix JavaDoc for GameModeAddon inWorld method
* Fix max-range bug
* Remove illegal tag as it's not needed
* Code smell reduction
* Add missing packages so tests can pass.
* Non null user methods (#1856)
* This makes some User methods non-null.
Instead of returning null, some methods will throw an error if they are
called on non-Players. This means code does not have to do null checks.
* Perform null check in method.
* Null check
* Fix test
* Fix test.
* Npe squashing (#1857)
* Fix hanging [uuid] in info.
* NPE checking
* Make getProtectionCenter nonNull
* More NPE fixes.
* Fix test
* Make getPlayer() and getOfflinePlayer() nonNull returns
This requires addons to not use null checks and instead us the isPlayer
or isOfflinePlayer methods.
* NPE blockers
* Deprecate CompositeCommand isPlayer method.
* Fix test
* Use isPlayer instead of null check.
Refactor code to be easier to understand.
* Fix
* Fix some code smells.
* Prevent NPE possibility.
* Fix "ugly" enchant name. (#1858)
Enchant names did not have a touch of Util#prettifyText code.
* Remove deprecated events.
* Fix IslandSethomeCommand test
* Fix tests - just counts of events.
* Added API to get a translation without color conversion
It may be necessary to read the translation without converting colors to
Bukkit colors.
* Fix tests.
* Fix test.
* Version NPE protections.
* 1.18.0 (#1860)
* Mark all home-related methods in PlayersManager as deprecated.
* Fix bug where maxHomes was shown as null
* Version 1.18.0
API changes may break compatibility with Addons.
* Remove usage of deprecated methods except for migration code.
* Prevent NPE. Check isPlayer instead of getWorld() == null
* Fix nullability issue and added to @Deprecated annotations
* Added deprecation notices to home methods in Players
* Fix missing color conversion for translations.
* Fix mis-statement of island protection coordinates in info command.
* Fix tests
* Fix missing edge deletion of island.
The bounding box was erroneously being made smaller when it was not
required because the inBounds check does that already.
https://github.com/BentoBoxWorld/BentoBox/issues/1863
* Prevent rare NPE
* Ensure oldIsland is never null.
* Refactored setowner command and added test class
* API: Require getWorldSettings to be a game mode world
* Fix tests and refactor code
* Fix test
IWM inWworld needs to return true
* Fix test
IWM inWorld must return true
* Put default getHandlers back in for backwards compatibility
Without them, too many older addons break. They need updating to have
their own handlers. Once that is done, the default ones can be removed
maybe.
* Refactor code for clarity.
* NPE protections
* Prevent NPE
@Poslovich - you were right!
* Throw an error if player is null
* Prevent NPE
* Prevent NPE
* Do a null check
* World should never be null.
* Require non-null world
* Require owner to be non-null. It should never be null
* Prevent NPEs
* Clear the going home flag for edge cases
There were a few potential times when the flag may not have been
cleared. These were mostly teleport failure scenarios. Hopefully, this
is all of them.
https://github.com/BentoBoxWorld/BentoBox/issues/1864
* Shift priority of EntityPortalEnterEvent to HIGH
https://github.com/BentoBoxWorld/BentoBox/issues/1866
This will allow other plugins running at NORMAL to cancel the event
before BentoBox does something.
* Increase priority of EntityPortalEvent listener
https://github.com/BentoBoxWorld/BentoBox/issues/1866
* Fixes https://github.com/BentoBoxWorld/BentoBox/issues/1868
* Code refactoring around User.getInstance(player)
Co-authored-by: BONNe <bonne@bonne.id.lv>
Co-authored-by: Fredthedoggy <45927799+Fredthedoggy@users.noreply.github.com>
Co-authored-by: Justin <jstnf@users.noreply.github.com>
Co-authored-by: gecko10000 <60494179+levtey@users.noreply.github.com>
* Mark all home-related methods in PlayersManager as deprecated.
* Fix bug where maxHomes was shown as null
* Version 1.18.0
API changes may break compatibility with Addons.
* Remove usage of deprecated methods except for migration code.
* Prevent NPE. Check isPlayer instead of getWorld() == null
* Fix nullability issue and added to @Deprecated annotations
* Added deprecation notices to home methods in Players
* Fix hanging [uuid] in info.
* NPE checking
* Make getProtectionCenter nonNull
* More NPE fixes.
* Fix test
* Make getPlayer() and getOfflinePlayer() nonNull returns
This requires addons to not use null checks and instead us the isPlayer
or isOfflinePlayer methods.
* NPE blockers
* Deprecate CompositeCommand isPlayer method.
* Fix test
* This makes some User methods non-null.
Instead of returning null, some methods will throw an error if they are
called on non-Players. This means code does not have to do null checks.
* Perform null check in method.
* Requires nonNull parameters for User.instanceOf
The only reason why User.instanceOf was returning a potential null was
if the parameter was null. Further absolutely no null checking was being
done, so the assumption was that User.instanceOf should never return a
null. This corrects the annotations and requires non-Null parameters.
* Remove null player test
* Version 1.17.1
* Add homes command to default player options.
* Implements better online player counter. (#1791)
Current one is based on online player count when bStats sends data to the server.
This one will send data about amount of players who logged in the server.
* Add Boxed Gamemode to the list. (#1793)
* Add Bank addon (#1792)
* Add Holographic Displays as SoftDepend for AOneBlock (#1794)
* Custom date time format support for /<admin> info <player> (#1783)
Fixes#1720
* Parent/sub-flag support, split up and designate CONTAINER flag as parent flag (#1784)
* Split CONTAINER flag into multiple flags
CONTAINER split into
- CONTAINER (Chest/Minecart Chest)
- BARREL (Barrel)
- COMPOSTER (Composter)
- FLOWER_POT (Flower Pot)
- SHULKER_BOX (Shulker Box)
- TRAPPED_CHEST (Trapped Chest)
Fixes#1777
* Add subflag support
* Create container parent flag, chest subflag
* Remove extra string from when CHEST was CONTAINER
* Fix incorrect flag specified on fired event in IslandToggleClick
* Add missing world subflag event firing
* Remove extra import
* Add world setting flag for island visitors keep inventory (#1785)
* Implement 3 bar charts: addons, gamemodes, hooks (#1790)
BStats supports sending Bar chart data, however, it does not display it via their site directly.
It can be called manually, to view.
PieChart does not work very well for addons and hooks. BarChart however allows viewing each addon separately.
This change allows sending data to the server about bar charts.
* Update action versions
* Declare distribution - adopt
* Cache Java Maven files differently.
* Try dependency for shade snapshot
* Add support for Minecraft 1.17.1
* Fix test by incrementing listener value check
There is a new listener now.
* Spigot 1.17.1
* Fix test for InventoryListener
* Re-order repos.
* Downgrading to 1.17 Spigot for now to enable building.
* Try pluginRespositories tag in POM to enable Github actions
* Version 1.17.2
* Add alternative Addon#getIslandManager method (#1797)
We have already done this to the main BentoBox class. But add-ons missed it, and it still has this weird structure: Addon#getIslands().getIslands().
This will just add the same method as it is already in BentoBox class.
* Fix bucket dupe (#1806)
Fix https://discord.com/channels/272499714048524288/310623455462686720/867790395442462760
* Removes unneeded exploit protection code for skulls (#1810)
This no longer seems to be required with 1.17.1
https://github.com/BentoBoxWorld/BSkyBlock/issues/430
* Quote filename of addon that cannot be loaded.
Provides a better understanding of which addon failed.
* Remove update when pasting chest.
* Version 1.17.3
* Java upgrade (#1814)
* Version 1.17.3
* Use Map.of and List.of instead of Immutable collections
* Replace explicit type argument.
* Replace lamba with method reference
* Replace condition with Objects.requireNonNullElseGet
* Use String.repeat
* Use new switch expressions
* Use instanceof patten variables which are more compact
* Fuse toUnmodifiableList into stream and return it.
* Remove unnecessary toString() calls.
* Remove unnecessary public
* Extracted common part from if
* Simplify conditional expressions
* Remove unused IOExceptions
* Cast to long
* Use Map.putAll
* Use primitives
* Clarify what is null or not
* Addedd @Serial annotation introduced with Java 14.
* Use Optional.isEmpty instead of !isPresent
* Use flatMap then ifPresent
* Just use Arrays.stream
* Swap map and filter for null with Objects::nonNull
* Use expression lambda
* Update JavaDoc version to 16
* Make spawn protection area square instead of circle.
https://github.com/BentoBoxWorld/BentoBox/issues/1819
* Improve ItemParser code. (#1821)
* Improve ItemParser code.
Add ability to parse text if Material is just a single string.
Add ability to parse player heads.
Add comments to the code.
* Fixes failing test.
* Added deprecation suppression.
* Added Pladdon to loadbefore.
* Prevent bucket duping when scooping obsidian Part 35
https://github.com/BentoBoxWorld/BentoBox/issues/1825
* Warns visitors that PVP is active if they teleport to an island
https://github.com/BentoBoxWorld/BentoBox/issues/1780
* Prevents repeated portaling when nether is disabled. (#1826)
* Prevents repeated portaling when nether is disabled.
https://github.com/BentoBoxWorld/BentoBox/issues/1782
* Fix test
* Hex pr 1820 (#1822)
* Fix @since for subflags. (#1831)
* Add Citizens to Softdepend list for NPC support (#1834)
* Fix color test.
* Set the default game mode when player makes island.
* Corrects JavaDocs link
Fixes https://github.com/BentoBoxWorld/BentoBox/issues/1838
* Update to 3.3.1-SNAPSHOT for shade plugin.
* Package info files for better JavaDocs (#1839)
* Added package info files for better JavaDocs
* Implement Flag icon changing via Locales file. (#1829)
This commit contains 2 changes:
- An option for Flag to use icon that is defined in locales after "icon" string.
- An option for ItemParser to parse icon or return given value, if parsing was not successful.
The flag option is not ideal, but it is simpler and easier to maintain then adding new config section where icons can be changed, as the locales file already contains a lot of info about each flag.
* Support glowing ink in blueprints (#1842)
Fixes https://github.com/BentoBoxWorld/BentoBox/issues/1837
* Panel template (#1841)
* Implement basic functionality to read data from template panels.
Create TemplateReader class that has static method which generates a PanelTemplateRecord. This record contains every necessary information from user created template file so everyone could use it to generate a functional panel.
These classes are just for reading templates and do not create actual panel.
* Add template clearing via bentobox reload command.
* Fix version command to show addon state.
* Fix German flag banner description.
Added more debug around error reporting.
* Make variables final if they can be. (#1843)
* Make variables final if they can be.
* Do not use final so that test can pass.
For testing, we use a trick to set this variable, but it won't work if
it is final. Right now, I'd like to keep the test.
* Static code analysis (#1844)
* StringBuffer (Java 5) may be declared as StringBuilder
* Replace map with flatMap
* Use instanceof naming
* No need to specify paramter types.
* Remove verbose code
* Fix JavaDoc issues
* Make internal class a record.
* Remove unused import.
* Make internal class a record.
* Made internal class a record.
* Removed unused import
* Fix typos
* Fix typo in test.
* Prevent home teleport when already home teleporting
Home teleporting is async so it's possible to issue the command multiple
times. This puts a flag in so that if a playeer is mid-teleport, then
issuing the go command will just repeat the text that the player is
teleporting home.
https://github.com/BentoBoxWorld/BentoBox/issues/1637
* Extracted island info from the Island object.
This is in preparation to have a different info for players than admins.
https://github.com/BentoBoxWorld/BentoBox/issues/1501
* Slimmer trimmer island info for players.
https://github.com/BentoBoxWorld/BentoBox/issues/1501
* Fixes coop and trust invites when team invites are not allowed
If a member or sub-owner has coop or trust invite capability and not
team invite rank, and confirm invites is on, then the invites were not
working.
Fixes https://github.com/BentoBoxWorld/BentoBox/issues/1452
* Remove invulnerable visitor protection if island is in PVP mode
We now have alerts if a player teleports to a PVP island.
https://github.com/BentoBoxWorld/BentoBox/issues/668
* Fixes NPE in admin tp if nether or end worlds don't exist.
* Adds arrow sound when teleporting into a PVP island.
* Fix PVPListenerTest
Visitors are no longer invincible when on a PVP island.
* Fix test failure in InvincibleVisitorsListenerTest
* Minor JavaDoc correction.
* Go command was not working second time.
* Prevents console errors for missing icons in locale files.
* Fixes PlAddon disabling issue. (#1847)
There was a bug that did not unload PlAddon classes from JVM.
This change should fix it, as it will unload PlAddons via pluginLoader.
* Clear code - set worlds once on construction.
* Fixes a bug when Potion metadata was not applied (#1849)
There was missing potion meta data applying after creating an item.
This affects both: Potions and Tipped arrows.
* Adds force-shown lines to the template. (#1850)
* Adds force-shown lines to the template.
Fixes a bug when template type was not selected correctly.
Changes "name" to "title" for border and background icons.
* Create TemplatedPanel and TemplatedPanelBuilder.
TemplatedPanel uses PanelTemplateRecord to create a functional panel.
Builder contains button builder callbacks that are used to create buttons with custom data.
* Use final vars for lambdas to avoid them changing async
The processes could run async, especially when chunk loading took a
while, so using fields that could change would result in blocks being
missed, especially in the nether or end. Switching to final vars avoids
this.
Fixes https://github.com/BentoBoxWorld/BentoBox/issues/1840
* Remove travis.
Co-authored-by: BONNe <bonne@bonne.id.lv>
Co-authored-by: Fredthedoggy <45927799+Fredthedoggy@users.noreply.github.com>
Co-authored-by: Justin <jstnf@users.noreply.github.com>
Co-authored-by: gecko10000 <60494179+levtey@users.noreply.github.com>
The processes could run async, especially when chunk loading took a
while, so using fields that could change would result in blocks being
missed, especially in the nether or end. Switching to final vars avoids
this.
Fixes https://github.com/BentoBoxWorld/BentoBox/issues/1840
* Adds force-shown lines to the template.
Fixes a bug when template type was not selected correctly.
Changes "name" to "title" for border and background icons.
* Create TemplatedPanel and TemplatedPanelBuilder.
TemplatedPanel uses PanelTemplateRecord to create a functional panel.
Builder contains button builder callbacks that are used to create buttons with custom data.
Home teleporting is async so it's possible to issue the command multiple
times. This puts a flag in so that if a playeer is mid-teleport, then
issuing the go command will just repeat the text that the player is
teleporting home.
https://github.com/BentoBoxWorld/BentoBox/issues/1637
* StringBuffer (Java 5) may be declared as StringBuilder
* Replace map with flatMap
* Use instanceof naming
* No need to specify paramter types.
* Remove verbose code
* Fix JavaDoc issues
* Make internal class a record.
* Remove unused import.
* Make internal class a record.
* Made internal class a record.
* Removed unused import
* Fix typos
* Fix typo in test.
* Make variables final if they can be.
* Do not use final so that test can pass.
For testing, we use a trick to set this variable, but it won't work if
it is final. Right now, I'd like to keep the test.
* Implement basic functionality to read data from template panels.
Create TemplateReader class that has static method which generates a PanelTemplateRecord. This record contains every necessary information from user created template file so everyone could use it to generate a functional panel.
These classes are just for reading templates and do not create actual panel.
* Add template clearing via bentobox reload command.
This commit contains 2 changes:
- An option for Flag to use icon that is defined in locales after "icon" string.
- An option for ItemParser to parse icon or return given value, if parsing was not successful.
The flag option is not ideal, but it is simpler and easier to maintain then adding new config section where icons can be changed, as the locales file already contains a lot of info about each flag.
* Improve ItemParser code.
Add ability to parse text if Material is just a single string.
Add ability to parse player heads.
Add comments to the code.
* Fixes failing test.
* Version 1.17.3
* Use Map.of and List.of instead of Immutable collections
* Replace explicit type argument.
* Replace lamba with method reference
* Replace condition with Objects.requireNonNullElseGet
* Use String.repeat
* Use new switch expressions
* Use instanceof patten variables which are more compact
* Fuse toUnmodifiableList into stream and return it.
* Remove unnecessary toString() calls.
* Remove unnecessary public
* Extracted common part from if
* Simplify conditional expressions
* Remove unused IOExceptions
* Cast to long
* Use Map.putAll
* Use primitives
* Clarify what is null or not
* Addedd @Serial annotation introduced with Java 14.
* Use Optional.isEmpty instead of !isPresent
* Use flatMap then ifPresent
* Just use Arrays.stream
* Swap map and filter for null with Objects::nonNull
* Use expression lambda
* Version 1.17.2
* Add alternative Addon#getIslandManager method (#1797)
We have already done this to the main BentoBox class. But add-ons missed it, and it still has this weird structure: Addon#getIslands().getIslands().
This will just add the same method as it is already in BentoBox class.
* Fix bucket dupe (#1806)
Fix https://discord.com/channels/272499714048524288/310623455462686720/867790395442462760
* Removes unneeded exploit protection code for skulls (#1810)
This no longer seems to be required with 1.17.1
https://github.com/BentoBoxWorld/BSkyBlock/issues/430
* Quote filename of addon that cannot be loaded.
Provides a better understanding of which addon failed.
* Remove update when pasting chest.
Co-authored-by: BONNe <bonne@bonne.id.lv>
Co-authored-by: Fredthedoggy <45927799+Fredthedoggy@users.noreply.github.com>
Co-authored-by: Justin <jstnf@users.noreply.github.com>
Co-authored-by: gecko10000 <60494179+levtey@users.noreply.github.com>
We have already done this to the main BentoBox class. But add-ons missed it, and it still has this weird structure: Addon#getIslands().getIslands().
This will just add the same method as it is already in BentoBox class.
* Version 1.17.1
* Add homes command to default player options.
* Implements better online player counter. (#1791)
Current one is based on online player count when bStats sends data to the server.
This one will send data about amount of players who logged in the server.
* Add Boxed Gamemode to the list. (#1793)
* Add Bank addon (#1792)
* Add Holographic Displays as SoftDepend for AOneBlock (#1794)
* Custom date time format support for /<admin> info <player> (#1783)
Fixes#1720
* Parent/sub-flag support, split up and designate CONTAINER flag as parent flag (#1784)
* Split CONTAINER flag into multiple flags
CONTAINER split into
- CONTAINER (Chest/Minecart Chest)
- BARREL (Barrel)
- COMPOSTER (Composter)
- FLOWER_POT (Flower Pot)
- SHULKER_BOX (Shulker Box)
- TRAPPED_CHEST (Trapped Chest)
Fixes#1777
* Add subflag support
* Create container parent flag, chest subflag
* Remove extra string from when CHEST was CONTAINER
* Fix incorrect flag specified on fired event in IslandToggleClick
* Add missing world subflag event firing
* Remove extra import
* Add world setting flag for island visitors keep inventory (#1785)
* Implement 3 bar charts: addons, gamemodes, hooks (#1790)
BStats supports sending Bar chart data, however, it does not display it via their site directly.
It can be called manually, to view.
PieChart does not work very well for addons and hooks. BarChart however allows viewing each addon separately.
This change allows sending data to the server about bar charts.
* Update action versions
* Declare distribution - adopt
* Cache Java Maven files differently.
* Try dependency for shade snapshot
* Add support for Minecraft 1.17.1
* Fix test by incrementing listener value check
There is a new listener now.
* Spigot 1.17.1
* Fix test for InventoryListener
* Re-order repos.
* Downgrading to 1.17 Spigot for now to enable building.
* Try pluginRespositories tag in POM to enable Github actions
Co-authored-by: BONNe <bonne@bonne.id.lv>
Co-authored-by: Fredthedoggy <45927799+Fredthedoggy@users.noreply.github.com>
Co-authored-by: Justin <jstnf@users.noreply.github.com>
BStats supports sending Bar chart data, however, it does not display it via their site directly.
It can be called manually, to view.
PieChart does not work very well for addons and hooks. BarChart however allows viewing each addon separately.
This change allows sending data to the server about bar charts.
Current one is based on online player count when bStats sends data to the server.
This one will send data about amount of players who logged in the server.
* Java 16 preliminary branch.
This compiles, but junit tests fail all over because there is a lack of
Java 16 support right now.
* Use Java 16
* 1.17 WIP
* Require 1.17
* Fixes tests.
* WIP fixing tests
* Exclude maven from shading
* Try update snapshots to build action
* Try repo on command line
* Remove reference to shade plugin in dependencies
* Updated german language file
Fixed typo, fixed consistency (beacon = english, Leuchtfeuer = german)
* Updated german language filede.yml
fixed typos, translated messages that were still in English
IslandsManager.getIslandLocation(world, uuid) is used to find the
starting point for the island home if a safe home for players cannot be
found. It returns the island center location but should return the
center of the island protection because that can now be in a different
location.
The issue happens mostly with the end portals. Apparently, teleportation to the end is processed before the Bukkit task that runs SafeSpotTeleport. The first check if a player is in the starting world fails, and SafeSpotTeleport is not called.
I set the event to be cancelled in all situations when we do not create portals, so it always triggers SafeSpotTeleport. This should fix the bug with players appearing in the void.
If a player has end portal at Y=0 or Y=1, then they were spawned in the void, if makePortals option was enabled.
It happens because end portals are generated with 2 air layers above the obsidian platform. So minimal location is necessary to be at least 2 (2 for air and obsidian at 0).
* Switch to island homes from player homes.
Stores home locations and max homes in the Island object. Adds commands
required to manage home names, specifically rename and delete. I did not
add list as there is tab complete on island go, but it may be required.
* Adds maxMembers to the Island object for persistent storage
https://github.com/BentoBoxWorld/BentoBox/issues/1690
* Expanded approach to include coop and trusted ranks.
* Checks for max members/coops/trusts on accept based on island setting.
* Write island max member/coop/trusted if owner joins server
This updates the island's settings based on the owner's permissions.
Adds 3 new BentoBox options:
- use-cache-server: option which allows to use mc-heads.net API for gathering player heads. It is a bit faster than Mojang API.
- heads-per-call: option which allows to specify how many heads will be requested at once per each API call.
- ticks-between-calls: option which allows to specify how many ticks should be waited until next API call.
All these options will allow much more faster player head gatherer.
Changes includes optimization for Mojang API too. For servers in online mode, HeadGetter will use Player UUID, instead of asking for UUID from API.
Panel API did not have this context so commands had to force players to
be in the world that the command used. These changes add the world
context to the PanelBuilder and changes the settings panels to use it.
Players and admins can now run settings commands in any world.
https://github.com/BentoBoxWorld/BentoBox/issues/1673
