Commit Graph

3630 Commits

Author SHA1 Message Date
tastybento
6c1bcdec05 Added test class for IslandChunkDeletionManager 2023-02-08 20:23:19 -08:00
tastybento
a793a33758 Minimal test class for BlueprintPaster 2023-02-08 19:53:16 -08:00
tastybento
1783bb7058 Fixes bug where pasting was happening twice 2023-02-08 19:21:50 -08:00
tastybento
a703499817 Added test class. 2023-02-08 19:16:32 -08:00
tastybento
224be307a0 Fix JavaDoc errors 2023-02-08 18:40:03 -08:00
tastybento
b62a1862a2 Add ${argLine} to surefire plugin
This should fix the coverage reports.
2023-02-08 17:17:12 -08:00
JamesMCL44
3623537d84
Update zh-HK.yml (#2085)
Update to latest locale for latest plugin version
2023-02-06 12:56:02 -08:00
tastybento
6c8ccd2a57 Attempt to get coverage report from SonarCloud 2023-02-05 17:23:52 -08:00
tastybento
f1eaa0fcde Refactor to reduce complexity 2023-02-05 16:23:23 -08:00
tastybento
9ccdcceaba Refactor to reduce complexity 2023-02-05 16:19:05 -08:00
tastybento
35ece03e5b Refactor to reduce complexity. 2023-02-05 16:08:23 -08:00
tastybento
760bc2e086 Define a constant instead of duplicating literals 2023-02-05 16:03:43 -08:00
tastybento
caf994738e Defined a constant instead of duplicating "CHEST" 7 times 2023-02-05 16:00:06 -08:00
tastybento
f00320095d Added since and forRemoval to Deprecated annotations. 2023-02-05 15:55:51 -08:00
tastybento
46d20f34ff Remove statements that are always true 2023-02-05 15:50:04 -08:00
tastybento
df910e96d3 Refactor to reduce complexity. 2023-02-05 15:46:32 -08:00
tastybento
f29e78557a Change location of seed world data.
Fixes #2087
2023-02-05 14:11:59 -08:00
tastybento
2d8b3074a9 Minor refactor to remove continue from for loop 2023-02-05 10:39:10 -08:00
tastybento
ad2541963e Minor instanceof casting change 2023-02-05 10:38:09 -08:00
tastybento
2c1a018071 Clarify nonnull on Location 2023-02-05 10:37:43 -08:00
tastybento
c6fc42846a Remove unused imports 2023-02-05 10:15:34 -08:00
tastybento
0e253f3ba5 Clarify that parameter is non-null 2023-02-05 10:10:25 -08:00
tastybento
a68436fde1 Remove Optional from parameter. 2023-02-05 10:05:57 -08:00
tastybento
1d28979d5c Refactor to reduce complexity 2023-02-04 19:08:09 -08:00
tastybento
187132bc1d Refactor to reduce complixty. Added comments. 2023-02-04 19:00:18 -08:00
tastybento
3331ffac4e Refactor to reduce complexity. 2023-02-04 18:49:13 -08:00
tastybento
f9e57898ab Refactor to reduce complexity. 2023-02-04 18:45:05 -08:00
tastybento
0c29d0b5dd
Uses seed worlds for deletion purposes (#2084)
* Uses seed worlds for deletion purposes

* Use Flat type

* Implement the superflat saver

* Fix nullable issue

* Fix tests.

* Fix code smells
2023-02-04 18:37:06 -08:00
tastybento
7040047fcb Fix broken test for IslandRespawnListener 2023-02-04 10:37:02 -08:00
BONNe
ea6ca3d26b
Add variable parsing on reference text (#2073)
This solves the issue in customizable GUI's where variables are defined directly into the panel button name and description instead of providing the link to the locale. 

Not all users want to specify all text into a locale, and they would not get parsed variables just because of that.
This change fixes it and it does not give any bad situations even if the reference is just missing text in the locale, as there will be nothing for parsing.
2023-01-31 18:03:37 +02:00
tastybento
a604d5cf82
Add [owner] in command placeholders #2080 (#2081) 2023-01-31 07:13:01 -08:00
tastybento
bbb8207cf0 Teleportation was processed for entities even if it was switched off
Addresses #2078

Added test class to cover some of the logic in the teleportation class.
More tests can be written to cover the various outcomes.
2023-01-28 16:04:52 -08:00
BONNe
e89970b49b
Remove 1.18.2 from supported version list. (#2074)
* Remove 1.18.2 from supported version list.

1.18.2 support was removed with changes in commit 056cff4b6f

Also, mark 1.19, 1.19.1 and 1.19.2 as incompatible. It happens because of GSon library changes that prevents bentobox compiled with Spigot 1.19.3 to run on older versions.

* Fixes GSON crashes introduced by migrating to 1.19.3 api.
2023-01-06 18:29:37 +02:00
tastybento
0de2c3a7b6 Update JavaDoc to indicate return value is immutable 2023-01-05 21:30:19 -08:00
tastybento
0f89de6c2a Make list mutable. 2023-01-05 21:16:50 -08:00
tastybento
8e40bf9dcf Added more validation for addon.yml and test class 2023-01-02 09:31:16 -08:00
tastybento
10a73e66b4 Added explicit @since annotation 2023-01-01 09:25:09 -08:00
tastybento
3746349e22 The protected modifier for constructor should be enough.
Constructors of abstract classes can only be called in constructors of
their subclasses. So there is no point in making them public.
2023-01-01 09:22:41 -08:00
tastybento
0e5db0f41f Quiet excessive warnings from JavaDoc plugin 2023-01-01 09:19:20 -08:00
tastybento
1262a08a22 Removed deprecated method isPlayer(User) 2023-01-01 08:43:31 -08:00
tastybento
f545a4576e Remove unused comment 2023-01-01 00:19:10 -08:00
tastybento
ab434b63fa Completed tests for User class 2023-01-01 00:17:30 -08:00
tastybento
6b88d31762 Bug fix for particle validation 2023-01-01 00:02:59 -08:00
tastybento
93ca9fb0e6 Correct nullable tags 2022-12-31 18:33:49 -08:00
tastybento
0bffe3806a Fix tests 2022-12-31 18:19:32 -08:00
tastybento
872940011a Loads of minor code smell fixes
Mostly replacing instanceof check and cast with e.g. 'instanceof Player
player'
Replaced some "switch" statements by "if" statements to increase
readability.
Used the primitive boolean check to avoid potential NPEs.
Reordered field modifiers to comply with the Java Language
Specification. Mainly @NonNull position.
2022-12-31 18:19:25 -08:00
tastybento
056cff4b6f
Code clean up from Sonar Cloud analysis (#2068)
* Code clean up from Sonar Cloud analysis

* Fix tests

* Remove code smell

* Rename "island" which hides the field declared at line 25.

* Removed code smells.

* Rename variable record to rec

Renamed "record" variable to not match a restricted identifier.
Restricted Identifiers should not be used as identifiers. "record" is
using in Java 16.

* Added private constructor to prevent instantiation of static class

Changed variable name to rec instead of restricted "record".

* Remove Blueprint code smells.

* Use a record for database settings constructor

Code smell: Methods should not have too many parameters. I'm not sure
what methods are using this class though.

* Update MyWorlds version

The POM for MyWorlds is invalid and causes a warning, but this still
persists with this version.

* Extracted nested try block into a separate method.

Makes it clear when reading the code what might be caught

* Extracted nested try block into a separate method.

* Fixed JavaDoc /** instead of just /*

* Extracted nested try block into a separate method.

* Refactored to not assign loop counter from within the loop body.

* Better delete option. With results.

That said, this is legacy code to handle an issue that occurred a long
time ago and this whole set of code can probably be removed.

* Catch Exceptions not Throwable

* Log error with BentoBox logError

* Use computeIfAbsent

Using these instead leads to cleaner and more readable code.

* User can no longer be null

* Added the missing @Deprecated annotation and @since ref

* Added @since reference

* Merge if statements

* Use BentoBox error logging.

* Added JavaDoc @since

* Remove deprecated class and move used class

* Remove deprecated WoodType and use Type.

* Remove unused import

* Extracted nested try block into a separate method.

* Comment empty default statement

* Clean up logic; avoid switch

* Use Java instead of Guava

* private constructor to hide the implicit public one.

* Private constructor to hide the implicit public one.

Merged if statement.

* Add comment

* if merge

* Make variable constant

* Remove unused imports

* Remove deprecated and unused method

* Remove unused import

* Typo

* Remove instanceof and cast

* Remove superfluous null check

* Put constant at bottom of file because @BONNe likes it there.

* Simplify particle validation code
2022-12-31 16:41:17 -08:00
tastybento
0183380b82 Edited US English text entries
Supercedes #1033
2022-12-30 11:22:01 -08:00
tastybento
d541e7054c Merge branch 'develop' of https://github.com/BentoBoxWorld/BentoBox.git into develop 2022-12-30 11:20:31 -08:00
tastybento
36ae34da5d
2049 trees growing outside range (#2050)
* Fixes #2046. Handles null players for placeholders.

* Remove unused import

* Fixes #2049 for adjacent island spaces

This also deletes blocks in the event rather than setting them to AIR as
was done previously.
2022-12-30 09:37:18 -08:00