Commit Graph

1596 Commits

Author SHA1 Message Date
tastybento
7d08a0db5a Enable main player and admin command declaration
See https://github.com/BentoBoxWorld/BentoBox/issues/448
2019-01-15 19:33:53 -08:00
tastybento
49d2365f85 Removed unneeded commented out code 2019-01-15 15:46:59 -08:00
tastybento
016c502b66 Added explicit test for addon locale override 2019-01-15 15:43:37 -08:00
tastybento
0636532bb4 Fixed code and tests.
Test failures in the User test were right - I had a bug in my code.
2019-01-15 15:23:17 -08:00
tastybento
e56928bef1 Adds ability for gamemodes to override locale references
The default BentoBox locale text is geared towards island games. When
writing the SkyGrid addon I am using the standard protection flags, but
I need to reference a "protection area" instead of an "island". This
enables me to do that by having the same reference but prefixed in the
locale file by the name of the addon (in lower case), as written in the
addon's addon.yml.
2019-01-15 13:23:36 -08:00
tastybento
3a9e969a86 Added JavaDoc comments 2019-01-15 11:47:10 -08:00
tastybento
2fa60d0e2d Added option to not paste a schem when creating a new island 2019-01-15 11:46:09 -08:00
tastybento
b48cc89f73 Added flag default setting for specific world. 2019-01-15 11:45:49 -08:00
tastybento
61481dee44 Added null protection against null world values 2019-01-15 08:33:14 -08:00
Florian CUNY
62d69b1022 Added NonNull/Nullable annotations to FlagListener, deprecated FlagListener#id(String), added FlagListener#getFlag(String) 2019-01-14 15:49:04 +01:00
Florian CUNY
80263d9751 Removed commented-out code in Clipboard 2019-01-14 15:48:16 +01:00
Florian CUNY
7fd6237280
Added comments to DeleteIslandChunks
I've also added a sonar suppresswarning to avoid the "issues" when calling regenerateChunk
2019-01-14 15:15:55 +01:00
tastybento
044c67ea28 Fixes bug with concurrent saving of files to the database.
Implemented a FIFO to queue async save requests for YAML and MySQL.

The assumption is that most database objects will be held in memory
because the ordering of object loading is not handled. That means that
it is theoretically possible to load something on the main thread before
it has been saved in the async thread if you are really quick. So, in
general, you should load objects once and ideally never load them again
unless there's a big span of time in between so the async can finish.
For most situations, this race condition should not occur, but I'm just
warning about it.

Saving on shutdown is not async and takes as long as it takes.

Also added some defensive code to disable the plugin if the database
connection info is wrong and print an error message instead of lots of
errors.

Changed CleanSuperFlatListener to use a LinkedList for its queue.
2019-01-13 22:17:36 -08:00
tastybento
5ed86ea271 Adds defensive code to avoid NPE with hiding clipboard 2019-01-13 15:57:45 -08:00
tastybento
fa8c0ec0c8 Implements async superflat cleaning
Should avoid crashes when there's a lot of cleaning to do.

https://github.com/BentoBoxWorld/BentoBox/issues/431
2019-01-13 15:53:12 -08:00
tastybento
e4e6525995 Exclude eclipse jar from shaded jar to fix crash.
See https://github.com/BentoBoxWorld/BentoBox/issues/469
2019-01-13 15:11:03 -08:00
tastybento
ad3d044e88 Merge branch 'develop' of https://github.com/BentoBoxWorld/bentobox.git into develop 2019-01-13 14:19:31 -08:00
tastybento
96639792b8 Fixed random test failures.
Note: If using the User class in a test, you MUST set the mock plugin object using the User.setPlugin() method otherwise each test will use the wrong plugin object and verifications will not work.
2019-01-13 14:19:23 -08:00
Florian CUNY
8260728e9b Added NonNull/Nullable annotations to CommandsManager 2019-01-13 18:41:38 +01:00
Florian CUNY
a66bc90746 Fixed code smells 2019-01-13 18:27:14 +01:00
tastybento
5f990b9103 Fix for PhysicalInteractionListenerTest
Sometimes would randomly fail. This should fix it. (He says...)
2019-01-13 09:07:05 -08:00
tastybento
6425938107 Merge branch 'develop' of https://github.com/BentoBoxWorld/bentobox.git into develop 2019-01-13 08:53:06 -08:00
tastybento
8a1b487a58 Fix test cases for ban commands. 2019-01-13 08:52:57 -08:00
Florian CUNY
270e14167e Made IslandTeamInviteAcceptCommand require confirmation
Closes #464.
2019-01-13 17:35:32 +01:00
tastybento
d8eab7e397 Adds deleteID method to MariaDB 2019-01-13 08:14:08 -08:00
tastybento
6557d2fad5
Merge pull request #466 from BentoBoxWorld/IslandDelete
Island delete and async saving for YAML and MySQL
2019-01-13 07:59:39 -08:00
Florian CUNY
35883435e5 Merge branch 'develop' into IslandDelete 2019-01-13 10:33:50 +01:00
Florian CUNY
6f4d3aeaed Added some more javadoc 2019-01-13 10:28:49 +01:00
Florian CUNY
9cf63611e4 Added some NonNull/Nullable in database code 2019-01-13 10:27:36 +01:00
Florian CUNY
dc7d5b40f2 Renamed DeletedIslandDO to IslandDeletion 2019-01-13 10:21:06 +01:00
Florian CUNY
0f253c35ef Renamed IslandDeleteManager to IslandDeletionManager 2019-01-13 10:09:35 +01:00
Florian CUNY
165a70aec9 Added MariaDB minimum version in config comment 2019-01-13 10:06:32 +01:00
Florian CUNY
348704f3d9 Added javadoc and updated Settings for MARIADB
@barpec12
2019-01-13 10:05:24 +01:00
tastybento
7854187448 Added async saving to YAML and MYSQL
Both seem to work fine, but probably need more real-world testing.
2019-01-12 18:18:22 -08:00
tastybento
501c3257ed Island delete enhancements
Island deletion is done a few chunks at a time per tick. Current speed
is 5 chunks per tick per world (e.g., 15 chunks per tick if nether and
end islands are used).

Chunks are deleted based on the all-time maximum protection range of the
island. This is because the protection range can grow bigger or smaller
over the island's lifetime. To ensure all possible chunks are erased,
the largest every protection range is remembered and used.

Very large protection ranges will take a long time to fully delete.

Info on islands that are being deleted is stored in the database. If the
server shuts down mid-deletion, deletion will restart when the server
restarts.

While an island is being deleted, new islands cannot occupy that spot
and the spot cannot be reserved by the admin.

In addition, async approaches to island saving and player saving were
removed. Async will be implemented another way.

Now, instead of saving the full island or player database, individual
database entries are saved instead to be more efficient.
2019-01-12 17:12:30 -08:00
tastybento
7a4ca8b48d Fixed JavaDoc error 2019-01-12 17:04:53 -08:00
Florian CUNY
a1b6f97a1a
Merge pull request #460 from barpec12/master
MariaDB 10.2.3+ support.
2019-01-12 22:57:01 +01:00
tastybento
7c1e195eaf Switch to timer-based chunk deletion 2019-01-12 10:31:25 -08:00
Florian CUNY
457b296372 Fixed code smells 2019-01-12 18:29:20 +01:00
Florian CUNY
76d4edd19f Added NonNull/Nullable to FlagsManager; deprecated getFlagById(String)
Added getFlag(String) that will return an optional instead.
2019-01-12 18:03:19 +01:00
Florian CUNY
12619e79db Improved links in LogEntry's javadoc 2019-01-12 18:02:32 +01:00
Florian CUNY
c783fa8e16 Started to add Nullable/NonNull annotations 2019-01-12 17:30:47 +01:00
barpec12
961ca02fa1 MariaDB 10.2.3+ support. 2019-01-10 16:54:11 +01:00
tastybento
b51178518a Fixes admin setowner and info commands for team members
https://github.com/BentoBoxWorld/BentoBox/issues/452
2019-01-07 21:37:37 -08:00
tastybento
cd4f0c2561 Fixes Invincible Visitors Settings GUI bug
https://github.com/BentoBoxWorld/BentoBox/issues/450

Added enhanced test to this class too.
2019-01-07 21:03:02 -08:00
tastybento
8a63bf80f9 Added defensive code to avoid infinite loop
CleanSuperFlat can infinite loop if the generator isn't working.
2019-01-07 20:43:37 -08:00
tastybento
dc8b672286 Added check against duplicate Island UUIDs
May relate to https://github.com/BentoBoxWorld/BentoBox/issues/447
2019-01-07 08:03:38 -08:00
tastybento
acb6cd5650 Added defensive null checking code to DB
Relates to https://github.com/BentoBoxWorld/BentoBox/issues/447
2019-01-07 07:46:59 -08:00
Florian CUNY
9eec14ffb3
Merge pull request #445 from BONNe/patch-1
Unnecessary getPermissionPrefix()
2019-01-07 06:25:57 +01:00
BONNe
dbbfdaea7f
Unnecessary getPermissionPrefix()
Kryniowesegryderiusz <3 in Support noticed that Admin tp command has double bskyblock.bskyblock, and I found reason in code.
This getPermissionPrefix() is not necessary, as setPermission() will also add prefix.
2019-01-06 23:32:15 +02:00