1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-28 12:45:45 +01:00
bitwarden-browser/.github/PULL_REQUEST_TEMPLATE.md

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

36 lines
1.6 KiB
Markdown
Raw Normal View History

2024-05-24 16:47:16 +02:00
## 🎟️ Tracking
2021-12-21 15:43:35 +01:00
2024-05-24 16:47:16 +02:00
<!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. -->
2024-05-24 16:47:16 +02:00
## 📔 Objective
2024-05-24 16:47:16 +02:00
<!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. -->
2024-05-24 16:47:16 +02:00
## 📸 Screenshots
2024-05-24 16:47:16 +02:00
<!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. -->
2021-12-21 15:43:35 +01:00
2024-05-24 16:47:16 +02:00
## ⏰ Reminders before review
2024-05-24 16:47:16 +02:00
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
2024-05-24 16:47:16 +02:00
## 🦮 Reviewer guidelines
2024-05-24 16:47:16 +02:00
<!-- Suggested interactions but feel free to use (or not) as you desire! -->
2024-05-24 16:47:16 +02:00
- 👍 (`:+1:`) or similar for great changes
- 📝 (`:memo:`) or (`:information_source:`) for notes or general info
- ❓ (`:question:`) for questions
- 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
- 🎨 (`:art:`) for suggestions / improvements
- ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention
- 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt
- ⛏ (`:pick:`) for minor or nitpick changes