1
0
mirror of https://github.com/bitwarden/browser.git synced 2025-02-06 23:51:28 +01:00

CLI device approvals - Use single deny endpoint (#9763)

This commit is contained in:
Thomas Rittson 2024-06-26 05:54:38 +10:00 committed by GitHub
parent 4a8b44b662
commit 00801f95ce
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 24 additions and 4 deletions

View File

@ -43,7 +43,7 @@ export class ApproveCommand {
const request = pendingRequests.find((r) => r.id == id);
if (request == null) {
return Response.error("Invalid request id");
return Response.error("The request id is invalid.");
}
await this.organizationAuthRequestService.approvePendingRequest(organizationId, request);

View File

@ -38,10 +38,16 @@ export class DenyCommand {
}
try {
await this.organizationAuthRequestService.denyPendingRequests(organizationId, id);
await this.organizationAuthRequestService.denyPendingRequest(organizationId, id);
return Response.success();
} catch (e) {
return Response.error(e);
} catch (error) {
if (error?.statusCode === 404) {
return Response.error(
"The request id is invalid or you do not have permission to update it.",
);
}
return Response.error(error);
}
}

View File

@ -61,4 +61,14 @@ export class OrganizationAuthRequestApiService {
false,
);
}
async denyPendingRequest(organizationId: string, requestId: string): Promise<void> {
await this.apiService.send(
"POST",
`/organizations/${organizationId}/auth-requests/${requestId}`,
new AdminAuthRequestUpdateRequest(false),
true,
false,
);
}
}

View File

@ -85,6 +85,10 @@ export class OrganizationAuthRequestService {
);
}
async denyPendingRequest(organizationId: string, requestId: string) {
await this.organizationAuthRequestApiService.denyPendingRequest(organizationId, requestId);
}
/**
* Creates a copy of the user key that has been encrypted with the provided device's public key.
* @param organizationId