From 02dde0c0d35b20d4180193e62233f215295b06ea Mon Sep 17 00:00:00 2001 From: Oscar Hinton Date: Thu, 15 Feb 2024 22:25:53 +0100 Subject: [PATCH] [PM-6328] Checkmarx - Resolve warnings (#7941) --- .../src/auth/popup/register.component.html | 4 ++-- apps/browser/src/autofill/notification/bar.html | 2 +- .../popup/settings/autofill.component.html | 8 ++------ .../private-mode-warning.component.html | 2 +- .../popup/generator/generator.component.html | 2 +- .../components/vault/add-edit.component.html | 2 +- apps/desktop/src/auth/register.component.html | 4 ++-- .../manage/user-confirm.component.html | 2 +- .../components/bulk/bulk-confirm.component.html | 6 +++++- .../member-dialog/member-dialog.component.html | 8 ++++---- .../settings/account.component.html | 4 ++-- .../migrate-legacy-encryption.component.html | 2 +- .../app/auth/recover-two-factor.component.html | 2 +- .../register-form/register-form.component.html | 4 ++-- .../auth/settings/change-password.component.html | 2 +- .../emergency-access-confirm.component.html | 2 +- .../emergency-access-add-edit.component.html | 2 +- .../emergency-access.component.html | 2 +- .../change-kdf/change-kdf.component.html | 4 ++-- .../two-factor-authenticator.component.html | 6 +++--- .../billing/individual/premium.component.html | 2 +- .../individual/user-subscription.component.html | 2 +- .../download-license.component.html | 2 +- ...nization-subscription-selfhost.component.html | 6 +++--- .../shared/billing-history.component.html | 4 ++-- .../app/billing/shared/payment.component.html | 2 +- .../app/layouts/header/web-header.component.html | 9 +++++++-- apps/web/src/app/layouts/navbar.component.html | 4 ++-- .../product-switcher-content.component.html | 2 +- .../src/app/settings/preferences.component.html | 4 ++-- .../account-fingerprint.component.html | 2 +- apps/web/src/app/tools/generator.component.html | 2 +- .../inactive-two-factor-report.component.html | 2 +- .../web/src/app/tools/send/access.component.html | 11 ++++------- .../vault-items/vault-cipher-row.component.html | 1 + .../add-edit-custom-fields.component.html | 2 +- .../individual-vault/add-edit.component.html | 4 ++-- .../individual-vault/attachments.component.html | 2 +- .../components/vault-filter.component.html | 2 +- .../vault/individual-vault/vault.component.html | 2 +- .../policies/activate-autofill.component.html | 2 +- .../manage/user-add-edit.component.html | 2 +- .../bit-web/src/app/auth/sso/sso.component.html | 2 +- .../overview/overview.component.html | 10 +++++++--- .../fingerprint-dialog.component.html | 2 +- .../services/web-crypto-function.service.ts | 2 +- libs/components/src/avatar/avatar.component.ts | 3 +++ libs/components/src/stories/introduction.mdx | 10 ++++++++-- .../src/components/import.component.html | 16 ++++++++-------- 49 files changed, 101 insertions(+), 85 deletions(-) diff --git a/apps/browser/src/auth/popup/register.component.html b/apps/browser/src/auth/popup/register.component.html index 619f7b64ab..e2f4f2e7d1 100644 --- a/apps/browser/src/auth/popup/register.component.html +++ b/apps/browser/src/auth/popup/register.component.html @@ -132,11 +132,11 @@ diff --git a/apps/browser/src/autofill/notification/bar.html b/apps/browser/src/autofill/notification/bar.html index e03ea91509..057e4273bc 100644 --- a/apps/browser/src/autofill/notification/bar.html +++ b/apps/browser/src/autofill/notification/bar.html @@ -8,7 +8,7 @@
diff --git a/apps/browser/src/autofill/popup/settings/autofill.component.html b/apps/browser/src/autofill/popup/settings/autofill.component.html index 587d6860c0..56c67fba09 100644 --- a/apps/browser/src/autofill/popup/settings/autofill.component.html +++ b/apps/browser/src/autofill/popup/settings/autofill.component.html @@ -67,7 +67,7 @@ [attr.href]="disablePasswordManagerLink" (click)="openDisablePasswordManagerLink($event)" target="_blank" - rel="noopener noreferrer" + rel="noreferrer" > {{ "turnOffBrowserBuiltInPasswordManagerSettingsLink" | i18n }} @@ -90,11 +90,7 @@ {{ "enableAutoFillOnPageLoadDesc" | i18n }} {{ "warning" | i18n }}: {{ "experimentalFeature" | i18n }} - + {{ "learnMoreAboutAutofill" | i18n }}. {{ "privateModeWarning" | i18n }} - {{ + {{ "learnMore" | i18n }} diff --git a/apps/browser/src/tools/popup/generator/generator.component.html b/apps/browser/src/tools/popup/generator/generator.component.html index fc102c0112..4c39c22b48 100644 --- a/apps/browser/src/tools/popup/generator/generator.component.html +++ b/apps/browser/src/tools/popup/generator/generator.component.html @@ -309,7 +309,7 @@ diff --git a/apps/browser/src/vault/popup/components/vault/add-edit.component.html b/apps/browser/src/vault/popup/components/vault/add-edit.component.html index 4fbdac5cbf..7aeddba7d2 100644 --- a/apps/browser/src/vault/popup/components/vault/add-edit.component.html +++ b/apps/browser/src/vault/popup/components/vault/add-edit.component.html @@ -657,7 +657,7 @@ {{ "passwordPrompt" | i18n }} diff --git a/apps/desktop/src/auth/register.component.html b/apps/desktop/src/auth/register.component.html index fb4ec30d40..9f76b9b2a4 100644 --- a/apps/desktop/src/auth/register.component.html +++ b/apps/desktop/src/auth/register.component.html @@ -129,11 +129,11 @@ {{ + {{ "termsOfService" | i18n }}, - {{ + {{ "privacyPolicy" | i18n }} diff --git a/apps/web/src/app/admin-console/organizations/manage/user-confirm.component.html b/apps/web/src/app/admin-console/organizations/manage/user-confirm.component.html index 1ee616f8bd..7762067784 100644 --- a/apps/web/src/app/admin-console/organizations/manage/user-confirm.component.html +++ b/apps/web/src/app/admin-console/organizations/manage/user-confirm.component.html @@ -18,7 +18,7 @@

{{ "fingerprintEnsureIntegrityVerify" | i18n }} - + {{ "learnMore" | i18n }}

diff --git a/apps/web/src/app/admin-console/organizations/members/components/bulk/bulk-confirm.component.html b/apps/web/src/app/admin-console/organizations/members/components/bulk/bulk-confirm.component.html index 27bb77df17..7f539f098b 100644 --- a/apps/web/src/app/admin-console/organizations/members/components/bulk/bulk-confirm.component.html +++ b/apps/web/src/app/admin-console/organizations/members/components/bulk/bulk-confirm.component.html @@ -28,7 +28,11 @@

{{ "fingerprintEnsureIntegrityVerify" | i18n }} - + {{ "learnMore" | i18n }}

diff --git a/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.html b/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.html index 82cce8c497..27a3f9fc66 100644 --- a/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.html +++ b/apps/web/src/app/admin-console/organizations/members/components/member-dialog/member-dialog.component.html @@ -37,7 +37,7 @@ {{ "memberRole" | i18n }} @@ -123,7 +123,7 @@
{{ "customDescNonEnterpriseStart" | i18n - }}{{ + }}{{ "customDescNonEnterpriseLink" | i18n }}{{ "customDescNonEnterpriseEnd" | i18n }} @@ -370,7 +370,7 @@ {{ "secretsManager" | i18n }} @@ -415,7 +415,7 @@ {{ "accessAllCollectionsDesc" | i18n }} diff --git a/apps/web/src/app/admin-console/organizations/settings/account.component.html b/apps/web/src/app/admin-console/organizations/settings/account.component.html index 0491ef8199..464a7ae850 100644 --- a/apps/web/src/app/admin-console/organizations/settings/account.component.html +++ b/apps/web/src/app/admin-console/organizations/settings/account.component.html @@ -41,7 +41,7 @@

{{ "apiKey" | i18n }}

{{ "apiKeyDesc" | i18n }} - + {{ "learnMore" | i18n }}

@@ -62,7 +62,7 @@

{{ "collectionEnhancementsDesc" | i18n }} - + {{ "collectionEnhancementsLearnMore" | i18n }}

diff --git a/apps/web/src/app/auth/migrate-encryption/migrate-legacy-encryption.component.html b/apps/web/src/app/auth/migrate-encryption/migrate-legacy-encryption.component.html index 2fdb4711cd..7ed1efeb46 100644 --- a/apps/web/src/app/auth/migrate-encryption/migrate-legacy-encryption.component.html +++ b/apps/web/src/app/auth/migrate-encryption/migrate-legacy-encryption.component.html @@ -10,7 +10,7 @@ {{ "learnMore" | i18n }}

diff --git a/apps/web/src/app/auth/recover-two-factor.component.html b/apps/web/src/app/auth/recover-two-factor.component.html index 744ce3dae1..11d281b742 100644 --- a/apps/web/src/app/auth/recover-two-factor.component.html +++ b/apps/web/src/app/auth/recover-two-factor.component.html @@ -9,7 +9,7 @@ {{ "learnMore" | i18n }}

diff --git a/apps/web/src/app/auth/register-form/register-form.component.html b/apps/web/src/app/auth/register-form/register-form.component.html index a646d5e9a7..2e50d69fce 100644 --- a/apps/web/src/app/auth/register-form/register-form.component.html +++ b/apps/web/src/app/auth/register-form/register-form.component.html @@ -115,11 +115,11 @@ {{ "acceptPolicies" | i18n }}
- {{ + {{ "termsOfService" | i18n }}, - {{ + {{ "privacyPolicy" | i18n }} diff --git a/apps/web/src/app/auth/settings/change-password.component.html b/apps/web/src/app/auth/settings/change-password.component.html index 7b89f1ab08..7c3c22b3d7 100644 --- a/apps/web/src/app/auth/settings/change-password.component.html +++ b/apps/web/src/app/auth/settings/change-password.component.html @@ -103,7 +103,7 @@ diff --git a/apps/web/src/app/auth/settings/emergency-access/confirm/emergency-access-confirm.component.html b/apps/web/src/app/auth/settings/emergency-access/confirm/emergency-access-confirm.component.html index 1ee616f8bd..7762067784 100644 --- a/apps/web/src/app/auth/settings/emergency-access/confirm/emergency-access-confirm.component.html +++ b/apps/web/src/app/auth/settings/emergency-access/confirm/emergency-access-confirm.component.html @@ -18,7 +18,7 @@

{{ "fingerprintEnsureIntegrityVerify" | i18n }} - + {{ "learnMore" | i18n }}

diff --git a/apps/web/src/app/auth/settings/emergency-access/emergency-access-add-edit.component.html b/apps/web/src/app/auth/settings/emergency-access/emergency-access-add-edit.component.html index b3590f8fb0..43961d6a13 100644 --- a/apps/web/src/app/auth/settings/emergency-access/emergency-access-add-edit.component.html +++ b/apps/web/src/app/auth/settings/emergency-access/emergency-access-add-edit.component.html @@ -49,7 +49,7 @@ {{ "userAccess" | i18n }} diff --git a/apps/web/src/app/auth/settings/emergency-access/emergency-access.component.html b/apps/web/src/app/auth/settings/emergency-access/emergency-access.component.html index 4f2bf3b875..4836062104 100644 --- a/apps/web/src/app/auth/settings/emergency-access/emergency-access.component.html +++ b/apps/web/src/app/auth/settings/emergency-access/emergency-access.component.html @@ -3,7 +3,7 @@

{{ "emergencyAccessDesc" | i18n }} - + {{ "learnMore" | i18n }}.

diff --git a/apps/web/src/app/auth/settings/security/change-kdf/change-kdf.component.html b/apps/web/src/app/auth/settings/security/change-kdf/change-kdf.component.html index 5ffe3a5f19..9b16c446be 100644 --- a/apps/web/src/app/auth/settings/security/change-kdf/change-kdf.component.html +++ b/apps/web/src/app/auth/settings/security/change-kdf/change-kdf.component.html @@ -11,7 +11,7 @@ class="ml-auto" href="https://bitwarden.com/help/kdf-algorithms" target="_blank" - rel="noopener" + rel="noreferrer" appA11yTitle="{{ 'learnMore' | i18n }}" > @@ -49,7 +49,7 @@ class="ml-auto" href="https://bitwarden.com/help/what-encryption-is-used/#changing-kdf-iterations" target="_blank" - rel="noopener" + rel="noreferrer" appA11yTitle="{{ 'learnMore' | i18n }}" > diff --git a/apps/web/src/app/auth/settings/two-factor-authenticator.component.html b/apps/web/src/app/auth/settings/two-factor-authenticator.component.html index 748c6e0bd6..33bf4fb130 100644 --- a/apps/web/src/app/auth/settings/two-factor-authenticator.component.html +++ b/apps/web/src/app/auth/settings/two-factor-authenticator.component.html @@ -51,7 +51,7 @@ Authy @@ -60,7 +60,7 @@ Authy @@ -69,7 +69,7 @@ Microsoft Authenticator diff --git a/apps/web/src/app/billing/individual/premium.component.html b/apps/web/src/app/billing/individual/premium.component.html index f688d6af88..2302c0472b 100644 --- a/apps/web/src/app/billing/individual/premium.component.html +++ b/apps/web/src/app/billing/individual/premium.component.html @@ -56,7 +56,7 @@ bitButton href="{{ this.cloudWebVaultUrl }}/#/settings/subscription/premium" target="_blank" - rel="noopener" + rel="noreferrer" buttonType="secondary" *ngIf="selfHosted" > diff --git a/apps/web/src/app/billing/individual/user-subscription.component.html b/apps/web/src/app/billing/individual/user-subscription.component.html index 79a694e42a..2fd831c71c 100644 --- a/apps/web/src/app/billing/individual/user-subscription.component.html +++ b/apps/web/src/app/billing/individual/user-subscription.component.html @@ -104,7 +104,7 @@ buttonType="secondary" href="{{ this.cloudWebVaultUrl }}/#/settings/subscription" target="_blank" - rel="noopener" + rel="noreferrer" > {{ "launchCloudSubscription" | i18n }} diff --git a/apps/web/src/app/billing/organizations/download-license.component.html b/apps/web/src/app/billing/organizations/download-license.component.html index c082a3ab5e..0997462ce9 100644 --- a/apps/web/src/app/billing/organizations/download-license.component.html +++ b/apps/web/src/app/billing/organizations/download-license.component.html @@ -11,7 +11,7 @@ diff --git a/apps/web/src/app/billing/organizations/organization-subscription-selfhost.component.html b/apps/web/src/app/billing/organizations/organization-subscription-selfhost.component.html index de63f5e349..4395748aac 100644 --- a/apps/web/src/app/billing/organizations/organization-subscription-selfhost.component.html +++ b/apps/web/src/app/billing/organizations/organization-subscription-selfhost.component.html @@ -40,7 +40,7 @@ href="https://bitwarden.com/help/licensing-on-premise/#update-organization-license" target="_blank" [appA11yTitle]="'licensePaidFeaturesHelp' | i18n" - rel="noopener" + rel="noreferrer" > {{ "licensePaidFeaturesHelp" | i18n }} @@ -68,7 +68,7 @@ buttonType="secondary" href="{{ this.cloudWebVaultUrl }}" target="_blank" - rel="noopener" + rel="noreferrer" > {{ "launchCloudSubscription" | i18n }} @@ -88,7 +88,7 @@ {{ "billingSyncHelp" | i18n }} diff --git a/apps/web/src/app/billing/shared/billing-history.component.html b/apps/web/src/app/billing/shared/billing-history.component.html index 27fd038a3b..56a8a990d4 100644 --- a/apps/web/src/app/billing/shared/billing-history.component.html +++ b/apps/web/src/app/billing/shared/billing-history.component.html @@ -8,13 +8,13 @@ - + {{ "invoiceNumber" | i18n: i.number }} diff --git a/apps/web/src/app/billing/shared/payment.component.html b/apps/web/src/app/billing/shared/payment.component.html index 5681341406..db6f4f311b 100644 --- a/apps/web/src/app/billing/shared/payment.component.html +++ b/apps/web/src/app/billing/shared/payment.component.html @@ -83,7 +83,7 @@ href="https://www.cvvnumber.com/cvv.html" tabindex="-1" target="_blank" - rel="noopener noreferrer" + rel="noreferrer" class="ml-auto" appA11yTitle="{{ 'learnMore' | i18n }}" > diff --git a/apps/web/src/app/layouts/header/web-header.component.html b/apps/web/src/app/layouts/header/web-header.component.html index d2eb43a696..ff2a870bef 100644 --- a/apps/web/src/app/layouts/header/web-header.component.html +++ b/apps/web/src/app/layouts/header/web-header.component.html @@ -61,11 +61,16 @@ {{ "accountSettings" | i18n }} - + {{ "getHelp" | i18n }} - + {{ "getApps" | i18n }} diff --git a/apps/web/src/app/layouts/navbar.component.html b/apps/web/src/app/layouts/navbar.component.html index 72dd17d0dc..264818a98e 100644 --- a/apps/web/src/app/layouts/navbar.component.html +++ b/apps/web/src/app/layouts/navbar.component.html @@ -75,11 +75,11 @@ {{ "accountSettings" | i18n }} - + {{ "getHelp" | i18n }} - + {{ "getApps" | i18n }} diff --git a/apps/web/src/app/layouts/product-switcher/product-switcher-content.component.html b/apps/web/src/app/layouts/product-switcher/product-switcher-content.component.html index 293c024ac4..9068f9c071 100644 --- a/apps/web/src/app/layouts/product-switcher/product-switcher-content.component.html +++ b/apps/web/src/app/layouts/product-switcher/product-switcher-content.component.html @@ -38,7 +38,7 @@ bitLink [href]="product.marketingRoute" target="_blank" - rel="noopener noreferrer" + rel="noreferrer" > {{ product.name }} diff --git a/apps/web/src/app/settings/preferences.component.html b/apps/web/src/app/settings/preferences.component.html index 83d6ebc4b5..7789785f9b 100644 --- a/apps/web/src/app/settings/preferences.component.html +++ b/apps/web/src/app/settings/preferences.component.html @@ -75,7 +75,7 @@ class="ml-auto" href="https://bitwarden.com/help/localization/" target="_blank" - rel="noopener" + rel="noreferrer" appA11yTitle="{{ 'learnMore' | i18n }}" > @@ -103,7 +103,7 @@ diff --git a/apps/web/src/app/shared/components/account-fingerprint/account-fingerprint.component.html b/apps/web/src/app/shared/components/account-fingerprint/account-fingerprint.component.html index 035e5d33af..fd89876860 100644 --- a/apps/web/src/app/shared/components/account-fingerprint/account-fingerprint.component.html +++ b/apps/web/src/app/shared/components/account-fingerprint/account-fingerprint.component.html @@ -5,7 +5,7 @@ diff --git a/apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.html b/apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.html index 2284240386..6b175b1b9c 100644 --- a/apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.html +++ b/apps/web/src/app/tools/reports/pages/inactive-two-factor-report.component.html @@ -74,7 +74,7 @@ bitBadge href="{{ cipherDocs.get(c.id) }}" target="_blank" - rel="noopener" + rel="noreferrer" *ngIf="cipherDocs.has(c.id)" > {{ "instructions" | i18n }} {{ "viewSendHiddenEmailWarning" | i18n }} - {{ "learnMore" | i18n }}{{ + "learnMore" | i18n + }}.
Bitwarden Send {{ "sendAccessTaglineOr" | i18n }} diff --git a/apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html b/apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html index 945c644fb1..5ddabf0557 100644 --- a/apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html +++ b/apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html @@ -96,6 +96,7 @@ type="button" [href]="cipher.login.launchUri" target="_blank" + rel="noreferrer" > {{ "launch" | i18n }} diff --git a/apps/web/src/app/vault/individual-vault/add-edit-custom-fields.component.html b/apps/web/src/app/vault/individual-vault/add-edit-custom-fields.component.html index c524f34641..dfba89e962 100644 --- a/apps/web/src/app/vault/individual-vault/add-edit-custom-fields.component.html +++ b/apps/web/src/app/vault/individual-vault/add-edit-custom-fields.component.html @@ -15,7 +15,7 @@ class="ml-auto" href="https://bitwarden.com/help/custom-fields/" target="_blank" - rel="noopener" + rel="noreferrer" appA11yTitle="{{ 'learnMore' | i18n }}" > diff --git a/apps/web/src/app/vault/individual-vault/add-edit.component.html b/apps/web/src/app/vault/individual-vault/add-edit.component.html index d01f2fa22b..12b41f181d 100644 --- a/apps/web/src/app/vault/individual-vault/add-edit.component.html +++ b/apps/web/src/app/vault/individual-vault/add-edit.component.html @@ -372,7 +372,7 @@ class="ml-auto" href="https://bitwarden.com/help/uri-match-detection/" target="_blank" - rel="noopener" + rel="noreferrer" appA11yTitle="{{ 'learnMore' | i18n }}" > @@ -940,7 +940,7 @@ }} diff --git a/apps/web/src/app/vault/individual-vault/attachments.component.html b/apps/web/src/app/vault/individual-vault/attachments.component.html index a43f3406b1..5a2c72451e 100644 --- a/apps/web/src/app/vault/individual-vault/attachments.component.html +++ b/apps/web/src/app/vault/individual-vault/attachments.component.html @@ -44,7 +44,7 @@ diff --git a/apps/web/src/app/vault/individual-vault/vault.component.html b/apps/web/src/app/vault/individual-vault/vault.component.html index 0e7b7afbdb..df00979f71 100644 --- a/apps/web/src/app/vault/individual-vault/vault.component.html +++ b/apps/web/src/app/vault/individual-vault/vault.component.html @@ -101,7 +101,7 @@ class="btn btn-block btn-outline-secondary" target="_blank" href="https://browser-update.org/update-browser.html" - rel="noopener" + rel="noreferrer" > {{ "updateBrowser" | i18n }} diff --git a/bitwarden_license/bit-web/src/app/admin-console/policies/activate-autofill.component.html b/bitwarden_license/bit-web/src/app/admin-console/policies/activate-autofill.component.html index cbff9e5e68..9f08e98dae 100644 --- a/bitwarden_license/bit-web/src/app/admin-console/policies/activate-autofill.component.html +++ b/bitwarden_license/bit-web/src/app/admin-console/policies/activate-autofill.component.html @@ -1,6 +1,6 @@ {{ "experimentalFeature" | i18n }} - {{ + {{ "learnMoreAboutAutofill" | i18n }} diff --git a/bitwarden_license/bit-web/src/app/admin-console/providers/manage/user-add-edit.component.html b/bitwarden_license/bit-web/src/app/admin-console/providers/manage/user-add-edit.component.html index 24be5ca2a7..11f6ae07d8 100644 --- a/bitwarden_license/bit-web/src/app/admin-console/providers/manage/user-add-edit.component.html +++ b/bitwarden_license/bit-web/src/app/admin-console/providers/manage/user-add-edit.component.html @@ -50,7 +50,7 @@ {{ "userType" | i18n }} diff --git a/bitwarden_license/bit-web/src/app/auth/sso/sso.component.html b/bitwarden_license/bit-web/src/app/auth/sso/sso.component.html index 816d09f90b..47471dc965 100644 --- a/bitwarden_license/bit-web/src/app/auth/sso/sso.component.html +++ b/bitwarden_license/bit-web/src/app/auth/sso/sso.component.html @@ -60,7 +60,7 @@ {{ "keyConnector" | i18n }} diff --git a/bitwarden_license/bit-web/src/app/secrets-manager/overview/overview.component.html b/bitwarden_license/bit-web/src/app/secrets-manager/overview/overview.component.html index 6dec4f6f90..04d705af23 100644 --- a/bitwarden_license/bit-web/src/app/secrets-manager/overview/overview.component.html +++ b/bitwarden_license/bit-web/src/app/secrets-manager/overview/overview.component.html @@ -12,9 +12,13 @@ > {{ "downloadThe" | i18n }} - {{ - "smCLI" | i18n - }} + {{ "smCLI" | i18n }} diff --git a/libs/common/src/platform/services/web-crypto-function.service.ts b/libs/common/src/platform/services/web-crypto-function.service.ts index e3ac0c2cf4..fb0bf33b64 100644 --- a/libs/common/src/platform/services/web-crypto-function.service.ts +++ b/libs/common/src/platform/services/web-crypto-function.service.ts @@ -139,7 +139,7 @@ export class WebCryptoFunctionService implements CryptoFunctionService { algorithm: "sha1" | "sha256" | "sha512" | "md5", ): Promise { if (algorithm === "md5") { - const md = algorithm === "md5" ? forge.md.md5.create() : forge.md.sha1.create(); + const md = forge.md.md5.create(); const valueBytes = this.toByteString(value); md.update(valueBytes, "raw"); return Utils.fromByteStringToArray(md.digest().data); diff --git a/libs/components/src/avatar/avatar.component.ts b/libs/components/src/avatar/avatar.component.ts index 6d75511adc..429e9fc0c6 100644 --- a/libs/components/src/avatar/avatar.component.ts +++ b/libs/components/src/avatar/avatar.component.ts @@ -75,6 +75,8 @@ export class AvatarComponent implements OnChanges { svg.appendChild(charObj); const html = window.document.createElement("div").appendChild(svg).outerHTML; const svgHtml = window.btoa(unescape(encodeURIComponent(html))); + + // This is safe because the only user provided value, chars is set using `textContent` this.src = this.sanitizer.bypassSecurityTrustResourceUrl( "data:image/svg+xml;base64," + svgHtml, ); @@ -117,6 +119,7 @@ export class AvatarComponent implements OnChanges { '"Open Sans","Helvetica Neue",Helvetica,Arial,' + 'sans-serif,"Apple Color Emoji","Segoe UI Emoji","Segoe UI Symbol"', ); + // Warning do not use innerHTML here, characters are user provided textTag.textContent = character; textTag.style.fontWeight = this.svgFontWeight.toString(); textTag.style.fontSize = this.svgFontSize + "px"; diff --git a/libs/components/src/stories/introduction.mdx b/libs/components/src/stories/introduction.mdx index 2ca2ebc82b..f533923150 100644 --- a/libs/components/src/stories/introduction.mdx +++ b/libs/components/src/stories/introduction.mdx @@ -104,6 +104,7 @@ component library and the other clients will follow once this work is completed. className="link-item" href="https://storybook.js.org/docs/react/get-started/setup#configure-storybook-for-your-stack" target="_blank" + rel="noreferrer" > Data @@ -115,13 +116,18 @@ component library and the other clients will follow once this work is completed.
Learn
- + Storybook documentation Configure, customize, and extend - + In-depth guides Best practices from leading teams diff --git a/libs/importer/src/components/import.component.html b/libs/importer/src/components/import.component.html index 871bd7f22d..6c24b80f92 100644 --- a/libs/importer/src/components/import.component.html +++ b/libs/importer/src/components/import.component.html @@ -7,7 +7,7 @@ >{{ "importDestination" | i18n }} @@ -78,14 +78,14 @@ See detailed instructions on our help site at - + https://bitwarden.com/help/export-your-data/

{{ "seeDetailedInstructions" | i18n }} - + https://bitwarden.com/help/import-from-lastpass/

@@ -153,19 +153,19 @@ The process is exactly the same as importing from Google Chrome. See detailed instructions on our help site at - + https://bitwarden.com/help/import-from-chrome/ See detailed instructions on our help site at - + https://bitwarden.com/help/import-from-firefox/. See detailed instructions on our help site at - + https://bitwarden.com/help/import-from-safari/. @@ -178,7 +178,7 @@ " > See detailed instructions on our help site at - + https://bitwarden.com/help/import-from-1password/. @@ -264,7 +264,7 @@ Make sure you have python-keyring and python-gnomekeyring installed. Save the - GNOME Keyring Import/Export python script to your desktop as pw_helper.py. Open terminal and run