Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-10 09:59:48 +01:00
Code Issues Projects Releases Wiki Activity

[SM-410] Fix boolean custom fields not working (#4386)

Browse Source 
* Fix boolean custom fields not working
This commit is contained in:
Oscar Hinton 2023-01-05 16:50:19 +01:00 committed by GitHub
parent d3c780e079
commit 049940d04b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/browser/src/popup/vault/add-edit-custom-fields.component.html
View File

@ -81,8 +81,8 @@
[(ngModel)]="f.value" [(ngModel)]="f.value"
*ngIf="f.type === fieldType.Boolean" *ngIf="f.type === fieldType.Boolean"
appTrueFalseValue appTrueFalseValue
[trueValue]="true" trueValue="true"
[falseValue]="false" falseValue="false"
attr.aria-describedby="fieldName{{ i }}" attr.aria-describedby="fieldName{{ i }}"
[readonly]="!cipher.edit && editMode" [readonly]="!cipher.edit && editMode"
/> />

4
apps/desktop/src/app/vault/add-edit-custom-fields.component.html
View File

@ -79,8 +79,8 @@
[(ngModel)]="f.value" [(ngModel)]="f.value"
*ngIf="f.type === fieldType.Boolean" *ngIf="f.type === fieldType.Boolean"
appTrueFalseValue appTrueFalseValue
[trueValue]="true" trueValue="true"
[falseValue]="false" falseValue="false"
attr.aria-describedby="fieldName{{ i }}" attr.aria-describedby="fieldName{{ i }}"
[readonly]="!cipher.edit && editMode" [readonly]="!cipher.edit && editMode"
/> />

4
apps/web/src/app/vault/add-edit-custom-fields.component.html
View File

@ -122,8 +122,8 @@
[(ngModel)]="f.value" [(ngModel)]="f.value"
*ngIf="f.type === fieldType.Boolean" *ngIf="f.type === fieldType.Boolean"
appTrueFalseValue appTrueFalseValue
[trueValue]="true" trueValue="true"
[falseValue]="false" falseValue="false"
[disabled]="cipher.isDeleted || viewOnly" [disabled]="cipher.isDeleted || viewOnly"
attr.aria-describedby="fieldName{{ i }}" attr.aria-describedby="fieldName{{ i }}"
/> />

4
libs/angular/src/directives/true-false-value.directive.ts
View File

@ -13,8 +13,8 @@ import { ControlValueAccessor, NG_VALUE_ACCESSOR } from "@angular/forms";
], ],
}) })
export class TrueFalseValueDirective implements ControlValueAccessor { export class TrueFalseValueDirective implements ControlValueAccessor {
@Input() trueValue = true; @Input() trueValue: boolean | string = true;
@Input() falseValue = false; @Input() falseValue: boolean | string = false;
constructor(private elementRef: ElementRef, private renderer: Renderer2) {} constructor(private elementRef: ElementRef, private renderer: Renderer2) {}