Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-14 10:26:19 +01:00
Code Issues Projects Releases Wiki Activity

do not do browser extension permission check if the Show autofill suggestions setting is being turned off (#11889)

Browse Source
This commit is contained in:
Jonathan Prusik 2024-11-07 10:38:49 -05:00 committed by GitHub
parent faf7e3d315
commit 05a79d58bb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/browser/src/autofill/popup/settings/autofill.component.ts
View File

@ -219,8 +219,12 @@ export class AutofillComponent implements OnInit {
: AutofillOverlayVisibility.Off; : AutofillOverlayVisibility.Off;
await this.autofillSettingsService.setInlineMenuVisibility(newInlineMenuVisibilityValue); await this.autofillSettingsService.setInlineMenuVisibility(newInlineMenuVisibilityValue);
// No need to initiate browser permission request if a feature is being turned off
if (newInlineMenuVisibilityValue !== AutofillOverlayVisibility.Off) {
await this.requestPrivacyPermission(); await this.requestPrivacyPermission();
} }
}
async updateAutofillOnPageLoad() { async updateAutofillOnPageLoad() {
await this.autofillSettingsService.setAutofillOnPageLoad(this.enableAutofillOnPageLoad); await this.autofillSettingsService.setAutofillOnPageLoad(this.enableAutofillOnPageLoad);