From 06e88a38e0e3e366e313bd20086122de1ae0dd4d Mon Sep 17 00:00:00 2001
From: "Patrick H. Lauke" <redux@splintered.co.uk>
Date: Tue, 13 Sep 2022 19:38:38 +0100
Subject: [PATCH] Make all item fields (except linked fields) draggable (#3321)

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
---
 .../vault/view-custom-fields.component.html   |   9 +-
 .../src/popup/vault/view.component.html       | 147 +++++++++++++++---
 .../vault/view-custom-fields.component.html   |   9 +-
 .../desktop/src/app/vault/view.component.html | 139 ++++++++++++++---
 .../view-custom-fields.component.ts           |   4 +
 5 files changed, 266 insertions(+), 42 deletions(-)

diff --git a/apps/browser/src/popup/vault/view-custom-fields.component.html b/apps/browser/src/popup/vault/view-custom-fields.component.html
index ebedd30776..4fbca28734 100644
--- a/apps/browser/src/popup/vault/view-custom-fields.component.html
+++ b/apps/browser/src/popup/vault/view-custom-fields.component.html
@@ -5,7 +5,14 @@
   <div class="box-content">
     <div class="box-content-row box-content-row-flex" *ngFor="let field of cipher.fields">
       <div class="row-main">
-        <span class="row-label">{{ field.name }}</span>
+        <span
+          *ngIf="field.type != fieldType.Linked"
+          class="row-label draggable"
+          draggable="true"
+          (dragstart)="setTextDataOnDrag($event, field.value)"
+          >{{ field.name }}</span
+        >
+        <span *ngIf="field.type === fieldType.Linked" class="row-label">{{ field.name }}</span>
         <div *ngIf="field.type === fieldType.Text">
           {{ field.value || "&nbsp;" }}
         </div>
diff --git a/apps/browser/src/popup/vault/view.component.html b/apps/browser/src/popup/vault/view.component.html
index d8bf6da734..0b5d0fb152 100644
--- a/apps/browser/src/popup/vault/view.component.html
+++ b/apps/browser/src/popup/vault/view.component.html
@@ -18,7 +18,13 @@
     </h2>
     <div class="box-content">
       <div class="box-content-row">
-        <label for="name">{{ "name" | i18n }}</label>
+        <label
+          for="name"
+          class="draggable"
+          draggable="true"
+          (dragstart)="setTextDataOnDrag($event, cipher.name)"
+          >{{ "name" | i18n }}</label
+        >
         <input id="name" type="text" [value]="cipher.name" readonly aria-readonly="true" />
       </div>
       <!-- Login -->
@@ -192,12 +198,22 @@
       <!-- Card -->
       <div *ngIf="cipher.card">
         <div class="box-content-row" *ngIf="cipher.card.cardholderName">
-          <span class="row-label">{{ "cardholderName" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.card.cardholderName)"
+            >{{ "cardholderName" | i18n }}</span
+          >
           {{ cipher.card.cardholderName }}
         </div>
         <div class="box-content-row box-content-row-flex" *ngIf="cipher.card.number">
           <div class="row-main">
-            <span class="row-label">{{ "number" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.card.number)"
+              >{{ "number" | i18n }}</span
+            >
             <span [hidden]="showCardNumber" class="monospaced">{{
               cipher.card.maskedNumber | creditCardNumber: cipher.card.brand
             }}</span>
@@ -233,16 +249,31 @@
           </div>
         </div>
         <div class="box-content-row" *ngIf="cipher.card.brand">
-          <span class="row-label">{{ "brand" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.card.brand)"
+            >{{ "brand" | i18n }}</span
+          >
           {{ cipher.card.brand }}
         </div>
         <div class="box-content-row" *ngIf="cipher.card.expiration">
-          <span class="row-label">{{ "expiration" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.card.expiration)"
+            >{{ "expiration" | i18n }}</span
+          >
           {{ cipher.card.expiration }}
         </div>
         <div class="box-content-row box-content-row-flex" *ngIf="cipher.card.code">
           <div class="row-main">
-            <span class="row-label">{{ "securityCode" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.card.code)"
+              >{{ "securityCode" | i18n }}</span
+            >
             <span [hidden]="showCardCode" class="monospaced">{{ cipher.card.maskedCode }}</span>
             <span [hidden]="!showCardCode" class="monospaced">{{ cipher.card.code }}</span>
           </div>
@@ -277,42 +308,98 @@
       <!-- Identity -->
       <div *ngIf="cipher.identity">
         <div class="box-content-row" *ngIf="cipher.identity.fullName">
-          <span class="row-label">{{ "identityName" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.identity.fullName)"
+            >{{ "identityName" | i18n }}</span
+          >
           {{ cipher.identity.fullName }}
         </div>
         <div class="box-content-row" *ngIf="cipher.identity.username">
-          <span class="row-label">{{ "username" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.identity.username)"
+            >{{ "username" | i18n }}</span
+          >
           {{ cipher.identity.username }}
         </div>
         <div class="box-content-row" *ngIf="cipher.identity.company">
-          <span class="row-label">{{ "company" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.identity.company)"
+            >{{ "company" | i18n }}</span
+          >
           {{ cipher.identity.company }}
         </div>
         <div class="box-content-row" *ngIf="cipher.identity.ssn">
-          <span class="row-label">{{ "ssn" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.identity.ssn)"
+            >{{ "ssn" | i18n }}</span
+          >
           {{ cipher.identity.ssn }}
         </div>
         <div class="box-content-row" *ngIf="cipher.identity.passportNumber">
-          <span class="row-label">{{ "passportNumber" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.identity.passportNumber)"
+            >{{ "passportNumber" | i18n }}</span
+          >
           {{ cipher.identity.passportNumber }}
         </div>
         <div class="box-content-row" *ngIf="cipher.identity.licenseNumber">
-          <span class="row-label">{{ "licenseNumber" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.identity.licenseNumber)"
+            >{{ "licenseNumber" | i18n }}</span
+          >
           {{ cipher.identity.licenseNumber }}
         </div>
         <div class="box-content-row" *ngIf="cipher.identity.email">
-          <span class="row-label">{{ "email" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.identity.email)"
+            >{{ "email" | i18n }}</span
+          >
           {{ cipher.identity.email }}
         </div>
         <div class="box-content-row" *ngIf="cipher.identity.phone">
-          <span class="row-label">{{ "phone" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.identity.phone)"
+            >{{ "phone" | i18n }}</span
+          >
           {{ cipher.identity.phone }}
         </div>
         <div
           class="box-content-row"
           *ngIf="cipher.identity.address1 || cipher.identity.city || cipher.identity.country"
         >
-          <span class="row-label">{{ "address" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="
+              setTextDataOnDrag(
+                $event,
+                (cipher.identity.address1 ? cipher.identity.address1 + '\n' : '') +
+                  (cipher.identity.address2 ? cipher.identity.address2 + '\n' : '') +
+                  (cipher.identity.address3 ? cipher.identity.address3 + '\n' : '') +
+                  (cipher.identity.fullAddressPart2
+                    ? cipher.identity.fullAddressPart2 + '\n'
+                    : '') +
+                  (cipher.identity.country ? cipher.identity.country : '')
+              )
+            "
+            >{{ "address" | i18n }}</span
+          >
           <div *ngIf="cipher.identity.address1">{{ cipher.identity.address1 }}</div>
           <div *ngIf="cipher.identity.address2">{{ cipher.identity.address2 }}</div>
           <div *ngIf="cipher.identity.address3">{{ cipher.identity.address3 }}</div>
@@ -329,12 +416,22 @@
         *ngFor="let u of cipher.login.uris; let i = index"
       >
         <div class="row-main">
-          <label for="hostOrUri{{ i }}" class="row-label" *ngIf="!u.isWebsite">{{
-            "uri" | i18n
-          }}</label>
-          <label for="hostOrUri{{ i }}" class="row-label" *ngIf="u.isWebsite">{{
-            "website" | i18n
-          }}</label>
+          <label
+            for="hostOrUri{{ i }}"
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, u.uri)"
+            *ngIf="!u.isWebsite"
+            >{{ "uri" | i18n }}</label
+          >
+          <label
+            for="hostOrUri{{ i }}"
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, u.uri)"
+            *ngIf="u.isWebsite"
+            >{{ "website" | i18n }}</label
+          >
           <span title="{{ u.uri }}">
             <input
               id="hostOrUri{{ i }}"
@@ -373,7 +470,13 @@
   </div>
   <div class="box" *ngIf="cipher.notes">
     <h2 class="box-header">
-      <label for="notes">{{ "notes" | i18n }}</label>
+      <label
+        for="notes"
+        class="draggable"
+        draggable="true"
+        (dragstart)="setTextDataOnDrag($event, cipher.notes)"
+        >{{ "notes" | i18n }}</label
+      >
     </h2>
     <div class="box-content">
       <div class="box-content-row">
diff --git a/apps/desktop/src/app/vault/view-custom-fields.component.html b/apps/desktop/src/app/vault/view-custom-fields.component.html
index 598c4c0f8d..5f2f110fba 100644
--- a/apps/desktop/src/app/vault/view-custom-fields.component.html
+++ b/apps/desktop/src/app/vault/view-custom-fields.component.html
@@ -5,7 +5,14 @@
   <div class="box-content">
     <div class="box-content-row box-content-row-flex" *ngFor="let field of cipher.fields">
       <div class="row-main">
-        <span class="row-label">{{ field.name }}</span>
+        <span
+          *ngIf="field.type != fieldType.Linked"
+          class="row-label draggable"
+          draggable="true"
+          (dragstart)="setTextDataOnDrag($event, field.value)"
+          >{{ field.name }}</span
+        >
+        <span *ngIf="field.type === fieldType.Linked" class="row-label">{{ field.name }}</span>
         <div *ngIf="field.type === fieldType.Text">
           {{ field.value || "&nbsp;" }}
         </div>
diff --git a/apps/desktop/src/app/vault/view.component.html b/apps/desktop/src/app/vault/view.component.html
index 55da1b8e17..7fdca0b667 100644
--- a/apps/desktop/src/app/vault/view.component.html
+++ b/apps/desktop/src/app/vault/view.component.html
@@ -6,7 +6,12 @@
       </h2>
       <div class="box-content">
         <div class="box-content-row">
-          <span class="row-label">{{ "name" | i18n }}</span>
+          <span
+            class="row-label draggable"
+            draggable="true"
+            (dragstart)="setTextDataOnDrag($event, cipher.name)"
+            >{{ "name" | i18n }}</span
+          >
           {{ cipher.name }}
         </div>
         <!-- Login -->
@@ -152,12 +157,22 @@
         <!-- Card -->
         <div *ngIf="cipher.card">
           <div class="box-content-row" *ngIf="cipher.card.cardholderName">
-            <span class="row-label">{{ "cardholderName" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.card.cardholderName)"
+              >{{ "cardholderName" | i18n }}</span
+            >
             {{ cipher.card.cardholderName }}
           </div>
           <div class="box-content-row box-content-row-flex" *ngIf="cipher.card.number">
             <div class="row-main">
-              <span class="row-label">{{ "number" | i18n }}</span>
+              <span
+                class="row-label draggable"
+                draggable="true"
+                (dragstart)="setTextDataOnDrag($event, cipher.card.number)"
+                >{{ "number" | i18n }}</span
+              >
               <span *ngIf="!showCardNumber" class="monospaced">{{
                 cipher.card.maskedNumber | creditCardNumber: cipher.card.brand
               }}</span>
@@ -192,16 +207,31 @@
             </div>
           </div>
           <div class="box-content-row" *ngIf="cipher.card.brand">
-            <span class="row-label">{{ "brand" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.card.brand)"
+              >{{ "brand" | i18n }}</span
+            >
             {{ cipher.card.brand }}
           </div>
           <div class="box-content-row" *ngIf="cipher.card.expiration">
-            <span class="row-label">{{ "expiration" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.card.expiration)"
+              >{{ "expiration" | i18n }}</span
+            >
             {{ cipher.card.expiration }}
           </div>
           <div class="box-content-row box-content-row-flex" *ngIf="cipher.card.code">
             <div class="row-main">
-              <span class="row-label">{{ "securityCode" | i18n }}</span>
+              <span
+                class="row-label draggable"
+                draggable="true"
+                (dragstart)="setTextDataOnDrag($event, cipher.card.code)"
+                >{{ "securityCode" | i18n }}</span
+              >
               <span *ngIf="!showCardCode" class="monospaced">{{ cipher.card.maskedCode }}</span>
               <span *ngIf="showCardCode" class="monospaced">{{ cipher.card.code }}</span>
             </div>
@@ -235,42 +265,98 @@
         <!-- Identity -->
         <div *ngIf="cipher.identity">
           <div class="box-content-row" *ngIf="cipher.identity.fullName">
-            <span class="row-label">{{ "identityName" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.identity.fullName)"
+              >{{ "identityName" | i18n }}</span
+            >
             {{ cipher.identity.fullName }}
           </div>
           <div class="box-content-row" *ngIf="cipher.identity.username">
-            <span class="row-label">{{ "username" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.identity.username)"
+              >{{ "username" | i18n }}</span
+            >
             {{ cipher.identity.username }}
           </div>
           <div class="box-content-row" *ngIf="cipher.identity.company">
-            <span class="row-label">{{ "company" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.identity.company)"
+              >{{ "company" | i18n }}</span
+            >
             {{ cipher.identity.company }}
           </div>
           <div class="box-content-row" *ngIf="cipher.identity.ssn">
-            <span class="row-label">{{ "ssn" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.identity.ssn)"
+              >{{ "ssn" | i18n }}</span
+            >
             {{ cipher.identity.ssn }}
           </div>
           <div class="box-content-row" *ngIf="cipher.identity.passportNumber">
-            <span class="row-label">{{ "passportNumber" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.identity.passportNumber)"
+              >{{ "passportNumber" | i18n }}</span
+            >
             {{ cipher.identity.passportNumber }}
           </div>
           <div class="box-content-row" *ngIf="cipher.identity.licenseNumber">
-            <span class="row-label">{{ "licenseNumber" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.identity.licenseNumber)"
+              >{{ "licenseNumber" | i18n }}</span
+            >
             {{ cipher.identity.licenseNumber }}
           </div>
           <div class="box-content-row" *ngIf="cipher.identity.email">
-            <span class="row-label">{{ "email" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.identity.email)"
+              >{{ "email" | i18n }}</span
+            >
             {{ cipher.identity.email }}
           </div>
           <div class="box-content-row" *ngIf="cipher.identity.phone">
-            <span class="row-label">{{ "phone" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, cipher.identity.phone)"
+              >{{ "phone" | i18n }}</span
+            >
             {{ cipher.identity.phone }}
           </div>
           <div
             class="box-content-row"
             *ngIf="cipher.identity.address1 || cipher.identity.city || cipher.identity.country"
           >
-            <span class="row-label">{{ "address" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="
+                setTextDataOnDrag(
+                  $event,
+                  (cipher.identity.address1 ? cipher.identity.address1 + '\n' : '') +
+                    (cipher.identity.address2 ? cipher.identity.address2 + '\n' : '') +
+                    (cipher.identity.address3 ? cipher.identity.address3 + '\n' : '') +
+                    (cipher.identity.fullAddressPart2
+                      ? cipher.identity.fullAddressPart2 + '\n'
+                      : '') +
+                    (cipher.identity.country ? cipher.identity.country : '')
+                )
+              "
+              >{{ "address" | i18n }}</span
+            >
             <div *ngIf="cipher.identity.address1">{{ cipher.identity.address1 }}</div>
             <div *ngIf="cipher.identity.address2">{{ cipher.identity.address2 }}</div>
             <div *ngIf="cipher.identity.address3">{{ cipher.identity.address3 }}</div>
@@ -289,8 +375,20 @@
           *ngFor="let u of cipher.login.uris; let i = index"
         >
           <div class="row-main">
-            <span class="row-label" *ngIf="!u.isWebsite">{{ "uri" | i18n }}</span>
-            <span class="row-label" *ngIf="u.isWebsite">{{ "website" | i18n }}</span>
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, u.uri)"
+              *ngIf="!u.isWebsite"
+              >{{ "uri" | i18n }}</span
+            >
+            <span
+              class="row-label draggable"
+              draggable="true"
+              (dragstart)="setTextDataOnDrag($event, u.uri)"
+              *ngIf="u.isWebsite"
+              >{{ "website" | i18n }}</span
+            >
             <span title="{{ u.uri }}">{{ u.hostOrUri }}</span>
           </div>
           <div class="action-buttons">
@@ -319,7 +417,12 @@
     </div>
     <div class="box" *ngIf="cipher.notes">
       <h2 class="box-header">
-        {{ "notes" | i18n }}
+        <span
+          class="draggable"
+          draggable="true"
+          (dragstart)="setTextDataOnDrag($event, cipher.notes)"
+          >{{ "notes" | i18n }}</span
+        >
       </h2>
       <div class="box-content">
         <div class="box-content-row pre-wrap">{{ cipher.notes }}</div>
diff --git a/libs/angular/src/components/view-custom-fields.component.ts b/libs/angular/src/components/view-custom-fields.component.ts
index d1ca8934fa..10a072945a 100644
--- a/libs/angular/src/components/view-custom-fields.component.ts
+++ b/libs/angular/src/components/view-custom-fields.component.ts
@@ -36,4 +36,8 @@ export class ViewCustomFieldsComponent {
 
     field.showCount = !field.showCount;
   }
+
+  setTextDataOnDrag(event: DragEvent, data: string) {
+    event.dataTransfer.setData("text", data);
+  }
 }