From 08c6a302b2009a9f3a5fa37cfd96ab99e8f597f3 Mon Sep 17 00:00:00 2001 From: gbubemismith Date: Wed, 30 Aug 2023 12:56:28 -0400 Subject: [PATCH] fixed pr comments --- .../services/fido2/browser-fido2-user-interface.service.ts | 6 +++--- apps/web/src/app/auth/login/login.component.ts | 5 ----- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/apps/browser/src/services/fido2/browser-fido2-user-interface.service.ts b/apps/browser/src/services/fido2/browser-fido2-user-interface.service.ts index 3aa6bc8e65..91c17ee285 100644 --- a/apps/browser/src/services/fido2/browser-fido2-user-interface.service.ts +++ b/apps/browser/src/services/fido2/browser-fido2-user-interface.service.ts @@ -195,8 +195,8 @@ export class BrowserFido2UserInterfaceSession implements Fido2UserInterfaceSessi ); this.tabClosed$ = fromEventPattern( - (handler: any) => chrome.windows.onRemoved.addListener(handler), - (handler: any) => chrome.windows.onRemoved.removeListener(handler) + (handler: any) => chrome.tabs.onRemoved.addListener(handler), + (handler: any) => chrome.tabs.onRemoved.removeListener(handler) ); BrowserFido2UserInterfaceSession.sendMessage({ @@ -303,7 +303,7 @@ export class BrowserFido2UserInterfaceSession implements Fido2UserInterfaceSessi this.destroy$.complete(); } - async abort(fallback = false) { + private async abort(fallback = false) { this.abortController.abort(fallback ? UserRequestedFallbackAbortReason : undefined); } diff --git a/apps/web/src/app/auth/login/login.component.ts b/apps/web/src/app/auth/login/login.component.ts index bcddfcf173..431f0bac26 100644 --- a/apps/web/src/app/auth/login/login.component.ts +++ b/apps/web/src/app/auth/login/login.component.ts @@ -144,11 +144,6 @@ export class LoginComponent extends BaseLoginComponent implements OnInit { } } - // eslint-disable-next-line rxjs-angular/prefer-takeuntil - ngOnDestroy(): void { - super.ngOnDestroy(); - } - async goAfterLogIn() { const masterPassword = this.formGroup.value.masterPassword;