1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-10-30 08:10:34 +01:00

shared bugs

This commit is contained in:
Kyle Spearrin 2017-04-27 16:34:04 -04:00
parent a083fc9084
commit 0be6249c2b
2 changed files with 6 additions and 8 deletions

View File

@ -127,10 +127,8 @@
modal.result.then(function (response) { modal.result.then(function (response) {
if (response.collectionIds) { if (response.collectionIds) {
login.collectionIds = response.collectionIds; login.collectionIds = response.collectionIds;
// TODO: if there are no collectionIds now, it is possible that the user no longer has access to this login
if (!response.collectionIds.length) { // which means it should be removed by calling removeRootLogin(findRootLogin(login))
removeRootLogin(findRootLogin(login));
}
} }
}); });
}; };
@ -154,9 +152,8 @@
apiService.ciphers.putCollections({ id: login.id }, request).$promise.then(function (response) { apiService.ciphers.putCollections({ id: login.id }, request).$promise.then(function (response) {
$analytics.eventTrack('Removed From Collection'); $analytics.eventTrack('Removed From Collection');
login.collectionIds = request.collectionIds; login.collectionIds = request.collectionIds;
if (!login.collectionIds.length) { // TODO: if there are no collectionIds now, it is possible that the user no longer has access to this login
removeRootLogin(findRootLogin(login)); // which means it should be removed by calling removeRootLogin(findRootLogin(login))
}
}); });
}; };

View File

@ -68,7 +68,8 @@
</a> </a>
</li> </li>
<li> <li>
<a href="javascript:void(0)" ng-click="removeLogin(login, collection)" class="text-red"> <a href="javascript:void(0)" ng-click="removeLogin(login, collection)"
ng-if="collection.id" class="text-red">
<i class="fa fa-fw fa-remove"></i> Remove <i class="fa fa-fw fa-remove"></i> Remove
</a> </a>
</li> </li>