mirror of
https://github.com/bitwarden/browser.git
synced 2025-01-02 18:17:46 +01:00
[PM-11778] Removed super syntax and replaced with this (#11511)
This commit is contained in:
parent
a72f3a201f
commit
0f525fa9bc
@ -34,7 +34,7 @@ export class HintComponent extends BaseHintComponent {
|
|||||||
toastService,
|
toastService,
|
||||||
);
|
);
|
||||||
|
|
||||||
super.onSuccessfulSubmit = async () => {
|
this.onSuccessfulSubmit = async () => {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||||
this.router.navigate([this.successRoute]);
|
this.router.navigate([this.successRoute]);
|
||||||
|
@ -105,7 +105,7 @@ export class LockComponent extends BaseLockComponent implements OnInit {
|
|||||||
this.successRoute = "/tabs/current";
|
this.successRoute = "/tabs/current";
|
||||||
this.isInitialLockScreen = (window as any).previousPopupUrl == null;
|
this.isInitialLockScreen = (window as any).previousPopupUrl == null;
|
||||||
|
|
||||||
super.onSuccessfulSubmit = async () => {
|
this.onSuccessfulSubmit = async () => {
|
||||||
const previousUrl = this.routerService.getPreviousUrl();
|
const previousUrl = this.routerService.getPreviousUrl();
|
||||||
if (previousUrl) {
|
if (previousUrl) {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
|
@ -74,7 +74,7 @@ export class LoginViaAuthRequestComponent extends BaseLoginWithDeviceComponent {
|
|||||||
loginStrategyService,
|
loginStrategyService,
|
||||||
toastService,
|
toastService,
|
||||||
);
|
);
|
||||||
super.onSuccessfulLogin = async () => {
|
this.onSuccessfulLogin = async () => {
|
||||||
await syncService.fullSync(true);
|
await syncService.fullSync(true);
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
@ -78,10 +78,10 @@ export class LoginComponent extends BaseLoginComponent implements OnInit {
|
|||||||
registerRouteService,
|
registerRouteService,
|
||||||
toastService,
|
toastService,
|
||||||
);
|
);
|
||||||
super.onSuccessfulLogin = async () => {
|
this.onSuccessfulLogin = async () => {
|
||||||
await syncService.fullSync(true);
|
await syncService.fullSync(true);
|
||||||
};
|
};
|
||||||
super.successRoute = "/tabs/vault";
|
this.successRoute = "/tabs/vault";
|
||||||
this.showPasswordless = flagEnabled("showPasswordless");
|
this.showPasswordless = flagEnabled("showPasswordless");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -79,7 +79,7 @@ export class SsoComponent extends BaseSsoComponent {
|
|||||||
});
|
});
|
||||||
this.clientId = "browser";
|
this.clientId = "browser";
|
||||||
|
|
||||||
super.onSuccessfulLogin = async () => {
|
this.onSuccessfulLogin = async () => {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||||
syncService.fullSync(true);
|
syncService.fullSync(true);
|
||||||
@ -92,13 +92,13 @@ export class SsoComponent extends BaseSsoComponent {
|
|||||||
this.win.close();
|
this.win.close();
|
||||||
};
|
};
|
||||||
|
|
||||||
super.onSuccessfulLoginTde = async () => {
|
this.onSuccessfulLoginTde = async () => {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||||
syncService.fullSync(true);
|
syncService.fullSync(true);
|
||||||
};
|
};
|
||||||
|
|
||||||
super.onSuccessfulLoginTdeNavigate = async () => {
|
this.onSuccessfulLoginTdeNavigate = async () => {
|
||||||
this.win.close();
|
this.win.close();
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
@ -118,7 +118,7 @@ export class TwoFactorAuthComponent
|
|||||||
win,
|
win,
|
||||||
toastService,
|
toastService,
|
||||||
);
|
);
|
||||||
super.onSuccessfulLoginTdeNavigate = async () => {
|
this.onSuccessfulLoginTdeNavigate = async () => {
|
||||||
this.win.close();
|
this.win.close();
|
||||||
};
|
};
|
||||||
this.onSuccessfulLoginNavigate = this.goAfterLogIn;
|
this.onSuccessfulLoginNavigate = this.goAfterLogIn;
|
||||||
@ -131,7 +131,7 @@ export class TwoFactorAuthComponent
|
|||||||
// WebAuthn fallback response
|
// WebAuthn fallback response
|
||||||
this.selectedProviderType = TwoFactorProviderType.WebAuthn;
|
this.selectedProviderType = TwoFactorProviderType.WebAuthn;
|
||||||
this.token = this.route.snapshot.paramMap.get("webAuthnResponse");
|
this.token = this.route.snapshot.paramMap.get("webAuthnResponse");
|
||||||
super.onSuccessfulLogin = async () => {
|
this.onSuccessfulLogin = async () => {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||||
this.syncService.fullSync(true);
|
this.syncService.fullSync(true);
|
||||||
|
@ -87,23 +87,23 @@ export class TwoFactorComponent extends BaseTwoFactorComponent implements OnInit
|
|||||||
accountService,
|
accountService,
|
||||||
toastService,
|
toastService,
|
||||||
);
|
);
|
||||||
super.onSuccessfulLogin = async () => {
|
this.onSuccessfulLogin = async () => {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||||
syncService.fullSync(true);
|
syncService.fullSync(true);
|
||||||
};
|
};
|
||||||
|
|
||||||
super.onSuccessfulLoginTde = async () => {
|
this.onSuccessfulLoginTde = async () => {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||||
syncService.fullSync(true);
|
syncService.fullSync(true);
|
||||||
};
|
};
|
||||||
|
|
||||||
super.onSuccessfulLoginTdeNavigate = async () => {
|
this.onSuccessfulLoginTdeNavigate = async () => {
|
||||||
this.win.close();
|
this.win.close();
|
||||||
};
|
};
|
||||||
|
|
||||||
super.successRoute = "/tabs/vault";
|
this.successRoute = "/tabs/vault";
|
||||||
// FIXME: Chromium 110 has broken WebAuthn support in extensions via an iframe
|
// FIXME: Chromium 110 has broken WebAuthn support in extensions via an iframe
|
||||||
this.webAuthnNewTab = true;
|
this.webAuthnNewTab = true;
|
||||||
}
|
}
|
||||||
@ -113,7 +113,7 @@ export class TwoFactorComponent extends BaseTwoFactorComponent implements OnInit
|
|||||||
// WebAuthn fallback response
|
// WebAuthn fallback response
|
||||||
this.selectedProviderType = TwoFactorProviderType.WebAuthn;
|
this.selectedProviderType = TwoFactorProviderType.WebAuthn;
|
||||||
this.token = this.route.snapshot.paramMap.get("webAuthnResponse");
|
this.token = this.route.snapshot.paramMap.get("webAuthnResponse");
|
||||||
super.onSuccessfulLogin = async () => {
|
this.onSuccessfulLogin = async () => {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||||
this.syncService.fullSync(true);
|
this.syncService.fullSync(true);
|
||||||
@ -155,7 +155,7 @@ export class TwoFactorComponent extends BaseTwoFactorComponent implements OnInit
|
|||||||
// eslint-disable-next-line rxjs-angular/prefer-takeuntil, rxjs/no-async-subscribe
|
// eslint-disable-next-line rxjs-angular/prefer-takeuntil, rxjs/no-async-subscribe
|
||||||
this.route.queryParams.pipe(first()).subscribe(async (qParams) => {
|
this.route.queryParams.pipe(first()).subscribe(async (qParams) => {
|
||||||
if (qParams.sso === "true") {
|
if (qParams.sso === "true") {
|
||||||
super.onSuccessfulLogin = async () => {
|
this.onSuccessfulLogin = async () => {
|
||||||
// This is not awaited so we don't pause the application while the sync is happening.
|
// This is not awaited so we don't pause the application while the sync is happening.
|
||||||
// This call is executed by the service that lives in the background script so it will continue
|
// This call is executed by the service that lives in the background script so it will continue
|
||||||
// the sync even if this tab closes.
|
// the sync even if this tab closes.
|
||||||
|
@ -83,7 +83,7 @@ export class LoginViaAuthRequestComponent extends BaseLoginWithDeviceComponent {
|
|||||||
toastService,
|
toastService,
|
||||||
);
|
);
|
||||||
|
|
||||||
super.onSuccessfulLogin = () => {
|
this.onSuccessfulLogin = () => {
|
||||||
return syncService.fullSync(true);
|
return syncService.fullSync(true);
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
@ -99,7 +99,7 @@ export class LoginComponent extends BaseLoginComponent implements OnInit, OnDest
|
|||||||
registerRouteService,
|
registerRouteService,
|
||||||
toastService,
|
toastService,
|
||||||
);
|
);
|
||||||
super.onSuccessfulLogin = () => {
|
this.onSuccessfulLogin = () => {
|
||||||
return syncService.fullSync(true);
|
return syncService.fullSync(true);
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
@ -65,13 +65,13 @@ export class SsoComponent extends BaseSsoComponent {
|
|||||||
accountService,
|
accountService,
|
||||||
toastService,
|
toastService,
|
||||||
);
|
);
|
||||||
super.onSuccessfulLogin = async () => {
|
this.onSuccessfulLogin = async () => {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||||
syncService.fullSync(true);
|
syncService.fullSync(true);
|
||||||
};
|
};
|
||||||
|
|
||||||
super.onSuccessfulLoginTde = async () => {
|
this.onSuccessfulLoginTde = async () => {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||||
syncService.fullSync(true);
|
syncService.fullSync(true);
|
||||||
|
@ -89,13 +89,13 @@ export class TwoFactorComponent extends BaseTwoFactorComponent implements OnDest
|
|||||||
accountService,
|
accountService,
|
||||||
toastService,
|
toastService,
|
||||||
);
|
);
|
||||||
super.onSuccessfulLogin = async () => {
|
this.onSuccessfulLogin = async () => {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||||
syncService.fullSync(true);
|
syncService.fullSync(true);
|
||||||
};
|
};
|
||||||
|
|
||||||
super.onSuccessfulLoginTde = async () => {
|
this.onSuccessfulLoginTde = async () => {
|
||||||
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
|
||||||
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
// eslint-disable-next-line @typescript-eslint/no-floating-promises
|
||||||
syncService.fullSync(true);
|
syncService.fullSync(true);
|
||||||
|
@ -71,7 +71,7 @@ export class RegisterFormComponent extends BaseRegisterComponent implements OnIn
|
|||||||
dialogService,
|
dialogService,
|
||||||
toastService,
|
toastService,
|
||||||
);
|
);
|
||||||
super.modifyRegisterRequest = async (request: RegisterRequest) => {
|
this.modifyRegisterRequest = async (request: RegisterRequest) => {
|
||||||
// Org invites are deep linked. Non-existent accounts are redirected to the register page.
|
// Org invites are deep linked. Non-existent accounts are redirected to the register page.
|
||||||
// Org user id and token are included here only for validation and two factor purposes.
|
// Org user id and token are included here only for validation and two factor purposes.
|
||||||
const orgInvite = await acceptOrgInviteService.getOrganizationInvite();
|
const orgInvite = await acceptOrgInviteService.getOrganizationInvite();
|
||||||
|
Loading…
Reference in New Issue
Block a user