From 11034de7d1658f2d3654413dadc1298b74a842f9 Mon Sep 17 00:00:00 2001 From: Kyle Spearrin Date: Fri, 25 Mar 2022 11:00:40 -0400 Subject: [PATCH] resolve build errors with latest jslib ref (#1565) --- jslib | 2 +- .../tools/password-generator.component.html | 70 +++++++++---------- src/app/tools/password-generator.component.ts | 16 ++++- 3 files changed, 51 insertions(+), 37 deletions(-) diff --git a/jslib b/jslib index 5b7b2a03dd..fa73c13b8c 160000 --- a/jslib +++ b/jslib @@ -1 +1 @@ -Subproject commit 5b7b2a03ddbecbc93adc54a5c69e8141c00c192f +Subproject commit fa73c13b8c9ed35cbb9909e342b143fa8a57f1a0 diff --git a/src/app/tools/password-generator.component.html b/src/app/tools/password-generator.component.html index 4bd129fcd6..343085cb9c 100644 --- a/src/app/tools/password-generator.component.html +++ b/src/app/tools/password-generator.component.html @@ -1,7 +1,7 @@ - + {{ "passwordGeneratorPolicyInEffect" | i18n }}
@@ -14,19 +14,19 @@
- +
@@ -36,8 +36,8 @@ type="number" min="3" max="20" - [(ngModel)]="options.numWords" - (blur)="saveOptions()" + [(ngModel)]="passwordOptions.numWords" + (blur)="savePasswordOptions()" />
@@ -47,8 +47,8 @@ class="form-control" type="text" maxlength="1" - [(ngModel)]="options.wordSeparator" - (blur)="saveOptions()" + [(ngModel)]="passwordOptions.wordSeparator" + (blur)="savePasswordOptions()" />
@@ -58,9 +58,9 @@ id="capitalize" class="form-check-input" type="checkbox" - (change)="saveOptions()" - [(ngModel)]="options.capitalize" - [disabled]="enforcedPolicyOptions?.capitalize" + (change)="savePasswordOptions()" + [(ngModel)]="passwordOptions.capitalize" + [disabled]="enforcedPasswordPolicyOptions?.capitalize" /> @@ -69,15 +69,15 @@ id="include-number" class="form-check-input" type="checkbox" - (change)="saveOptions()" - [(ngModel)]="options.includeNumber" - [disabled]="enforcedPolicyOptions?.includeNumber" + (change)="savePasswordOptions()" + [(ngModel)]="passwordOptions.includeNumber" + [disabled]="enforcedPasswordPolicyOptions?.includeNumber" />
- +
@@ -87,8 +87,8 @@ type="number" min="5" max="128" - [(ngModel)]="options.length" - (blur)="saveOptions()" + [(ngModel)]="passwordOptions.length" + (blur)="savePasswordOptions()" (change)="lengthChanged()" />
@@ -100,8 +100,8 @@ type="number" min="0" max="9" - (blur)="saveOptions()" - [(ngModel)]="options.minNumber" + (blur)="savePasswordOptions()" + [(ngModel)]="passwordOptions.minNumber" (change)="minNumberChanged()" />
@@ -113,8 +113,8 @@ type="number" min="0" max="9" - (blur)="saveOptions()" - [(ngModel)]="options.minSpecial" + (blur)="savePasswordOptions()" + [(ngModel)]="passwordOptions.minSpecial" (change)="minSpecialChanged()" /> @@ -125,9 +125,9 @@ id="uppercase" class="form-check-input" type="checkbox" - (change)="saveOptions()" - [(ngModel)]="options.uppercase" - [disabled]="enforcedPolicyOptions?.useUppercase" + (change)="savePasswordOptions()" + [(ngModel)]="passwordOptions.uppercase" + [disabled]="enforcedPasswordPolicyOptions?.useUppercase" /> @@ -136,9 +136,9 @@ id="lowercase" class="form-check-input" type="checkbox" - (change)="saveOptions()" - [(ngModel)]="options.lowercase" - [disabled]="enforcedPolicyOptions?.useLowercase" + (change)="savePasswordOptions()" + [(ngModel)]="passwordOptions.lowercase" + [disabled]="enforcedPasswordPolicyOptions?.useLowercase" /> @@ -147,9 +147,9 @@ id="numbers" class="form-check-input" type="checkbox" - (change)="saveOptions()" - [(ngModel)]="options.number" - [disabled]="enforcedPolicyOptions?.useNumbers" + (change)="savePasswordOptions()" + [(ngModel)]="passwordOptions.number" + [disabled]="enforcedPasswordPolicyOptions?.useNumbers" /> @@ -158,9 +158,9 @@ id="special" class="form-check-input" type="checkbox" - (change)="saveOptions()" - [(ngModel)]="options.special" - [disabled]="enforcedPolicyOptions?.useSpecial" + (change)="savePasswordOptions()" + [(ngModel)]="passwordOptions.special" + [disabled]="enforcedPasswordPolicyOptions?.useSpecial" /> @@ -169,7 +169,7 @@ id="ambiguous" class="form-check-input" type="checkbox" - (change)="saveOptions()" + (change)="savePasswordOptions()" [(ngModel)]="avoidAmbiguous" /> diff --git a/src/app/tools/password-generator.component.ts b/src/app/tools/password-generator.component.ts index 93b1d9eb6d..a07ad051d5 100644 --- a/src/app/tools/password-generator.component.ts +++ b/src/app/tools/password-generator.component.ts @@ -1,10 +1,13 @@ import { Component, ViewChild, ViewContainerRef } from "@angular/core"; +import { ActivatedRoute } from "@angular/router"; import { PasswordGeneratorComponent as BasePasswordGeneratorComponent } from "jslib-angular/components/password-generator.component"; import { ModalService } from "jslib-angular/services/modal.service"; import { I18nService } from "jslib-common/abstractions/i18n.service"; import { PasswordGenerationService } from "jslib-common/abstractions/passwordGeneration.service"; import { PlatformUtilsService } from "jslib-common/abstractions/platformUtils.service"; +import { StateService } from "jslib-common/abstractions/state.service"; +import { UsernameGenerationService } from "jslib-common/abstractions/usernameGeneration.service"; import { PasswordGeneratorHistoryComponent } from "./password-generator-history.component"; @@ -18,11 +21,22 @@ export class PasswordGeneratorComponent extends BasePasswordGeneratorComponent { constructor( passwordGenerationService: PasswordGenerationService, + usernameGenerationService: UsernameGenerationService, + stateService: StateService, platformUtilsService: PlatformUtilsService, i18nService: I18nService, + route: ActivatedRoute, private modalService: ModalService ) { - super(passwordGenerationService, platformUtilsService, i18nService, window); + super( + passwordGenerationService, + usernameGenerationService, + platformUtilsService, + stateService, + i18nService, + route, + window + ); } async history() {