Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-02-19 01:51:27 +01:00
Code Issues Projects Releases Wiki Activity

PM-8113 - TwoFactorAuthComponent tests - updated to pass

Browse Source
This commit is contained in:
Jared Snider 2024-12-15 14:38:13 -05:00
parent 71fd85c907
commit 112f9d4592
No known key found for this signature in database
GPG Key ID: A149DDD612516286
1 changed files with 10 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
libs/auth/src/angular/two-factor-auth/two-factor-auth.component.spec.ts
View File

@ -42,15 +42,8 @@ import { TwoFactorAuthComponent } from "./two-factor-auth.component";
@Component({}) @Component({})
class TestTwoFactorComponent extends TwoFactorAuthComponent {} class TestTwoFactorComponent extends TwoFactorAuthComponent {}
interface TwoFactorComponentProtected {
trustedDeviceEncRoute: string;
changePasswordRoute: string;
forcePasswordResetRoute: string;
}
describe("TwoFactorComponent", () => { describe("TwoFactorComponent", () => {
let component: TestTwoFactorComponent; let component: TestTwoFactorComponent;
let _component: TwoFactorComponentProtected;
let fixture: ComponentFixture<TestTwoFactorComponent>; let fixture: ComponentFixture<TestTwoFactorComponent>;
const userId = "userId" as UserId; const userId = "userId" as UserId;
@ -199,7 +192,6 @@ describe("TwoFactorComponent", () => {
fixture = TestBed.createComponent(TestTwoFactorComponent); fixture = TestBed.createComponent(TestTwoFactorComponent);
component = fixture.componentInstance; component = fixture.componentInstance;
_component = component as any;
}); });
afterEach(() => { afterEach(() => {
@ -219,7 +211,7 @@ describe("TwoFactorComponent", () => {
// Assert // Assert
expect(mockRouter.navigate).toHaveBeenCalledTimes(1); expect(mockRouter.navigate).toHaveBeenCalledTimes(1);
expect(mockRouter.navigate).toHaveBeenCalledWith([_component.changePasswordRoute], { expect(mockRouter.navigate).toHaveBeenCalledWith(["set-password"], {
queryParams: { queryParams: {
identifier: component.orgSsoIdentifier, identifier: component.orgSsoIdentifier,
}, },
@ -233,7 +225,7 @@ describe("TwoFactorComponent", () => {
await component.submit(); await component.submit();
// expect(mockRouter.navigate).toHaveBeenCalledTimes(1); // expect(mockRouter.navigate).toHaveBeenCalledTimes(1);
expect(mockRouter.navigate).toHaveBeenCalledWith([_component.forcePasswordResetRoute], { expect(mockRouter.navigate).toHaveBeenCalledWith(["update-temp-password"], {
queryParams: { queryParams: {
identifier: component.orgSsoIdentifier, identifier: component.orgSsoIdentifier,
}, },
@ -307,7 +299,7 @@ describe("TwoFactorComponent", () => {
await component.submit(); await component.submit();
expect(mockRouter.navigate).not.toHaveBeenCalledWith([_component.changePasswordRoute], { expect(mockRouter.navigate).not.toHaveBeenCalledWith(["set-password"], {
queryParams: { queryParams: {
identifier: component.orgSsoIdentifier, identifier: component.orgSsoIdentifier,
}, },
@ -390,7 +382,9 @@ describe("TwoFactorComponent", () => {
}); });
describe("Trusted Device Encryption scenarios", () => { describe("Trusted Device Encryption scenarios", () => {
beforeEach(() => {}); beforeEach(() => {
mockTwoFactorAuthCompService.closeWindow = undefined;
});
describe("Given Trusted Device Encryption is enabled and user needs to set a master password", () => { describe("Given Trusted Device Encryption is enabled and user needs to set a master password", () => {
beforeEach(() => { beforeEach(() => {
@ -402,7 +396,7 @@ describe("TwoFactorComponent", () => {
mockLoginStrategyService.logInTwoFactor.mockResolvedValue(authResult); mockLoginStrategyService.logInTwoFactor.mockResolvedValue(authResult);
}); });
it("navigates to the component's defined trusted device encryption route and sets correct flag when user doesn't have a MP and key connector isn't enabled", async () => { it("navigates to the login-initiated route and sets correct flag when user doesn't have a MP and key connector isn't enabled", async () => {
// Act // Act
await component.submit(); await component.submit();
@ -413,10 +407,7 @@ describe("TwoFactorComponent", () => {
); );
expect(mockRouter.navigate).toHaveBeenCalledTimes(1); expect(mockRouter.navigate).toHaveBeenCalledTimes(1);
expect(mockRouter.navigate).toHaveBeenCalledWith( expect(mockRouter.navigate).toHaveBeenCalledWith(["login-initiated"]);
[_component.trustedDeviceEncRoute],
undefined,
);
}); });
}); });
@ -454,23 +445,11 @@ describe("TwoFactorComponent", () => {
mockLoginStrategyService.logInTwoFactor.mockResolvedValue(authResult); mockLoginStrategyService.logInTwoFactor.mockResolvedValue(authResult);
}); });
it("navigates to the component's defined trusted device encryption route when login is successful and onSuccessfulLoginTdeNavigate is undefined", async () => { it("navigates to the login-initiated route when login is successful", async () => {
await component.submit(); await component.submit();
expect(mockRouter.navigate).toHaveBeenCalledTimes(1); expect(mockRouter.navigate).toHaveBeenCalledTimes(1);
expect(mockRouter.navigate).toHaveBeenCalledWith( expect(mockRouter.navigate).toHaveBeenCalledWith(["login-initiated"]);
[_component.trustedDeviceEncRoute],
undefined,
);
});
it("calls onSuccessfulLoginTdeNavigate instead of router.navigate when the callback is defined", async () => {
component.onSuccessfulLoginTdeNavigate = jest.fn().mockResolvedValue(undefined);
await component.submit();
expect(mockRouter.navigate).not.toHaveBeenCalled();
expect(component.onSuccessfulLoginTdeNavigate).toHaveBeenCalled();
}); });
}); });
}); });