Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-21 16:18:28 +01:00
Code Issues Projects Releases Wiki Activity

[PM-14054] Fix scroll based re positioning when inline menu settings change occurs (#11765)

Browse Source
This commit is contained in:
Cesar Gonzalez 2024-10-28 17:05:10 -05:00 committed by GitHub
parent 3fe84b041a
commit 11f18c478e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/browser/src/autofill/background/overlay.background.spec.ts
View File

@ -629,6 +629,9 @@ describe("OverlayBackground", () => {
it("skips updating the inline menu list if the user has the inline menu set to open on button click", async () => { it("skips updating the inline menu list if the user has the inline menu set to open on button click", async () => {
inlineMenuVisibilityMock$.next(AutofillOverlayVisibility.OnButtonClick); inlineMenuVisibilityMock$.next(AutofillOverlayVisibility.OnButtonClick);
jest
.spyOn(overlayBackground as any, "checkIsInlineMenuListVisible")
.mockReturnValue(false);
tabsSendMessageSpy.mockImplementation((_tab, message, _options) => { tabsSendMessageSpy.mockImplementation((_tab, message, _options) => {
if (message.command === "checkFocusedFieldHasValue") { if (message.command === "checkFocusedFieldHasValue") {
return Promise.resolve(true); return Promise.resolve(true);

4
apps/browser/src/autofill/background/overlay.background.ts
View File

@ -1010,8 +1010,8 @@ export class OverlayBackground implements OverlayBackgroundInterface {
); );
if ( if (
(await this.getInlineMenuVisibility()) === AutofillOverlayVisibility.OnButtonClick && !this.checkIsInlineMenuListVisible() &&
!this.isInlineMenuListVisible (await this.getInlineMenuVisibility()) === AutofillOverlayVisibility.OnButtonClick
) { ) {
return; return;
} }