Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-25 12:15:18 +01:00
Code Issues Projects Releases Wiki Activity

[PM-6853] Stop Caching Empty Ciphers List (#8406)

Browse Source 
* Stop Caching Empty Ciphers List

* Allow Caching `null`

* Move Logic to CipherService
This commit is contained in:
Justin Baur 2024-03-20 14:10:09 -05:00 committed by GitHub
parent 7b40c21798
commit 1400ec9c16
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libs/common/src/vault/services/cipher.service.ts
View File

@ -79,7 +79,12 @@ export class CipherService implements CipherServiceAbstraction {
}
async setDecryptedCipherCache(value: CipherView[]) {
await this.stateService.setDecryptedCiphers(value);
// Sometimes we might prematurely decrypt the vault and that will result in no ciphers
// if we cache it then we may accidentially return it when it's not right, we'd rather try decryption again.
// We still want to set null though, that is the indicator that the cache isn't valid and we should do decryption.
if (value == null || value.length !== 0) {
await this.stateService.setDecryptedCiphers(value);
}
if (this.searchService != null) {
if (value == null) {
this.searchService.clearIndex();