mirror of
https://github.com/bitwarden/browser.git
synced 2024-12-23 16:38:45 +01:00
Add numeric score to the result row, as bitSortable does not support sorting by an object/object-ket (#11483)
Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
This commit is contained in:
parent
16f36a1008
commit
14d71e7408
@ -39,7 +39,7 @@
|
||||
<th bitCell bitSortable="organizationId" *ngIf="!isAdminConsoleActive">
|
||||
{{ "owner" | i18n }}
|
||||
</th>
|
||||
<th bitCell class="tw-text-right" bitSortable="reportValue" default>
|
||||
<th bitCell class="tw-text-right" bitSortable="score" default>
|
||||
{{ "weakness" | i18n }}
|
||||
</th>
|
||||
</tr>
|
||||
|
@ -15,7 +15,7 @@ import { PasswordRepromptService } from "@bitwarden/vault";
|
||||
import { CipherReportComponent } from "./cipher-report.component";
|
||||
|
||||
type ReportScore = { label: string; badgeVariant: BadgeVariant };
|
||||
type ReportResult = CipherView & { reportValue: ReportScore };
|
||||
type ReportResult = CipherView & { score: number; reportValue: ReportScore };
|
||||
|
||||
@Component({
|
||||
selector: "app-weak-passwords-report",
|
||||
@ -100,7 +100,7 @@ export class WeakPasswordsReportComponent extends CipherReportComponent implemen
|
||||
|
||||
if (result.score != null && result.score <= 2) {
|
||||
const scoreValue = this.scoreKey(result.score);
|
||||
const row = { ...ciph, reportValue: scoreValue } as ReportResult;
|
||||
const row = { ...ciph, score: result.score, reportValue: scoreValue } as ReportResult;
|
||||
this.weakPasswordCiphers.push(row);
|
||||
}
|
||||
});
|
||||
|
Loading…
Reference in New Issue
Block a user