1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-10-14 06:48:18 +02:00

[PM-13170] Enable use of new generators on web (#11405)

* Create web-specifc credential-generator component

* Add missing entries in en/messages.json

* Import and use conditional routing for new credential generator component

* Add comment about temporary using password-generator component

* Update comment to include FIXME which is more easily searchable

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
This commit is contained in:
Daniel James Smith 2024-10-10 15:42:46 +02:00 committed by GitHub
parent b9be15c84b
commit 16f36a1008
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 65 additions and 7 deletions

View File

@ -10,6 +10,7 @@ import {
unauthGuardFn, unauthGuardFn,
} from "@bitwarden/angular/auth/guards"; } from "@bitwarden/angular/auth/guards";
import { canAccessFeature } from "@bitwarden/angular/platform/guard/feature-flag.guard"; import { canAccessFeature } from "@bitwarden/angular/platform/guard/feature-flag.guard";
import { generatorSwap } from "@bitwarden/angular/tools/generator/generator-swap";
import { extensionRefreshSwap } from "@bitwarden/angular/utils/extension-refresh-swap"; import { extensionRefreshSwap } from "@bitwarden/angular/utils/extension-refresh-swap";
import { import {
AnonLayoutWrapperComponent, AnonLayoutWrapperComponent,
@ -70,6 +71,7 @@ import { RequestSMAccessComponent } from "./secrets-manager/secrets-manager-land
import { SMLandingComponent } from "./secrets-manager/secrets-manager-landing/sm-landing.component"; import { SMLandingComponent } from "./secrets-manager/secrets-manager-landing/sm-landing.component";
import { DomainRulesComponent } from "./settings/domain-rules.component"; import { DomainRulesComponent } from "./settings/domain-rules.component";
import { PreferencesComponent } from "./settings/preferences.component"; import { PreferencesComponent } from "./settings/preferences.component";
import { CredentialGeneratorComponent } from "./tools/credential-generator/credential-generator.component";
import { GeneratorComponent } from "./tools/generator.component"; import { GeneratorComponent } from "./tools/generator.component";
import { ReportsModule } from "./tools/reports"; import { ReportsModule } from "./tools/reports";
import { AccessComponent } from "./tools/send/access.component"; import { AccessComponent } from "./tools/send/access.component";
@ -598,11 +600,10 @@ const routes: Routes = [
titleId: "exportVault", titleId: "exportVault",
} satisfies RouteDataProperties, } satisfies RouteDataProperties,
}, },
{ ...generatorSwap(GeneratorComponent, CredentialGeneratorComponent, {
path: "generator", path: "generator",
component: GeneratorComponent,
data: { titleId: "generator" } satisfies RouteDataProperties, data: { titleId: "generator" } satisfies RouteDataProperties,
}, }),
], ],
}, },
{ {

View File

@ -0,0 +1,5 @@
<app-header></app-header>
<bit-container>
<tools-credential-generator />
</bit-container>

View File

@ -0,0 +1,14 @@
import { Component } from "@angular/core";
import { GeneratorModule } from "@bitwarden/generator-components";
import { HeaderModule } from "../../layouts/header/header.module";
import { SharedModule } from "../../shared";
@Component({
standalone: true,
selector: "credential-generator",
templateUrl: "credential-generator.component.html",
imports: [SharedModule, HeaderModule, GeneratorModule],
})
export class CredentialGeneratorComponent {}

View File

@ -1500,7 +1500,12 @@
"description": "Minimum special characters" "description": "Minimum special characters"
}, },
"ambiguous": { "ambiguous": {
"message": "Avoid ambiguous characters" "message": "Avoid ambiguous characters",
"description": "deprecated. Use avoidAmbiguous instead."
},
"avoidAmbiguous": {
"message": "Avoid ambiguous characters",
"description": "Label for the avoid ambiguous characters checkbox."
}, },
"regeneratePassword": { "regeneratePassword": {
"message": "Regenerate password" "message": "Regenerate password"
@ -1513,18 +1518,51 @@
}, },
"uppercase": { "uppercase": {
"message": "Uppercase (A-Z)", "message": "Uppercase (A-Z)",
"description": "Include uppercase letters in the password generator." "description": "deprecated. Use uppercaseLabel instead."
}, },
"lowercase": { "lowercase": {
"message": "Lowercase (a-z)", "message": "Lowercase (a-z)",
"description": "Include lowercase letters in the password generator." "description": "deprecated. Use lowercaseLabel instead."
}, },
"numbers": { "numbers": {
"message": "Numbers (0-9)" "message": "Numbers (0-9)",
"description": "deprecated. Use numbersLabel instead."
}, },
"specialCharacters": { "specialCharacters": {
"message": "Special characters (!@#$%^&*)" "message": "Special characters (!@#$%^&*)"
}, },
"uppercaseDescription": {
"message": "Include uppercase characters",
"description": "Tooltip for the password generator uppercase character checkbox"
},
"uppercaseLabel": {
"message": "A-Z",
"description": "Label for the password generator uppercase character checkbox"
},
"lowercaseDescription": {
"message": "Include lowercase characters",
"description": "Full description for the password generator lowercase character checkbox"
},
"lowercaseLabel": {
"message": "a-z",
"description": "Label for the password generator lowercase character checkbox"
},
"numbersDescription": {
"message": "Include numbers",
"description": "Full description for the password generator numbers checkbox"
},
"numbersLabel": {
"message": "0-9",
"description": "Label for the password generator numbers checkbox"
},
"specialCharactersDescription": {
"message": "Include special characters",
"description": "Full description for the password generator special characters checkbox"
},
"specialCharactersLabel": {
"message": "!@#$%^&*",
"description": "Label for the password generator special characters checkbox"
},
"numWords": { "numWords": {
"message": "Number of words" "message": "Number of words"
}, },