From 18dbaf2a4e958901b1e54f2f32ec34a9acc0c5bf Mon Sep 17 00:00:00 2001
From: Andreas Coroiu <andreas.coroiu@gmail.com>
Date: Fri, 27 Jan 2023 13:38:17 +0100
Subject: [PATCH] [EC-598] feat: add test for request/response

---
 .../webauthn/messaging/messenger.spec.ts      | 34 ++++++++++++++-----
 1 file changed, 26 insertions(+), 8 deletions(-)

diff --git a/apps/browser/src/content/webauthn/messaging/messenger.spec.ts b/apps/browser/src/content/webauthn/messaging/messenger.spec.ts
index 13d68cd2b1..e0482cad68 100644
--- a/apps/browser/src/content/webauthn/messaging/messenger.spec.ts
+++ b/apps/browser/src/content/webauthn/messaging/messenger.spec.ts
@@ -22,21 +22,37 @@ describe("Messenger", () => {
     messengerB.addHandler(handlerB.handler);
   });
 
-  it("should deliver message to B when sending request to A", () => {
-    const message = createMessage();
-    messengerA.request(message);
+  it("should deliver message to B when sending request from A", () => {
+    const request = createRequest();
+    messengerA.request(request);
 
     const received = handlerB.recieve();
 
     expect(received.length).toBe(1);
-    expect(received[0].message).toMatchObject(message);
+    expect(received[0].message).toMatchObject(request);
+  });
+
+  it("should return response from B when sending request from A", async () => {
+    const request = createRequest();
+    const response = createResponse();
+    const requestPromise = messengerA.request(request);
+    const received = handlerB.recieve();
+    received[0].respond(response);
+
+    const returned = await requestPromise;
+
+    expect(returned).toMatchObject(response);
   });
 });
 
 type TestMessage = Message & { testId: string };
 
-function createMessage(): TestMessage {
-  return { testId: Utils.newGuid(), type: "TestMessage" } as any;
+function createRequest(): TestMessage {
+  return { testId: Utils.newGuid(), type: "TestRequest" } as any;
+}
+
+function createResponse(): TestMessage {
+  return { testId: Utils.newGuid(), type: "TestResponse" } as any;
 }
 
 class TestChannelPair {
@@ -49,12 +65,14 @@ class TestChannelPair {
 
     this.channelA = {
       messages$: subjectA,
-      postMessage: (message) => subjectB.next(message),
+      postMessage: (message) => {
+        subjectB.next(message);
+      },
     };
 
     this.channelB = {
       messages$: subjectB,
-      postMessage: (message) => subjectB.next(message),
+      postMessage: (message) => subjectA.next(message),
     };
   }
 }