Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-03-12 13:39:14 +01:00
Code Issues Projects Releases Wiki Activity

[PM-15418] Remove bitItem and use plain bitLink button for opening generator history (#12208)

Browse Source 
* Remove bitItem and use plain bitLink button for opening generator history

* Revert desktop back to use bitItem

---------

Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
This commit is contained in:
Daniel James Smith 2024-12-02 20:26:13 +01:00 committed by GitHub
parent 0ff48aa345
commit 19663d9587
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 13 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apps/desktop/src/app/tools/generator/credential-generator.component.html
View File

@ -6,6 +6,7 @@
<button <button
type="button" type="button"
bitLink bitLink
linkType="primary"
bit-item-content bit-item-content
aria-haspopup="true" aria-haspopup="true"
(click)="openHistoryDialog()" (click)="openHistoryDialog()"

10
apps/desktop/src/app/tools/generator/credential-generator.component.ts
View File

@ -17,15 +17,7 @@ import {
standalone: true, standalone: true,
selector: "credential-generator", selector: "credential-generator",
templateUrl: "credential-generator.component.html", templateUrl: "credential-generator.component.html",
imports: [ imports: [DialogModule, ButtonModule, JslibModule, GeneratorModule, ItemModule, LinkModule],
DialogModule,
ButtonModule,
JslibModule,
GeneratorModule,
ItemModule,
ButtonModule,
LinkModule,
],
}) })
export class CredentialGeneratorComponent { export class CredentialGeneratorComponent {
constructor(private dialogService: DialogService) {} constructor(private dialogService: DialogService) {}

7
apps/web/src/app/tools/credential-generator/credential-generator.component.html
View File

@ -2,16 +2,13 @@
<bit-container> <bit-container>
<tools-credential-generator /> <tools-credential-generator />
<bit-item>
<button <button
type="button"
bitLink bitLink
bit-item-content type="button"
linkType="primary"
aria-haspopup="true" aria-haspopup="true"
(click)="openHistoryDialog()" (click)="openHistoryDialog()"
> >
{{ "generatorHistory" | i18n }} {{ "generatorHistory" | i18n }}
<i slot="end" class="bwi bwi-angle-right" aria-hidden="true"></i>
</button> </button>
</bit-item>
</bit-container> </bit-container>

4
apps/web/src/app/tools/credential-generator/credential-generator.component.ts
View File

@ -1,6 +1,6 @@
import { Component } from "@angular/core"; import { Component } from "@angular/core";
import { ButtonModule, DialogService, ItemModule, LinkModule } from "@bitwarden/components"; import { ButtonModule, DialogService, LinkModule } from "@bitwarden/components";
import { import {
CredentialGeneratorHistoryDialogComponent, CredentialGeneratorHistoryDialogComponent,
GeneratorModule, GeneratorModule,
@ -13,7 +13,7 @@ import { SharedModule } from "../../shared";
standalone: true, standalone: true,
selector: "credential-generator", selector: "credential-generator",
templateUrl: "credential-generator.component.html", templateUrl: "credential-generator.component.html",
imports: [SharedModule, HeaderModule, GeneratorModule, ItemModule, ButtonModule, LinkModule], imports: [SharedModule, HeaderModule, GeneratorModule, ButtonModule, LinkModule],
}) })
export class CredentialGeneratorComponent { export class CredentialGeneratorComponent {
constructor(private dialogService: DialogService) {} constructor(private dialogService: DialogService) {}