Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-13 10:24:20 +01:00
Code Issues Projects Releases Wiki Activity

[PM-11386] Limit presentation of inline menu for identities strictly to fields that contain valid autocomplete attribute (#10865)

Browse Source 
* [PM-11386] Limit presentation of inline menu for identities strictly to fields that contain valid autocomplete attribute

* [PM-11386] Limit presentation of inline menu for identities strictly to fields that contain valid autocomplete attribute
This commit is contained in:
Cesar Gonzalez 2024-09-04 15:42:52 -05:00 committed by GitHub
parent e594059865
commit 1a1d9e2d76
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
apps/browser/src/autofill/services/inline-menu-field-qualification.service.ts
View File

@ -122,29 +122,9 @@ export class InlineMenuFieldQualificationService
...this.identityAddressAutoCompleteValues, ...this.identityAddressAutoCompleteValues,
...this.identityCountryAutocompleteValues, ...this.identityCountryAutocompleteValues,
...this.identityPhoneNumberAutocompleteValues, ...this.identityPhoneNumberAutocompleteValues,
this.identityCompanyAutocompleteValue,
this.identityPostalCodeAutocompleteValue, this.identityPostalCodeAutocompleteValue,
]); ]);
private identityFieldKeywords = [
...new Set([
...IdentityAutoFillConstants.TitleFieldNames,
...IdentityAutoFillConstants.FullNameFieldNames,
...IdentityAutoFillConstants.FirstnameFieldNames,
...IdentityAutoFillConstants.MiddlenameFieldNames,
...IdentityAutoFillConstants.LastnameFieldNames,
...IdentityAutoFillConstants.AddressFieldNames,
...IdentityAutoFillConstants.Address1FieldNames,
...IdentityAutoFillConstants.Address2FieldNames,
...IdentityAutoFillConstants.Address3FieldNames,
...IdentityAutoFillConstants.PostalCodeFieldNames,
...IdentityAutoFillConstants.CityFieldNames,
...IdentityAutoFillConstants.StateFieldNames,
...IdentityAutoFillConstants.CountryFieldNames,
...IdentityAutoFillConstants.CompanyFieldNames,
...IdentityAutoFillConstants.PhoneFieldNames,
...IdentityAutoFillConstants.EmailFieldNames,
...IdentityAutoFillConstants.UserNameFieldNames,
]),
];
private inlineMenuFieldQualificationFlagSet = false; private inlineMenuFieldQualificationFlagSet = false;
constructor() { constructor() {
@ -288,14 +268,7 @@ export class InlineMenuFieldQualificationService
return false; return false;
} }
if (this.fieldContainsAutocompleteValues(field, this.identityAutocompleteValues)) { return this.fieldContainsAutocompleteValues(field, this.identityAutocompleteValues);
return true;
}
return (
!this.fieldContainsAutocompleteValues(field, this.autocompleteDisabledValues) &&
this.keywordsFoundInFieldData(field, this.identityFieldKeywords, false)
);
} }
/** /**