From 236c41e6f85757b6f2cdb5920b7aa05c7612b058 Mon Sep 17 00:00:00 2001 From: rr-bw <102181210+rr-bw@users.noreply.github.com> Date: Fri, 13 Sep 2024 15:53:47 -0700 Subject: [PATCH] add browser redirect from /home to /login with FF on --- apps/browser/src/popup/app-routing.module.ts | 3 ++- libs/common/src/enums/feature-flag.enum.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/apps/browser/src/popup/app-routing.module.ts b/apps/browser/src/popup/app-routing.module.ts index d16778067f..5d531d6a84 100644 --- a/apps/browser/src/popup/app-routing.module.ts +++ b/apps/browser/src/popup/app-routing.module.ts @@ -134,7 +134,8 @@ const routes: Routes = [ { path: "home", component: HomeComponent, - canActivate: [unauthGuardFn(unauthRouteOverrides)], + // TODO-rr-bw: verify if was the correct feature-flag/redirect to use, and should it go in canActivate? + canActivate: [unauthGuardFn(unauthRouteOverrides), extensionRefreshRedirect("login")], data: { state: "home" }, }, ...extensionRefreshSwap(Fido2V1Component, Fido2Component, { diff --git a/libs/common/src/enums/feature-flag.enum.ts b/libs/common/src/enums/feature-flag.enum.ts index 26390a66fc..4f87b87746 100644 --- a/libs/common/src/enums/feature-flag.enum.ts +++ b/libs/common/src/enums/feature-flag.enum.ts @@ -56,7 +56,7 @@ export const DefaultFeatureFlagValue = { [FeatureFlag.EnableConsolidatedBilling]: FALSE, [FeatureFlag.AC1795_UpdatedSubscriptionStatusSection]: FALSE, [FeatureFlag.EnableDeleteProvider]: FALSE, - [FeatureFlag.ExtensionRefresh]: FALSE, + [FeatureFlag.ExtensionRefresh]: true, [FeatureFlag.PersistPopupView]: FALSE, [FeatureFlag.PM4154_BulkEncryptionService]: FALSE, [FeatureFlag.UseTreeWalkerApiForPageDetailsCollection]: FALSE,