Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-01-10 19:38:11 +01:00
Code Issues Projects Releases Wiki Activity

[PM-8027] Removing unnecessary code

Browse Source
This commit is contained in:
Cesar Gonzalez 2024-06-03 16:20:23 -05:00
parent 6d2795dcde
commit 2c1dfc9261
No known key found for this signature in database
GPG Key ID: 3381A5457F8CCECF
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
apps/browser/src/autofill/services/collect-autofill-content.service.ts
View File

@ -284,7 +284,7 @@ class CollectAutofillContentService implements CollectAutofillContentServiceInte
autofillField.viewable = await this.domElementVisibilityService.isFormFieldViewable(element);
if (!previouslyViewable && autofillField.viewable) {
this.setupAutofillOverlayListenerOnField(element, autofillField);
this.setupInlineMenuListenerOnField(element, autofillField);
}
});
}
@ -1422,23 +1422,35 @@ class CollectAutofillContentService implements CollectAutofillContentServiceInte
cachedAutofillFieldElement.viewable = true;
this.setupAutofillOverlayListenerOnField(formFieldElement, cachedAutofillFieldElement);
this.setupInlineMenuListenerOnField(formFieldElement, cachedAutofillFieldElement);
this.intersectionObserver?.unobserve(entry.target);
}
};
/**
* Iterates over all cached field elements and sets up the inline menu listeners on each field.
*
* @param pageDetails - The page details to use for the inline menu listeners
*/
private setupInlineMenuListeners(pageDetails: AutofillPageDetails) {
if (!this.autofillOverlayContentService) {
return;
}
this.autofillFieldElements.forEach((autofillField, formFieldElement) => {
this.setupAutofillOverlayListenerOnField(formFieldElement, autofillField, pageDetails);
this.setupInlineMenuListenerOnField(formFieldElement, autofillField, pageDetails);
});
}
private setupAutofillOverlayListenerOnField(
/**
* Sets up the inline menu listener on the passed field element.
*
* @param formFieldElement - The form field element to set up the inline menu listener on
* @param autofillField - The metadata for the form field
* @param pageDetails - The page details to use for the inline menu listeners
*/
private setupInlineMenuListenerOnField(
formFieldElement: ElementWithOpId<FormFieldElement>,
autofillField: AutofillField,
pageDetails?: AutofillPageDetails,