From 2c8855692c70e931c1f38d425445ca9718141600 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rui=20Tom=C3=A9?=
 <108268980+r-tome@users.noreply.github.com>
Date: Thu, 18 Apr 2024 14:17:34 +0100
Subject: [PATCH] [AC-2209] Update the dash in the admin console collections
 table permission column to no access (#8609)

* [AC-2209] Update permission text to display "No access" when collection is not assigned

* [AC-2209] Add permission tooltip for unassigned collections
---
 .../vault-items/vault-collection-row.component.html  |  2 +-
 .../vault-items/vault-collection-row.component.ts    | 12 ++++++++++--
 apps/web/src/locales/en/messages.json                |  6 ++++++
 3 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.html b/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.html
index a6d7854267..d333f92d5c 100644
--- a/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.html
+++ b/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.html
@@ -48,7 +48,7 @@
   ></app-group-badge>
 </td>
 <td bitCell [ngClass]="RowHeightClass" *ngIf="showPermissionsColumn">
-  <p class="tw-mb-0 tw-text-muted">
+  <p class="tw-mb-0 tw-text-muted" [title]="permissionTooltip">
     {{ permissionText }}
   </p>
 </td>
diff --git a/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.ts b/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.ts
index 666bec7a1a..8bf7779f88 100644
--- a/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.ts
+++ b/apps/web/src/app/vault/components/vault-items/vault-collection-row.component.ts
@@ -6,6 +6,7 @@ import { CollectionView } from "@bitwarden/common/vault/models/view/collection.v
 
 import { GroupView } from "../../../admin-console/organizations/core";
 import { CollectionAdminView } from "../../core/views/collection-admin.view";
+import { Unassigned } from "../../individual-vault/vault-filter/shared/models/routed-vault-filter.model";
 
 import {
   convertToPermission,
@@ -52,8 +53,8 @@ export class VaultCollectionRowComponent {
   }
 
   get permissionText() {
-    if (!(this.collection as CollectionAdminView).assigned) {
-      return "-";
+    if (this.collection.id != Unassigned && !(this.collection as CollectionAdminView).assigned) {
+      return this.i18nService.t("noAccess");
     } else {
       const permissionList = getPermissionList(this.organization?.flexibleCollections);
       return this.i18nService.t(
@@ -62,6 +63,13 @@ export class VaultCollectionRowComponent {
     }
   }
 
+  get permissionTooltip() {
+    if (this.collection.id == Unassigned) {
+      return this.i18nService.t("collectionAdminConsoleManaged");
+    }
+    return "";
+  }
+
   protected edit() {
     this.onEvent.next({ type: "editCollection", item: this.collection });
   }
diff --git a/apps/web/src/locales/en/messages.json b/apps/web/src/locales/en/messages.json
index 49611145dd..7632392c23 100644
--- a/apps/web/src/locales/en/messages.json
+++ b/apps/web/src/locales/en/messages.json
@@ -7979,5 +7979,11 @@
   },
   "createdNewClient": {
     "message": "Successfully created new client"
+   },
+  "noAccess": {
+    "message": "No access"
+  },
+  "collectionAdminConsoleManaged": {
+    "message": "This collection is only accessible from the admin console"
   }
 }