Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-11 10:10:25 +01:00
Code Issues Projects Releases Wiki Activity

[PM-11656] Inline menu updates with empty list of ciphers (#10891)

Browse Source
This commit is contained in:
Cesar Gonzalez 2024-09-04 15:44:08 -05:00 committed by GitHub
parent 1a1d9e2d76
commit 2f69228c21
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
apps/browser/src/autofill/background/overlay.background.ts
View File

@ -139,7 +139,7 @@ export class OverlayBackground implements OverlayBackgroundInterface {
this.triggerDestroyInlineMenuListeners(sender.tab, message.subFrameData.frameId), this.triggerDestroyInlineMenuListeners(sender.tab, message.subFrameData.frameId),
collectPageDetailsResponse: ({ message, sender }) => this.storePageDetails(message, sender), collectPageDetailsResponse: ({ message, sender }) => this.storePageDetails(message, sender),
unlockCompleted: ({ message }) => this.unlockCompleted(message), unlockCompleted: ({ message }) => this.unlockCompleted(message),
doFullSync: () => this.updateOverlayCiphers(true), doFullSync: () => this.updateOverlayCiphers(),
addedCipher: () => this.updateOverlayCiphers(), addedCipher: () => this.updateOverlayCiphers(),
addEditCipherSubmitted: () => this.updateOverlayCiphers(), addEditCipherSubmitted: () => this.updateOverlayCiphers(),
editedCipher: () => this.updateOverlayCiphers(), editedCipher: () => this.updateOverlayCiphers(),
@ -272,7 +272,10 @@ export class OverlayBackground implements OverlayBackgroundInterface {
this.closeInlineMenuAfterCiphersUpdate().catch((error) => this.logService.error(error)); this.closeInlineMenuAfterCiphersUpdate().catch((error) => this.logService.error(error));
} }
if (!currentTab) { if (!currentTab || !currentTab.url?.startsWith("http")) {
if (updateAllCipherTypes) {
this.cardAndIdentityCiphers = null;
}
return; return;
} }