Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-24 12:06:15 +01:00
Code Issues Projects Releases Wiki Activity

userInputs for strength check based on username

Browse Source
This commit is contained in:
Kyle Spearrin 2018-12-12 19:37:27 -05:00
parent fb4bb81595
commit 31655f7832
2 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jslib

@ -1 +1 @@
Subproject commit ed74f73a8ca2d26cacf2f74b4cd14c6150711b87 Subproject commit 6a958afd16cd727c1cfade2f4a0aff3ae22ec28a

23
src/app/tools/weak-passwords-report.component.ts
View File

@ -43,11 +43,26 @@ export class WeakPasswordsReportComponent extends CipherReportComponent implemen
if (c.type !== CipherType.Login || c.login.password == null || c.login.password === '') { if (c.type !== CipherType.Login || c.login.password == null || c.login.password === '') {
return; return;
} }
if (!this.passwordStrengthCache.has(c.login.password)) { const hasUsername = c.login.username != null && c.login.username.trim() !== '';
const result = this.passwordGenerationService.passwordStrength(c.login.password); const cacheKey = c.login.password + '_____' + (hasUsername ? c.login.username : '');
this.passwordStrengthCache.set(c.login.password, result.score); if (!this.passwordStrengthCache.has(cacheKey)) {
let userInput: string[] = [];
if (hasUsername) {
const atPosition = c.login.username.indexOf('@');
if (atPosition > -1) {
userInput = userInput.concat(
c.login.username.substr(0, atPosition).trim().toLowerCase().split(/[^A-Za-z0-9]/))
.filter((i) => i.length >= 3);
} else {
userInput = c.login.username.trim().toLowerCase().split(/[^A-Za-z0-9]/)
.filter((i) => i.length >= 3);
}
}
const result = this.passwordGenerationService.passwordStrength(c.login.password,
userInput.length > 0 ? userInput : null);
this.passwordStrengthCache.set(cacheKey, result.score);
} }
const score = this.passwordStrengthCache.get(c.login.password); const score = this.passwordStrengthCache.get(cacheKey);
if (score != null && score <= 3) { if (score != null && score <= 3) {
this.passwordStrengthMap.set(c.id, this.scoreKey(score)); this.passwordStrengthMap.set(c.id, this.scoreKey(score));
weakPasswordCiphers.push(c); weakPasswordCiphers.push(c);