Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-27 12:36:14 +01:00
Code Issues Projects Releases Wiki Activity

Use radio buttons for password generator type instead of dropdown (#955)

Browse Source 
* fix: radio instead of dropdown

* fix: remove, depend on upstream jslib

* chore: remove unnecessary label

* fix: missing tag

* chore: add label, remove dupl. intlz.

* feat: update jslib version

* Revert "feat: update jslib version"

This reverts commit 85f4b758bda793f10e32f2aea6928bab9be02e07.

* Update jslib

Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
This commit is contained in:
Shashank S 2021-07-07 16:58:41 +05:30 committed by GitHub
parent cf56b68ba5
commit 359daffd9e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
jslib

@ -1 +1 @@
Subproject commit 6f6b5a5503b7aeb7bbd174e3f96a33ce1c9a8037
Subproject commit 119699b82c26296cdd518c0c66e0cd3d61586309

17
src/app/vault/password-generator.component.html
View File

@ -27,12 +27,17 @@
</button>
</div>
<div class="box-content condensed" [hidden]="!showOptions">
<div class="box-content-row" appBoxRow>
<label for="type" class="sr-only">{{'type' | i18n}}</label>
<select id="type" [(ngModel)]="options.type" (change)="saveOptions()">
<option value="password">{{'password' | i18n}}</option>
<option value="passphrase">{{'passphrase' | i18n}}</option>
</select>
<div class="box-content-row box-content-row-radio">
<label class="sr-only radio-header">{{'type' | i18n}}</label>
<div class="radio-group text-default" appBoxRow name="PassTypeOptions"
*ngFor="let o of passTypeOptions">
<input type="radio" class="radio" [(ngModel)]="options.type" name="Type_{{o.value}}"
id="type_{{o.value}}" [value]="o.value" (change)="saveOptions()"
[checked]="options.type === o.value">
<label class="unstyled" for="type_{{o.value}}">
{{o.name}}
</label>
</div>
</div>
</div>
</div>