From 3b54bbd168c5a9c7e49072e1af329ff6a68b930f Mon Sep 17 00:00:00 2001
From: Alec Rippberger <127791530+alec-livefront@users.noreply.github.com>
Date: Mon, 29 Jul 2024 16:24:35 -0500
Subject: [PATCH] [PM-7902] Create V2 Note Component View (#10150)

* Rename <additional-information> component to <additional-options>

The Figma designs show and update to the Additional Information section. The heading changed to "Additional options". It probably makes sense to update the component name to match.

* Make view note header "note" lowercase.

* Add new translation messages for view header.

* Revert "Add new translation messages for view header."

This reverts commit 4e8877fe71062cf0ba29d47fb270f24717904d5d.

* Make cipher headers lowercase via toLowerCase function

* Remove unused import.

* run npm ci && npm run prettier

* add back missing import
---
 .../components/vault-v2/view-v2/view-v2.component.ts  | 11 +++++++----
 .../additional-options.component.html}                |  2 +-
 .../additional-options.component.ts}                  |  6 +++---
 libs/vault/src/cipher-view/cipher-view.component.html |  4 ++--
 libs/vault/src/cipher-view/cipher-view.component.ts   |  4 ++--
 5 files changed, 15 insertions(+), 12 deletions(-)
 rename libs/vault/src/cipher-view/{additional-information/additional-information.component.html => additional-options/additional-options.component.html} (88%)
 rename libs/vault/src/cipher-view/{additional-information/additional-information.component.ts => additional-options/additional-options.component.ts} (80%)

diff --git a/apps/browser/src/vault/popup/components/vault-v2/view-v2/view-v2.component.ts b/apps/browser/src/vault/popup/components/vault-v2/view-v2/view-v2.component.ts
index 8fb3963831..bacb90f043 100644
--- a/apps/browser/src/vault/popup/components/vault-v2/view-v2/view-v2.component.ts
+++ b/apps/browser/src/vault/popup/components/vault-v2/view-v2/view-v2.component.ts
@@ -84,13 +84,16 @@ export class ViewV2Component {
   setHeader(type: CipherType) {
     switch (type) {
       case CipherType.Login:
-        return this.i18nService.t("viewItemHeader", this.i18nService.t("typeLogin"));
+        return this.i18nService.t("viewItemHeader", this.i18nService.t("typeLogin").toLowerCase());
       case CipherType.Card:
-        return this.i18nService.t("viewItemHeader", this.i18nService.t("typeCard"));
+        return this.i18nService.t("viewItemHeader", this.i18nService.t("typeCard").toLowerCase());
       case CipherType.Identity:
-        return this.i18nService.t("viewItemHeader", this.i18nService.t("typeIdentity"));
+        return this.i18nService.t(
+          "viewItemHeader",
+          this.i18nService.t("typeIdentity").toLowerCase(),
+        );
       case CipherType.SecureNote:
-        return this.i18nService.t("viewItemHeader", this.i18nService.t("note"));
+        return this.i18nService.t("viewItemHeader", this.i18nService.t("note").toLowerCase());
     }
   }
 
diff --git a/libs/vault/src/cipher-view/additional-information/additional-information.component.html b/libs/vault/src/cipher-view/additional-options/additional-options.component.html
similarity index 88%
rename from libs/vault/src/cipher-view/additional-information/additional-information.component.html
rename to libs/vault/src/cipher-view/additional-options/additional-options.component.html
index 139307d11e..1650ba2d12 100644
--- a/libs/vault/src/cipher-view/additional-information/additional-information.component.html
+++ b/libs/vault/src/cipher-view/additional-options/additional-options.component.html
@@ -1,6 +1,6 @@
 <bit-section>
   <bit-section-header>
-    <h2 bitTypography="h6">{{ "additionalInformation" | i18n }}</h2>
+    <h2 bitTypography="h6">{{ "additionalOptions" | i18n }}</h2>
   </bit-section-header>
   <bit-card>
     <label class="tw-text-xs tw-text-muted tw-select-none">
diff --git a/libs/vault/src/cipher-view/additional-information/additional-information.component.ts b/libs/vault/src/cipher-view/additional-options/additional-options.component.ts
similarity index 80%
rename from libs/vault/src/cipher-view/additional-information/additional-information.component.ts
rename to libs/vault/src/cipher-view/additional-options/additional-options.component.ts
index ce196b3f57..1ac2ebd146 100644
--- a/libs/vault/src/cipher-view/additional-information/additional-information.component.ts
+++ b/libs/vault/src/cipher-view/additional-options/additional-options.component.ts
@@ -13,8 +13,8 @@ import {
 } from "@bitwarden/components";
 
 @Component({
-  selector: "app-additional-information",
-  templateUrl: "additional-information.component.html",
+  selector: "app-additional-options",
+  templateUrl: "additional-options.component.html",
   standalone: true,
   imports: [
     CommonModule,
@@ -28,6 +28,6 @@ import {
     FormFieldModule,
   ],
 })
-export class AdditionalInformationComponent {
+export class AdditionalOptionsComponent {
   @Input() notes: string;
 }
diff --git a/libs/vault/src/cipher-view/cipher-view.component.html b/libs/vault/src/cipher-view/cipher-view.component.html
index 222ae52a5d..5ef7f12341 100644
--- a/libs/vault/src/cipher-view/cipher-view.component.html
+++ b/libs/vault/src/cipher-view/cipher-view.component.html
@@ -8,9 +8,9 @@
   >
   </app-item-details-v2>
 
-  <!-- ADDITIONAL INFORMATION -->
+  <!-- ADDITIONAL OPTIONS -->
   <ng-container *ngIf="cipher.notes">
-    <app-additional-information [notes]="cipher.notes"> </app-additional-information>
+    <app-additional-options [notes]="cipher.notes"> </app-additional-options>
   </ng-container>
 
   <!-- CUSTOM FIELDS -->
diff --git a/libs/vault/src/cipher-view/cipher-view.component.ts b/libs/vault/src/cipher-view/cipher-view.component.ts
index c2b32f13fd..6e208d6f28 100644
--- a/libs/vault/src/cipher-view/cipher-view.component.ts
+++ b/libs/vault/src/cipher-view/cipher-view.component.ts
@@ -17,7 +17,7 @@ import { PopupFooterComponent } from "../../../../apps/browser/src/platform/popu
 import { PopupHeaderComponent } from "../../../../apps/browser/src/platform/popup/layout/popup-header.component";
 import { PopupPageComponent } from "../../../../apps/browser/src/platform/popup/layout/popup-page.component";
 
-import { AdditionalInformationComponent } from "./additional-information/additional-information.component";
+import { AdditionalOptionsComponent } from "./additional-options/additional-options.component";
 import { AttachmentsV2ViewComponent } from "./attachments/attachments-v2-view.component";
 import { CustomFieldV2Component } from "./custom-fields/custom-fields-v2.component";
 import { ItemDetailsV2Component } from "./item-details/item-details-v2.component";
@@ -35,7 +35,7 @@ import { ItemHistoryV2Component } from "./item-history/item-history-v2.component
     PopupHeaderComponent,
     PopupFooterComponent,
     ItemDetailsV2Component,
-    AdditionalInformationComponent,
+    AdditionalOptionsComponent,
     AttachmentsV2ViewComponent,
     ItemHistoryV2Component,
     CustomFieldV2Component,