mirror of
https://github.com/bitwarden/browser.git
synced 2024-12-22 16:29:09 +01:00
revert to old secrets masking behaviour in browser cipher edit view (#8018)
This commit is contained in:
parent
c6b0f70a26
commit
44bda82bc4
@ -70,18 +70,15 @@
|
||||
<div class="row-main">
|
||||
<label for="loginPassword">{{ "password" | i18n }}</label>
|
||||
<input
|
||||
*ngIf="showPassword"
|
||||
id="loginPassword"
|
||||
class="monospaced"
|
||||
type="text"
|
||||
type="{{ showPassword ? 'text' : 'password' }}"
|
||||
name="Login.Password"
|
||||
[(ngModel)]="cipher.login.password"
|
||||
appInputVerbatim
|
||||
[disabled]="!cipher.viewPassword"
|
||||
[readonly]="!cipher.edit && editMode"
|
||||
/>
|
||||
<div *ngIf="!showPassword" class="monospaced">
|
||||
{{ cipher.login.maskedPassword || "••••••••" }}
|
||||
</div>
|
||||
</div>
|
||||
<div class="action-buttons">
|
||||
<button
|
||||
@ -153,18 +150,15 @@
|
||||
<div class="row-main">
|
||||
<label for="loginTotp">{{ "authenticatorKeyTotp" | i18n }}</label>
|
||||
<input
|
||||
*ngIf="showTotpSeed"
|
||||
id="loginTotp"
|
||||
type="text"
|
||||
type="{{ showTotpSeed ? 'text' : 'password' }}"
|
||||
name="Login.Totp"
|
||||
class="monospaced"
|
||||
[(ngModel)]="cipher.login.totp"
|
||||
appInputVerbatim
|
||||
[disabled]="!cipher.viewPassword"
|
||||
[readonly]="!cipher.edit && editMode"
|
||||
/>
|
||||
<div *ngIf="!showTotpSeed" class="monospaced">
|
||||
{{ cipher.login.maskedPassword || "••••••••" }}
|
||||
</div>
|
||||
</div>
|
||||
<div class="action-buttons">
|
||||
<button
|
||||
|
@ -226,8 +226,6 @@ export class AddEditComponent implements OnInit, OnDestroy {
|
||||
if (!this.allowPersonal && this.organizationId == undefined) {
|
||||
this.organizationId = this.defaultOwnerId;
|
||||
}
|
||||
|
||||
this.resetMaskState();
|
||||
}
|
||||
|
||||
async load() {
|
||||
@ -274,8 +272,6 @@ export class AddEditComponent implements OnInit, OnDestroy {
|
||||
this.cipher.secureNote.type = SecureNoteType.Generic;
|
||||
this.cipher.reprompt = CipherRepromptType.None;
|
||||
}
|
||||
|
||||
this.resetMaskState();
|
||||
}
|
||||
|
||||
if (this.cipher != null && (!this.editMode || loadedAddEditCipherInfo || this.cloneMode)) {
|
||||
@ -517,12 +513,6 @@ export class AddEditComponent implements OnInit, OnDestroy {
|
||||
return true;
|
||||
}
|
||||
|
||||
resetMaskState() {
|
||||
// toggle masks off for maskable login properties with no value on init/load
|
||||
this.showTotpSeed = !this.cipher?.login?.totp;
|
||||
this.showPassword = !this.cipher?.login?.password;
|
||||
}
|
||||
|
||||
togglePassword() {
|
||||
this.showPassword = !this.showPassword;
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user