From 4741eb91ddc95997725bd3318c140bc96122a9b8 Mon Sep 17 00:00:00 2001 From: Kyle Spearrin Date: Fri, 2 Dec 2016 00:05:57 -0500 Subject: [PATCH] few fixes to analytics, checkboxes, and sweetalerts --- src/popup/index.html | 2 +- src/scripts/analytics.js | 4 +++- src/services/utilsService.js | 4 ++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/popup/index.html b/src/popup/index.html index d7fc0456e9..6d73341465 100644 --- a/src/popup/index.html +++ b/src/popup/index.html @@ -22,8 +22,8 @@ - + diff --git a/src/scripts/analytics.js b/src/scripts/analytics.js index f1df2106ce..bdd1f63263 100644 --- a/src/scripts/analytics.js +++ b/src/scripts/analytics.js @@ -1,6 +1,8 @@ var gaTrackingId = chrome.extension.getBackgroundPage().utilsService.analyticsId(); var gaFunc = null; -window.ga = function (action, param1, param2, param3, param4) { + +window.GoogleAnalyticsObject = 'ga'; +window[window.GoogleAnalyticsObject] = function (action, param1, param2, param3, param4) { if (!gaFunc) { return; } diff --git a/src/services/utilsService.js b/src/services/utilsService.js index 9c357868ca..45f727c8d1 100644 --- a/src/services/utilsService.js +++ b/src/services/utilsService.js @@ -70,6 +70,10 @@ function initUtilsService() { } doc.on('click', '.list-section-item', function (e) { + if (e.isDefaultPrevented && e.isDefaultPrevented.name === 'returnTrue') { + return; + } + var text = $(this).find('input, textarea').not('input[type="checkbox"], input[type="radio"], input[type="hidden"]'); var checkbox = $(this).find('input[type="checkbox"]'); var select = $(this).find('select');