Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-12-22 16:29:09 +01:00
Code Issues Projects Releases Wiki Activity

Improve jest performance (#9496)

Browse Source 
Utilizing resources based on thread availability improves performance vs fixed threading.

The linked issue for CI crashes has not been closed. Once this is solves, `runInBand` may improves performance in CI.
This commit is contained in:
Matt Gibson 2024-06-04 10:40:41 -04:00 committed by GitHub
parent 1bf3a4b6eb
commit 490e6c322d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/test.yml vendored
View File

@ -48,10 +48,12 @@ jobs:
# Tests in apps/ are typechecked when their app is built, so we just do it here for libs/ # Tests in apps/ are typechecked when their app is built, so we just do it here for libs/
# See https://bitwarden.atlassian.net/browse/EC-497 # See https://bitwarden.atlassian.net/browse/EC-497
- name: Run typechecking - name: Run typechecking
run: npm run test:types --coverage run: npm run test:types
- name: Run tests - name: Run tests
run: npm run test --coverage # maxWorkers is a workaround for a memory leak that crashes tests in CI:
# https://github.com/facebook/jest/issues/9430#issuecomment-1149882002
run: npm test -- --coverage --maxWorkers=3
- name: Report test results - name: Report test results
uses: dorny/test-reporter@eaa763f6ffc21c7a37837f56cd5f9737f27fc6c8 # v1.8.0 uses: dorny/test-reporter@eaa763f6ffc21c7a37837f56cd5f9737f27fc6c8 # v1.8.0

6
libs/shared/jest.config.angular.js
View File

@ -11,10 +11,8 @@ module.exports = {
".*.type.spec.ts", // ignore type tests (which are checked at compile time and not run by jest) ".*.type.spec.ts", // ignore type tests (which are checked at compile time and not run by jest)
], ],
// Workaround for a memory leak that crashes tests in CI: // Improves on-demand performance, for watches prefer 25%, overridable by setting --maxWorkers
// https://github.com/facebook/jest/issues/9430#issuecomment-1149882002 maxWorkers: "50%",
// Also anecdotally improves performance when run locally
maxWorkers: 3,
transform: { transform: {
"^.+\\.(ts|js|mjs|svg)$": [ "^.+\\.(ts|js|mjs|svg)$": [