Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-01-04 18:37:45 +01:00
Code Issues Projects Releases Wiki Activity

[PM-5189] Fixing a missed promise reference within OverlayBackground

Browse Source
This commit is contained in:
Cesar Gonzalez 2024-06-26 08:29:53 -05:00
parent 9896882659
commit 498b4af3be
No known key found for this signature in database
GPG Key ID: 3381A5457F8CCECF
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/browser/src/autofill/background/abstractions/overlay.background.ts
View File

@ -173,5 +173,5 @@ export type InlineMenuListPortMessageHandlers = {
export interface OverlayBackground { export interface OverlayBackground {
init(): Promise<void>; init(): Promise<void>;
removePageDetails(tabId: number): void; removePageDetails(tabId: number): void;
updateOverlayCiphers(): void; updateOverlayCiphers(): Promise<void>;
} }

9
apps/browser/src/autofill/background/tabs.background.ts
View File

@ -94,7 +94,7 @@ export default class TabsBackground {
return; return;
} }
this.overlayBackground.updateOverlayCiphers(); await this.overlayBackground.updateOverlayCiphers();
if (this.main.onUpdatedRan) { if (this.main.onUpdatedRan) {
return; return;
@ -121,7 +121,10 @@ export default class TabsBackground {
* for the current tab. Also updates the overlay ciphers. * for the current tab. Also updates the overlay ciphers.
*/ */
private updateCurrentTabData = async () => { private updateCurrentTabData = async () => {
this.overlayBackground.updateOverlayCiphers(); await Promise.all([
await Promise.all([this.main.refreshBadge(), this.main.refreshMenu()]); this.main.refreshBadge(),
this.main.refreshMenu(),
this.overlayBackground.updateOverlayCiphers(),
]);
}; };
} }