1
0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-14 10:26:19 +01:00

[PM-14454] Add bit-menu-panel and bitmenuitem to environment selector dropdown (#11866)

* Add bit-menu-panel class and bitmenuitem attribute

* Add data-testids instead of class/attributes
This commit is contained in:
Alec Rippberger 2024-11-06 11:23:38 -06:00 committed by GitHub
parent a959620a11
commit 5a288b97db
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -38,18 +38,20 @@
<div class="box-content"> <div class="box-content">
<div <div
class="environment-selector-dialog" class="environment-selector-dialog"
data-testid="environment-selector-dialog"
[@transformPanel]="'open'" [@transformPanel]="'open'"
cdkTrapFocus cdkTrapFocus
cdkTrapFocusAutoCapture cdkTrapFocusAutoCapture
role="dialog" role="dialog"
aria-modal="true" aria-modal="true"
> >
<ng-container *ngFor="let region of availableRegions"> <ng-container *ngFor="let region of availableRegions; let i = index">
<button <button
type="button" type="button"
class="environment-selector-dialog-item" class="environment-selector-dialog-item"
(click)="toggle(region.key)" (click)="toggle(region.key)"
[attr.aria-pressed]="data.selectedRegion === region ? 'true' : 'false'" [attr.aria-pressed]="data.selectedRegion === region ? 'true' : 'false'"
[attr.data-testid]="'environment-selector-dialog-item-' + i"
> >
<i <i
class="bwi bwi-fw bwi-sm bwi-check" class="bwi bwi-fw bwi-sm bwi-check"
@ -66,6 +68,7 @@
class="environment-selector-dialog-item" class="environment-selector-dialog-item"
(click)="toggle(ServerEnvironmentType.SelfHosted)" (click)="toggle(ServerEnvironmentType.SelfHosted)"
[attr.aria-pressed]="data.selectedRegion ? 'false' : 'true'" [attr.aria-pressed]="data.selectedRegion ? 'false' : 'true'"
data-testid="environment-selector-dialog-item-self-hosted"
> >
<i <i
class="bwi bwi-fw bwi-sm bwi-check" class="bwi bwi-fw bwi-sm bwi-check"