Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2025-01-24 21:41:33 +01:00
Code Issues Projects Releases Wiki Activity

[PM-5189] Fixing issues found within code review behind how we position elements

Browse Source
This commit is contained in:
Cesar Gonzalez 2024-06-25 04:57:53 -05:00
parent 4cd8d4e61d
commit 5cb1d7965f
No known key found for this signature in database
GPG Key ID: 3381A5457F8CCECF
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
apps/browser/src/autofill/background/overlay.background.ts
View File

@ -926,6 +926,7 @@ export class OverlayBackground implements OverlayBackgroundInterface {
return;
}
this.closeInlineMenu(sender);
await this.openViewVaultItemPopout(sender.tab, {
cipherId: cipher.id,
action: SHOW_AUTOFILL_BUTTON,
@ -1034,6 +1035,7 @@ export class OverlayBackground implements OverlayBackgroundInterface {
return;
}
this.closeInlineMenu(sender);
const uriView = new LoginUriView();
uriView.uri = login.uri;
@ -1097,21 +1099,11 @@ export class OverlayBackground implements OverlayBackgroundInterface {
private async checkIsInlineMenuButtonVisible(
sender: chrome.runtime.MessageSender,
): Promise<boolean> {
const isVisible = !!(await BrowserApi.tabSendMessage(
return await BrowserApi.tabSendMessage(
sender.tab,
{ command: "checkIsAutofillInlineMenuButtonVisible" },
{ frameId: 0 },
));
// If the element is visible in the DOM, ensure that it is not hidden by CSS.
if (isVisible) {
void this.toggleInlineMenuHidden(
{ isInlineMenuHidden: false, setTransparentInlineMenu: false },
sender,
);
}
return isVisible;
);
}
/**