Upstream/bitwarden-browser
1
0
Fork 0
mirror of https://github.com/bitwarden/browser.git synced 2024-11-25 12:15:18 +01:00
Code Issues Projects Releases Wiki Activity

[PM-4358] Passkey can be Created but not Retrieved on eBay (#6617)

Browse Source 
* changed behaviour to require user verification when preferred use preferred when user verification is not defined

* changed behaviour to require user verification when preferred use preferred when user verification is not defined
This commit is contained in:
SmithThe4th 2023-10-18 16:25:24 -04:00 committed by GitHub
parent 21b1f87724
commit 5dd2e3a1e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libs/common/src/vault/services/fido2/fido2-client.service.ts
View File

@ -363,9 +363,14 @@ function mapToMakeCredentialParams({
(params.authenticatorSelection?.residentKey === undefined &&
params.authenticatorSelection?.requireResidentKey === true);
const requireUserVerification =
params.authenticatorSelection?.userVerification === "required" ||
params.authenticatorSelection?.userVerification === "preferred" ||
params.authenticatorSelection?.userVerification === undefined;
return {
requireResidentKey,
requireUserVerification: params.authenticatorSelection?.userVerification === "required",
requireUserVerification,
enterpriseAttestationPossible: params.attestation === "enterprise",
excludeCredentialDescriptorList,
credTypesAndPubKeyAlgs,
@ -398,9 +403,14 @@ function mapToGetAssertionParams({
type: "public-key",
}));
const requireUserVerification =
params.userVerification === "required" ||
params.userVerification === "preferred" ||
params.userVerification === undefined;
return {
rpId: params.rpId,
requireUserVerification: params.userVerification === "required",
requireUserVerification,
hash: clientDataHash,
allowCredentialDescriptorList,
extensions: {},